Source Hubspot: turn on default HttpAvailabilityStrategy #22479

grubberr · 2023-02-07T12:07:46Z

Signed-off-by: Sergey Chvalyuk grubberr@gmail.com

What

Issue: #21782 #22255
Turn on default HttpAvailabilityStrategy - it works ok for this connector

Pre-merge Checklist

Expand the relevant checklist and delete the others.

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

grubberr · 2023-02-07T12:12:29Z

/test connector=connectors/source-hubspot

🕑 connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/4113749273
❌ connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/4113749273
🐛 https://gradle.com/s/nwc3h2ltjqhgi

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestBasicRead::test_read[inputs0] - AssertionError: Stre...
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:98: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:507: The previous and actual discovered catalogs are identical.
============= 1 failed, 36 passed, 2 skipped in 226.68s (0:03:46) ==============

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

grubberr · 2023-02-07T17:28:11Z

/test connector=connectors/source-hubspot

🕑 connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/4116582853
✅ connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/4116582853
Python tests coverage:

Name                          Stmts   Miss  Cover
-------------------------------------------------
source_hubspot/errors.py          6      0   100%
source_hubspot/constants.py       2      0   100%
source_hubspot/__init__.py        2      0   100%
source_hubspot/helpers.py        70      3    96%
source_hubspot/streams.py       837     77    91%
source_hubspot/source.py         90     18    80%
-------------------------------------------------
TOTAL                          1007     98    90%
Name                          Stmts   Miss  Cover
-------------------------------------------------
source_hubspot/errors.py          6      0   100%
source_hubspot/constants.py       2      0   100%
source_hubspot/__init__.py        2      0   100%
source_hubspot/helpers.py        70     10    86%
source_hubspot/source.py         90     23    74%
source_hubspot/streams.py       837    268    68%
-------------------------------------------------
TOTAL                          1007    301    70%
	 Name                                                    Stmts   Miss  Cover   Missing
	 -------------------------------------------------------------------------------------
	 connector_acceptance_test/base.py                          12      4    67%   16-19
	 connector_acceptance_test/config.py                       141      5    96%   87, 93, 239, 243-244
	 connector_acceptance_test/conftest.py                     217    101    53%   37, 43-45, 50, 55, 78, 84, 90-92, 111, 116-118, 124-126, 132-133, 138-139, 144, 150, 159-168, 174-179, 194, 218, 249, 255, 263-271, 279-292, 300-313, 318-324, 331-342, 349-365
	 connector_acceptance_test/plugin.py                        69     25    64%   22-23, 31, 36, 120-140, 144-148
	 connector_acceptance_test/tests/test_core.py              476    117    75%   53, 58, 97-108, 113-120, 124-125, 129-130, 380, 400, 438, 476-493, 506-517, 521-526, 532, 565-570, 608-615, 658-660, 663, 728-736, 748-751, 756, 812-813, 819, 822, 858-868, 881-906
	 connector_acceptance_test/tests/test_incremental.py       160     14    91%   58-65, 70-83, 246
	 connector_acceptance_test/utils/asserts.py                 39      2    95%   62-63
	 connector_acceptance_test/utils/common.py                  94     10    89%   16-17, 32-38, 72, 75
	 connector_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 connector_acceptance_test/utils/connector_runner.py       133     33    75%   24-27, 46-47, 50-54, 57-58, 73-75, 78-80, 83-85, 88-90, 93-95, 124-125, 159-161, 208
	 connector_acceptance_test/utils/json_schema_helper.py     114     13    89%   31-32, 39, 42, 66-69, 97, 121, 203-205
	 -------------------------------------------------------------------------------------
	 TOTAL                                                    1696    347    80%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:98: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:507: The previous and actual discovered catalogs are identical.
================== 37 passed, 2 skipped in 258.10s (0:04:18) ===================

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

grubberr · 2023-02-08T11:03:23Z

/test connector=connectors/source-hubspot

🕑 connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/4123432159
✅ connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/4123432159
Python tests coverage:

Name                          Stmts   Miss  Cover
-------------------------------------------------
source_hubspot/errors.py          6      0   100%
source_hubspot/constants.py       2      0   100%
source_hubspot/__init__.py        2      0   100%
source_hubspot/helpers.py        70      3    96%
source_hubspot/streams.py       831     78    91%
source_hubspot/source.py         60     19    68%
-------------------------------------------------
TOTAL                           971    100    90%
Name                          Stmts   Miss  Cover
-------------------------------------------------
source_hubspot/errors.py          6      0   100%
source_hubspot/constants.py       2      0   100%
source_hubspot/__init__.py        2      0   100%
source_hubspot/helpers.py        70     10    86%
source_hubspot/source.py         60     14    77%
source_hubspot/streams.py       831    213    74%
-------------------------------------------------
TOTAL                           971    237    76%
	 Name                                                    Stmts   Miss  Cover   Missing
	 -------------------------------------------------------------------------------------
	 connector_acceptance_test/base.py                          12      4    67%   16-19
	 connector_acceptance_test/config.py                       141      5    96%   87, 93, 239, 243-244
	 connector_acceptance_test/conftest.py                     217    101    53%   37, 43-45, 50, 55, 78, 84, 90-92, 111, 116-118, 124-126, 132-133, 138-139, 144, 150, 159-168, 174-179, 194, 218, 249, 255, 263-271, 279-292, 300-313, 318-324, 331-342, 349-365
	 connector_acceptance_test/plugin.py                        69     25    64%   22-23, 31, 36, 120-140, 144-148
	 connector_acceptance_test/tests/test_core.py              476    117    75%   53, 58, 97-108, 113-120, 124-125, 129-130, 380, 400, 438, 476-493, 506-517, 521-526, 532, 565-570, 608-615, 658-660, 663, 728-736, 748-751, 756, 812-813, 819, 822, 858-868, 881-906
	 connector_acceptance_test/tests/test_incremental.py       160     14    91%   58-65, 70-83, 246
	 connector_acceptance_test/utils/asserts.py                 39      2    95%   62-63
	 connector_acceptance_test/utils/common.py                  94     10    89%   16-17, 32-38, 72, 75
	 connector_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 connector_acceptance_test/utils/connector_runner.py       133     33    75%   24-27, 46-47, 50-54, 57-58, 73-75, 78-80, 83-85, 88-90, 93-95, 124-125, 159-161, 208
	 connector_acceptance_test/utils/json_schema_helper.py     114     13    89%   31-32, 39, 42, 66-69, 97, 121, 203-205
	 -------------------------------------------------------------------------------------
	 TOTAL                                                    1696    347    80%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:98: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:507: The previous and actual discovered catalogs are identical.
================== 37 passed, 2 skipped in 314.82s (0:05:14) ===================

erohmensing

Looks good! Just some questions about things that look less related. Deleting code 🥳

airbyte-integrations/connectors/source-hubspot/integration_tests/expected_records.jsonl

airbyte-integrations/connectors/source-hubspot/source_hubspot/source.py

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

grubberr · 2023-02-08T23:32:49Z

/publish connector=connectors/source-hubspot

🕑 Publishing the following connectors:
connectors/source-hubspot
https://github.com/airbytehq/airbyte/actions/runs/4129378007

Connector	Did it publish?	Were definitions generated?
connectors/source-hubspot	❌	❌

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

grubberr · 2023-02-09T05:49:18Z

/test connector=connectors/source-hubspot

🕑 connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/4131382617
✅ connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/4131382617
Python tests coverage:

Name                          Stmts   Miss  Cover
-------------------------------------------------
source_hubspot/errors.py          6      0   100%
source_hubspot/constants.py       2      0   100%
source_hubspot/__init__.py        2      0   100%
source_hubspot/helpers.py        70      3    96%
source_hubspot/streams.py       831     78    91%
source_hubspot/source.py         60     19    68%
-------------------------------------------------
TOTAL                           971    100    90%
Name                          Stmts   Miss  Cover
-------------------------------------------------
source_hubspot/errors.py          6      0   100%
source_hubspot/constants.py       2      0   100%
source_hubspot/__init__.py        2      0   100%
source_hubspot/helpers.py        70     10    86%
source_hubspot/source.py         60     14    77%
source_hubspot/streams.py       831    213    74%
-------------------------------------------------
TOTAL                           971    237    76%
	 Name                                                    Stmts   Miss  Cover   Missing
	 -------------------------------------------------------------------------------------
	 connector_acceptance_test/base.py                          12      4    67%   16-19
	 connector_acceptance_test/config.py                       141      5    96%   87, 93, 239, 243-244
	 connector_acceptance_test/conftest.py                     217    101    53%   37, 43-45, 50, 55, 78, 84, 90-92, 111, 116-118, 124-126, 132-133, 138-139, 144, 150, 159-168, 174-179, 194, 218, 249, 255, 263-271, 279-292, 300-313, 318-324, 331-342, 349-365
	 connector_acceptance_test/plugin.py                        69     25    64%   22-23, 31, 36, 120-140, 144-148
	 connector_acceptance_test/tests/test_core.py              476    117    75%   53, 58, 97-108, 113-120, 124-125, 129-130, 380, 400, 438, 476-493, 506-517, 521-526, 532, 565-570, 608-615, 658-660, 663, 728-736, 748-751, 756, 812-813, 819, 822, 858-868, 881-906
	 connector_acceptance_test/tests/test_incremental.py       160     14    91%   58-65, 70-83, 246
	 connector_acceptance_test/utils/asserts.py                 39      2    95%   62-63
	 connector_acceptance_test/utils/common.py                  94     10    89%   16-17, 32-38, 72, 75
	 connector_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 connector_acceptance_test/utils/connector_runner.py       133     33    75%   24-27, 46-47, 50-54, 57-58, 73-75, 78-80, 83-85, 88-90, 93-95, 124-125, 159-161, 208
	 connector_acceptance_test/utils/json_schema_helper.py     114     13    89%   31-32, 39, 42, 66-69, 97, 121, 203-205
	 -------------------------------------------------------------------------------------
	 TOTAL                                                    1696    347    80%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:98: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:507: The previous and actual discovered catalogs are identical.
================== 37 passed, 2 skipped in 339.29s (0:05:39) ===================

grubberr · 2023-02-09T06:15:41Z

/publish connector=connectors/source-hubspot

🕑 Publishing the following connectors:
connectors/source-hubspot
https://github.com/airbytehq/airbyte/actions/runs/4131529129

Connector	Did it publish?	Were definitions generated?
connectors/source-hubspot	✅	✅

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

github-actions · 2023-02-09T06:49:27Z

Airbyte Code Coverage

There is no coverage information present for the Files changed

Total Project Coverage	24.66%	❌

bump 0.3.2

277aa23

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

octavia-squidington-iii added area/connectors Connector related issues connectors/source/hubspot labels Feb 7, 2023

hubspot.md updated

74b164b

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Feb 7, 2023

grubberr self-assigned this Feb 7, 2023

grubberr added 2 commits February 7, 2023 17:27

expected_records.jsonl updated

648cb88

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

Merge branch 'master' into grubberr/21782-source-hubspot

c8c19af

grubberr added 3 commits February 8, 2023 07:03

Merge branch 'master' into grubberr/21782-source-hubspot

caa0357

remove all related to old Quotes stream

8b97ccd

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

test_stream_forbidden added

6974c3a

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

grubberr requested a review from erohmensing February 8, 2023 13:34

erohmensing reviewed Feb 8, 2023

View reviewed changes

airbyte-integrations/connectors/source-hubspot/integration_tests/expected_records.jsonl Show resolved Hide resolved

airbyte-integrations/connectors/source-hubspot/source_hubspot/source.py Show resolved Hide resolved

grubberr requested a review from erohmensing February 8, 2023 21:31

erohmensing approved these changes Feb 8, 2023

View reviewed changes

grubberr added 2 commits February 8, 2023 23:31

Merge branch 'master' into grubberr/21782-source-hubspot

faa4c05

expected_records.jsonl revert to master

a697d5e

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

grubberr added 2 commits February 9, 2023 05:25

Merge branch 'master' into grubberr/21782-source-hubspot

665b322

fixed

10c1bf0

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

auto-bump connector version

9151a6f

airbyteio temporarily deployed to more-secrets February 9, 2023 06:42 — with GitHub Actions Inactive

airbyteio temporarily deployed to more-secrets February 9, 2023 08:17 — with GitHub Actions Inactive

grubberr merged commit e2100c4 into master Feb 9, 2023

grubberr deleted the grubberr/21782-source-hubspot branch February 9, 2023 09:23

github-actions bot mentioned this pull request Feb 9, 2023

Bump helm chart version reference to 0.43.34 #22684

Closed

This was referenced Feb 10, 2023

Bump Airbyte version from 0.40.32 to 0.40.33 #22689

Closed

Bump Airbyte version from 0.40.32 to 0.40.33 #22839

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Source Hubspot: turn on default HttpAvailabilityStrategy #22479

Source Hubspot: turn on default HttpAvailabilityStrategy #22479

grubberr commented Feb 7, 2023 •

edited

Loading

grubberr commented Feb 7, 2023 •

edited by github-actions bot

Loading

grubberr commented Feb 7, 2023 •

edited by github-actions bot

Loading

grubberr commented Feb 8, 2023 •

edited by github-actions bot

Loading

erohmensing left a comment •

edited

Loading

grubberr commented Feb 8, 2023 •

edited by github-actions bot

Loading

grubberr commented Feb 9, 2023 •

edited by github-actions bot

Loading

grubberr commented Feb 9, 2023 •

edited by github-actions bot

Loading

github-actions bot commented Feb 9, 2023

Source Hubspot: turn on default HttpAvailabilityStrategy #22479

Source Hubspot: turn on default HttpAvailabilityStrategy #22479

Conversation

grubberr commented Feb 7, 2023 • edited Loading

What

Pre-merge Checklist

Community member or Airbyter

Airbyter

grubberr commented Feb 7, 2023 • edited by github-actions bot Loading

Build Failed

grubberr commented Feb 7, 2023 • edited by github-actions bot Loading

Build Passed

grubberr commented Feb 8, 2023 • edited by github-actions bot Loading

Build Passed

erohmensing left a comment • edited Loading

Choose a reason for hiding this comment

grubberr commented Feb 8, 2023 • edited by github-actions bot Loading

grubberr commented Feb 9, 2023 • edited by github-actions bot Loading

Build Passed

grubberr commented Feb 9, 2023 • edited by github-actions bot Loading

github-actions bot commented Feb 9, 2023

Airbyte Code Coverage

grubberr commented Feb 7, 2023 •

edited

Loading

grubberr commented Feb 7, 2023 •

edited by github-actions bot

Loading

grubberr commented Feb 7, 2023 •

edited by github-actions bot

Loading

grubberr commented Feb 8, 2023 •

edited by github-actions bot

Loading

erohmensing left a comment •

edited

Loading

grubberr commented Feb 8, 2023 •

edited by github-actions bot

Loading

grubberr commented Feb 9, 2023 •

edited by github-actions bot

Loading

grubberr commented Feb 9, 2023 •

edited by github-actions bot

Loading