Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

document that web backends should not have db access #22509

Merged
merged 1 commit into from
Feb 7, 2023
Merged

document that web backends should not have db access #22509

merged 1 commit into from
Feb 7, 2023

Conversation

cgardens
Copy link
Contributor

@cgardens cgardens commented Feb 7, 2023

What

  • it was a mistake that ConfigRepository was ever added to the web backend.
  • it is now now not easy to remove, but we need to more clearly signal to people that they should not use it for new cases (which keeps happening).
  • add java doc explaining the purpose of the webbackend.

How

  • rename the field to make it clear that it shouldn't be used.
  • deprecate the field

@cgardens cgardens temporarily deployed to more-secrets February 7, 2023 18:16 — with GitHub Actions Inactive
@cgardens cgardens temporarily deployed to more-secrets February 7, 2023 18:16 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Feb 7, 2023

Airbyte Code Coverage

There is no coverage information present for the Files changed

Total Project Coverage 24.53% ❌

@cgardens cgardens merged commit e745e73 into master Feb 7, 2023
@cgardens cgardens deleted the cgardens/document-web-backend branch February 7, 2023 19:14
@github-actions github-actions bot mentioned this pull request Feb 8, 2023
Closed
@octavia-squidington-iii octavia-squidington-iii mentioned this pull request Feb 8, 2023
Closed
danidelvalle pushed a commit to danidelvalle/airbyte that referenced this pull request Feb 9, 2023
@cgardens @danidelvalle-frontiers
document that web backends should not have db access (airbytehq#22509)
0765c17
This was referenced Feb 10, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benmoriceau benmoriceau benmoriceau approved these changes

@gosusnp gosusnp Awaiting requested review from gosusnp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cgardens @benmoriceau