Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fixes #19674
Change the
bumpconfig
configuration file to not blindly update all versions that might occasionally be the same as ours in some files. This could have broken in case e.g. any dependency in the webapp would have had the same version that we have, on any OSS release.I went through all the files and for all files I felt there is a danger we might update arbitrary other versions, that are in that file, I added a clear
search
/replace
config that now only updates the version we actually want to update.I've also removed the
package-lock.json
, since it doesn't exist anymore since our change topnpm
and thepnpm-lock.yml
file doesn't have our own version printed in it (in contrast to the npm lock file).You can test this locally by making sure to put the same version as our current one in each of the files with a
search
/replace
and check that using thebumpversion
tool will only bump the correct version. That's how I validated it locally.