Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bumpversion config #22511

Merged
merged 1 commit into from
Feb 8, 2023
Merged

Fix bumpversion config #22511

merged 1 commit into from
Feb 8, 2023

Conversation

timroes
Copy link
Contributor

@timroes timroes commented Feb 7, 2023

What

Fixes #19674

Change the bumpconfig configuration file to not blindly update all versions that might occasionally be the same as ours in some files. This could have broken in case e.g. any dependency in the webapp would have had the same version that we have, on any OSS release.

I went through all the files and for all files I felt there is a danger we might update arbitrary other versions, that are in that file, I added a clear search/replace config that now only updates the version we actually want to update.

I've also removed the package-lock.json, since it doesn't exist anymore since our change to pnpm and the pnpm-lock.yml file doesn't have our own version printed in it (in contrast to the npm lock file).

You can test this locally by making sure to put the same version as our current one in each of the files with a search/replace and check that using the bumpversion tool will only bump the correct version. That's how I validated it locally.

Copy link
Contributor

@supertopher supertopher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change seems like it will make bump version less greedy.
That sounds great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bumpversion blindly updates versions
2 participants