Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

should have workspaceid for update connection #22512

Merged
merged 2 commits into from
Feb 7, 2023
Merged

Conversation

xiaohansong
Copy link
Contributor

What

otherwise checkConnectionForUpdate would fail because it needs workspace id to look up the geography to determine which region it should run.

How

Describe the solution

Recommended reading order

  1. x.java
  2. y.python

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the connector is published, connector added to connector index as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here
Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub and connector version bumped by running the /publish command described here
Connector Generator
  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed

@xiaohansong xiaohansong temporarily deployed to more-secrets February 7, 2023 19:02 — with GitHub Actions Inactive
@xiaohansong xiaohansong temporarily deployed to more-secrets February 7, 2023 19:03 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Feb 7, 2023

Platform Test Results

   241 files   - 2     241 suites   - 2   30m 49s ⏱️ + 2m 5s
1 664 tests  - 2  1 653 ✔️  - 2  11 💤 ±0  0 ±0 
1 683 runs   - 2  1 672 ✔️  - 2  11 💤 ±0  0 ±0 

Results for commit 644ef25. ± Comparison against base commit 9709adf.

♻️ This comment has been updated with latest results.

@xiaohansong xiaohansong requested a review from pmossman February 7, 2023 20:09
@xiaohansong xiaohansong temporarily deployed to more-secrets February 7, 2023 20:11 — with GitHub Actions Inactive
@xiaohansong xiaohansong temporarily deployed to more-secrets February 7, 2023 20:11 — with GitHub Actions Inactive
@xiaohansong xiaohansong enabled auto-merge (squash) February 7, 2023 20:17
@github-actions
Copy link
Contributor

github-actions bot commented Feb 7, 2023

Airbyte Code Coverage

There is no coverage information present for the Files changed

Total Project Coverage 24.56%

@xiaohansong xiaohansong merged commit 6f0c0be into master Feb 7, 2023
@xiaohansong xiaohansong deleted the xiaohan/workspaceid branch February 7, 2023 20:48
danidelvalle pushed a commit to danidelvalle/airbyte that referenced this pull request Feb 9, 2023
* should have workspaceid for update connection

* add test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants