Add normalization strict incremental feature flag #22514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
octavia-squidington-iii
added
area/platform
gosusnp
requested review from
jdpgrailsdev,
alovew,
benmoriceau and
colesnodgrass
gosusnp
deleted the
gosusnp/normalization-strict-incremental-feature-flag
branch
benmoriceau
added a commit
that referenced
this pull request
Feb 8, 2023
This reverts commit ddcdcbb.
benmoriceau
added a commit
that referenced
this pull request
Feb 9, 2023
benmoriceau
added a commit
that referenced
this pull request
Feb 9, 2023
benmoriceau
added a commit
that referenced
this pull request
Feb 9, 2023
danidelvalle
pushed a commit
to danidelvalle/airbyte
that referenced
this pull request
Feb 9, 2023
* maybe add feature flag? * pattern matching * also add version check * formatting * refactor test also * extract test + fix method call * minor tweaks * add context to log message * put workspace id in normalization input * use non-semver tag * add flag for version of normalization * also flag old version * add test * missed part of the commit * format * add test for null workspace ID * Revert "also flag old version" This reverts commit 3be601d. * Revert "missed part of the commit" This reverts commit 47a67b4. * always apply flag, even if we're behind a version * derp * Add more logging to the normalization activity * Update charts and kustomize for the feature flag * Format --------- Co-authored-by: Edward Gao <edward.gao@airbyte.io>
danidelvalle
pushed a commit
to danidelvalle/airbyte
that referenced
this pull request
Feb 9, 2023
…22514)" (airbytehq#22612) This reverts commit ddcdcbb.
danidelvalle
pushed a commit
to danidelvalle/airbyte
that referenced
this pull request
Feb 9, 2023
…rbytehq#22514)" (airbytehq#22612)" (airbytehq#22619) This reverts commit 8702cdf.
This was referenced Feb 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Extracted the backend changes from #22381
How
Describe the solution