Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tentatively disallowed normalization for DuckDB #22528

Merged
merged 1 commit into from
Feb 8, 2023
Merged

Conversation

ryankfu
Copy link
Contributor

@ryankfu ryankfu commented Feb 7, 2023

What

Reverts normalization changes for DuckDB due to undefined setup_duck_db method within dbt_integration_test.py, this is primarily to unblock some feature work with normalization that is blocked by the integration setup

How

Removes some work from DuckDB, this branch will also publish DuckDB to our docker hub

Recommended reading order

  1. destination_definitions.yaml
  2. dbt_integration_test.py

🚨 User Impact 🚨

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the connector is published, connector added to connector index as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here
Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub and connector version bumped by running the /publish command described here
Connector Generator
  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed

@ryankfu ryankfu requested a review from a team as a code owner February 7, 2023 21:42
@ryankfu ryankfu requested a review from edgao February 7, 2023 21:42
@octavia-squidington-iii octavia-squidington-iii added area/documentation Improvements or additions to documentation normalization labels Feb 7, 2023
@ryankfu ryankfu temporarily deployed to more-secrets February 7, 2023 21:44 — with GitHub Actions Inactive
@ryankfu ryankfu temporarily deployed to more-secrets February 7, 2023 21:44 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Feb 7, 2023

Airbyte Code Coverage

There is no coverage information present for the Files changed

Total Project Coverage 24.56%

Copy link
Contributor

@edgao edgao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was there no actual change in the normalization changelog? Github says just whitespace changes in this PR


If you set [Normalization](https://docs.airbyte.com/understanding-airbyte/basic-normalization/), source data will be normalized to a tabular form. Let's say you have a source such as GitHub with nested JSONs; the Normalization ensures you end up with tables and columns. Suppose you have a many-to-many relationship between the users and commits. Normalization will create separate tables for it. The end state is the [third normal form](https://en.wikipedia.org/wiki/Third_normal_form) (3NF).

If turn off the Normalization, each stream will be output into its own table `_airbyte_raw_{stream_name}`. Each table will contain 3 columns:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This section is still true, so let's keep it. I.e. just remove the "if you turn off normalization" bit

@ryankfu ryankfu force-pushed the ryan/duck-db-publish branch from 3ef50f8 to 47a1b59 Compare February 7, 2023 23:03
@ryankfu ryankfu temporarily deployed to more-secrets February 7, 2023 23:05 — with GitHub Actions Inactive
@ryankfu ryankfu temporarily deployed to more-secrets February 7, 2023 23:05 — with GitHub Actions Inactive
@ryankfu
Copy link
Contributor Author

ryankfu commented Feb 8, 2023

/publish connector=connectors/destination-duckdb

🕑 Publishing the following connectors:
connectors/destination-duckdb
https://github.com/airbytehq/airbyte/actions/runs/4119373509


Connector Did it publish? Were definitions generated?
connectors/destination-duckdb

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@ryankfu ryankfu temporarily deployed to more-secrets February 8, 2023 01:13 — with GitHub Actions Inactive
@ryankfu ryankfu temporarily deployed to more-secrets February 8, 2023 01:13 — with GitHub Actions Inactive
@ryankfu ryankfu temporarily deployed to more-secrets February 8, 2023 03:39 — with GitHub Actions Inactive
@ryankfu ryankfu temporarily deployed to more-secrets February 8, 2023 03:39 — with GitHub Actions Inactive
@ryankfu ryankfu merged commit d21068c into master Feb 8, 2023
@ryankfu ryankfu deleted the ryan/duck-db-publish branch February 8, 2023 04:22
danidelvalle pushed a commit to danidelvalle/airbyte that referenced this pull request Feb 9, 2023
@sspaeti sspaeti mentioned this pull request Feb 20, 2023
37 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Improvements or additions to documentation normalization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants