Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kustomize: Set up S3 state config variables #22537

Merged
merged 4 commits into from
Feb 8, 2023

Conversation

davinchia
Copy link
Contributor

@davinchia davinchia commented Feb 7, 2023

What

Kustomize charts are missing this today. OSS users are running into this and complaining.

Application logic fixed in #22191.

This PR fixes the Kustomize deployments.

How

Add the S3 vars to the relevant deployments.

Recommended reading order

All files.

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the connector is published, connector added to connector index as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here
Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub and connector version bumped by running the /publish command described here
Connector Generator
  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed

@octavia-squidington-iii octavia-squidington-iii added area/platform issues related to the platform kubernetes labels Feb 7, 2023
@davinchia davinchia temporarily deployed to more-secrets February 7, 2023 23:56 — with GitHub Actions Inactive
@davinchia davinchia temporarily deployed to more-secrets February 7, 2023 23:56 — with GitHub Actions Inactive
@davinchia davinchia changed the title Set up S3 state config variables. Kustomize: Set up S3 state config variables Feb 7, 2023
@davinchia davinchia temporarily deployed to more-secrets February 8, 2023 00:00 — with GitHub Actions Inactive
@davinchia davinchia temporarily deployed to more-secrets February 8, 2023 00:00 — with GitHub Actions Inactive
@davinchia davinchia marked this pull request as ready for review February 8, 2023 00:00
@github-actions
Copy link
Contributor

github-actions bot commented Feb 8, 2023

Airbyte Code Coverage

There is no coverage information present for the Files changed

Total Project Coverage 24.66%

@davinchia davinchia temporarily deployed to more-secrets February 8, 2023 00:02 — with GitHub Actions Inactive
@davinchia davinchia temporarily deployed to more-secrets February 8, 2023 00:02 — with GitHub Actions Inactive
Copy link
Contributor

@jdpgrailsdev jdpgrailsdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@davinchia davinchia temporarily deployed to more-secrets February 8, 2023 00:44 — with GitHub Actions Inactive
@davinchia davinchia temporarily deployed to more-secrets February 8, 2023 00:44 — with GitHub Actions Inactive
@davinchia davinchia merged commit 4180b57 into master Feb 8, 2023
@davinchia davinchia deleted the davinchia/fix-state-setup branch February 8, 2023 01:54
danidelvalle pushed a commit to danidelvalle/airbyte that referenced this pull request Feb 9, 2023
Kustomize charts are missing this today. OSS users are running into this and complaining.

Application logic fixed in airbytehq#22191.

This PR fixes the Kustomize deployments.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/platform issues related to the platform kubernetes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants