-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kustomize: Set up S3 state config variables #22537
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
octavia-squidington-iii
added
area/platform
issues related to the platform
kubernetes
labels
Feb 7, 2023
davinchia
temporarily deployed
to
more-secrets
February 7, 2023 23:56 — with
GitHub Actions
Inactive
davinchia
temporarily deployed
to
more-secrets
February 7, 2023 23:56 — with
GitHub Actions
Inactive
davinchia
changed the title
Set up S3 state config variables.
Kustomize: Set up S3 state config variables
Feb 7, 2023
davinchia
temporarily deployed
to
more-secrets
February 8, 2023 00:00 — with
GitHub Actions
Inactive
davinchia
temporarily deployed
to
more-secrets
February 8, 2023 00:00 — with
GitHub Actions
Inactive
Airbyte Code Coverage
|
davinchia
temporarily deployed
to
more-secrets
February 8, 2023 00:02 — with
GitHub Actions
Inactive
davinchia
temporarily deployed
to
more-secrets
February 8, 2023 00:02 — with
GitHub Actions
Inactive
jdpgrailsdev
approved these changes
Feb 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
davinchia
temporarily deployed
to
more-secrets
February 8, 2023 00:44 — with
GitHub Actions
Inactive
davinchia
temporarily deployed
to
more-secrets
February 8, 2023 00:44 — with
GitHub Actions
Inactive
danidelvalle
pushed a commit
to danidelvalle/airbyte
that referenced
this pull request
Feb 9, 2023
Kustomize charts are missing this today. OSS users are running into this and complaining. Application logic fixed in airbytehq#22191. This PR fixes the Kustomize deployments.
This was referenced Feb 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Kustomize charts are missing this today. OSS users are running into this and complaining.
Application logic fixed in #22191.
This PR fixes the Kustomize deployments.
How
Add the S3 vars to the relevant deployments.
Recommended reading order
All files.
🚨 User Impact 🚨
Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.
Pre-merge Checklist
Expand the relevant checklist and delete the others.
New Connector
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampledocs/integrations/README.md
airbyte-integrations/builds.md
Airbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing/publish
command described hereUpdating a connector
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampleAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing/publish
command described hereConnector Generator
-scaffold
in their name) have been updated with the latest scaffold by running./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates
then checking in your changes