Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move TreeNode #22545

Merged
merged 1 commit into from
Feb 8, 2023
Merged

move TreeNode #22545

merged 1 commit into from
Feb 8, 2023

Conversation

colesnodgrass
Copy link
Member

What

  • move TreeNode from protocol-models to db-lib
    • this class was only used in mongodb package

How

  • drag-n-drop

@colesnodgrass colesnodgrass requested a review from c-p-b February 8, 2023 02:20
@colesnodgrass colesnodgrass requested a review from a team as a code owner February 8, 2023 02:20
@colesnodgrass colesnodgrass temporarily deployed to more-secrets February 8, 2023 02:22 — with GitHub Actions Inactive
@colesnodgrass colesnodgrass temporarily deployed to more-secrets February 8, 2023 02:22 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Feb 8, 2023

Airbyte Code Coverage

File Coverage [4.07%] ❌
MongoUtils.java 4.31% ❌
TreeNode.java 0% ❌
Total Project Coverage 24.66% ❌

@colesnodgrass colesnodgrass temporarily deployed to more-secrets February 8, 2023 04:07 — with GitHub Actions Inactive
@colesnodgrass colesnodgrass temporarily deployed to more-secrets February 8, 2023 04:07 — with GitHub Actions Inactive
@colesnodgrass colesnodgrass merged commit 577be93 into master Feb 8, 2023
@colesnodgrass colesnodgrass deleted the cole/mv-treenode branch February 8, 2023 16:32
@github-actions github-actions bot mentioned this pull request Feb 9, 2023
Closed
danidelvalle pushed a commit to danidelvalle/airbyte that referenced this pull request Feb 9, 2023
@colesnodgrass @danidelvalle-frontiers
move TreeNode (airbytehq#22545)
653a8a3
This was referenced Feb 10, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c-p-b c-p-b c-p-b approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@colesnodgrass @c-p-b