Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source S3: validate CSV read options and convert options #22550

Merged
merged 6 commits into from
Feb 9, 2023

Conversation

davydov-d
Copy link
Collaborator

What

https://github.com/airbytehq/oncall/issues/1467

How

Add validation for CSV read options and convert options

@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Feb 8, 2023
@davydov-d
Copy link
Collaborator Author

davydov-d commented Feb 8, 2023

/test connector=connectors/source-s3

🕑 connectors/source-s3 https://github.com/airbytehq/airbyte/actions/runs/4122734019
❌ connectors/source-s3 https://github.com/airbytehq/airbyte/actions/runs/4122734019
🐛 https://gradle.com/s/vcprrdt5deqmq

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestBasicRead::test_read[inputs2] - Failed: Please check...
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:98: The previous and actual specifications are identical.
SKIPPED [6] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:507: The previous and actual discovered catalogs are identical.
============= 1 failed, 107 passed, 7 skipped in 259.51s (0:04:19) =============

@davydov-d
Copy link
Collaborator Author

☝️ the failing test is not related. It's about the actual and expected schema mismatch (avro)

@davydov-d
Copy link
Collaborator Author

davydov-d commented Feb 9, 2023

/test connector=connectors/source-s3

🕑 connectors/source-s3 https://github.com/airbytehq/airbyte/actions/runs/4132391051
❌ connectors/source-s3 https://github.com/airbytehq/airbyte/actions/runs/4132391051
🐛 https://gradle.com/s/cdhjjau5p6duk

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestBasicRead::test_read[inputs2] - Failed: Please check...
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:98: The previous and actual specifications are identical.
SKIPPED [6] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:507: The previous and actual discovered catalogs are identical.
============= 1 failed, 107 passed, 7 skipped in 258.65s (0:04:18) =============

@davydov-d
Copy link
Collaborator Author

davydov-d commented Feb 9, 2023

/publish connector=connectors/source-s3 run-tests=false

🕑 Publishing the following connectors:
connectors/source-s3
https://github.com/airbytehq/airbyte/actions/runs/4135402872


Connector Did it publish? Were definitions generated?
connectors/source-s3

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@airbyteio airbyteio temporarily deployed to more-secrets February 9, 2023 15:02 — with GitHub Actions Inactive
@airbyteio airbyteio temporarily deployed to more-secrets February 9, 2023 15:02 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Feb 9, 2023

Airbyte Code Coverage

There is no coverage information present for the Files changed

Total Project Coverage 24.66%

@davydov-d davydov-d temporarily deployed to more-secrets February 9, 2023 15:51 — with GitHub Actions Inactive
@davydov-d davydov-d temporarily deployed to more-secrets February 9, 2023 15:51 — with GitHub Actions Inactive
@davydov-d davydov-d merged commit fcd3b03 into master Feb 9, 2023
@davydov-d davydov-d deleted the ddavydov/#1467-source-s3-validate-config branch February 9, 2023 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/s3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants