Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🪟 🎨 Fix Configuration settings page layout #22565

Merged
merged 2 commits into from
Feb 8, 2023

Conversation

edmundito
Copy link
Contributor

What

Updates the Configuration setting page layout to be consistent with other pages.

How

  • Card extends to full width as other settings pages
  • Removes extra top margin

@edmundito edmundito requested a review from dizel852 February 8, 2023 15:45
@octavia-squidington-iii octavia-squidington-iii added the area/frontend Related to the Airbyte webapp label Feb 8, 2023
Copy link
Contributor

@dizel852 dizel852 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
Tested locally - UI is consistent with other pages

@edmundito edmundito merged commit 4ab4cec into master Feb 8, 2023
@edmundito edmundito deleted the edmundito/fix-settings-layouts branch February 8, 2023 21:39
danidelvalle pushed a commit to danidelvalle/airbyte that referenced this pull request Feb 9, 2023
* Cleanup ConfigurationsPage layout, extend card width to fit page remove top margin

* Replace div with fragment in ConfigurationsPage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/frontend Related to the Airbyte webapp
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants