Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CDK: gitignore files generated during unit test runs #22616

Merged
merged 2 commits into from
Feb 8, 2023

Conversation

sherifnada
Copy link
Contributor

What

Running python -m pytest -s unit_tests/ generates a bunch of random files in airbyte-cdk/python. This PR .gitignores those files until we fix them properly (#19533 is an attempt to do that)

@sherifnada sherifnada marked this pull request as ready for review February 8, 2023 23:39
@sherifnada sherifnada requested a review from a team as a code owner February 8, 2023 23:39
@sherifnada sherifnada requested a review from maxi297 February 8, 2023 23:40
Copy link
Contributor

@maxi297 maxi297 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants