Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable flaky testDowntimeDuringSync test #22621

Merged
merged 1 commit into from
Feb 9, 2023

Conversation

gosusnp
Copy link
Contributor

@gosusnp gosusnp commented Feb 9, 2023

What

Disable flaky testDowntimeDuringSync test

How

Disable flaky testDowntimeDuringSync test

@@ -104,6 +105,7 @@ void setup() throws URISyntaxException, IOException, SQLException {
// This test is flaky. Warnings are suppressed until that condition us understood
// See: https://github.com/airbytehq/airbyte/issues/19948
@Test
@Disabled("Flaky test, to be investigated before re-enabling")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have an issue to track that?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh I missed that

@gosusnp gosusnp temporarily deployed to more-secrets February 9, 2023 00:19 — with GitHub Actions Inactive
@gosusnp gosusnp temporarily deployed to more-secrets February 9, 2023 00:19 — with GitHub Actions Inactive
@gosusnp gosusnp enabled auto-merge (squash) February 9, 2023 00:19
@github-actions
Copy link
Contributor

github-actions bot commented Feb 9, 2023

Airbyte Code Coverage

There is no coverage information present for the Files changed

Total Project Coverage 24.66%

@gosusnp gosusnp merged commit f5e0f80 into master Feb 9, 2023
@gosusnp gosusnp deleted the gosusnp/disable-flaky-test-downtime-during-sync branch February 9, 2023 01:19
danidelvalle pushed a commit to danidelvalle/airbyte that referenced this pull request Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants