QA-Engine: Persist daily reports to GCS #22662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alafanechere
temporarily deployed
to
more-secrets
GitHub Actions
Inactive
alafanechere
temporarily deployed
to
more-secrets
GitHub Actions
Inactive
Airbyte Code Coverage
|
zzztimbo
reviewed
Feb 9, 2023
| def persist_qa_report(qa_report: pd.DataFrame, path: str, public_fields_only: bool =True): | ||
|
|
||
| def persist_qa_report(qa_report: pd.DataFrame, path: str, public_fields_only: bool = True) -> str: | ||
| report_generation_date = datetime.strftime(qa_report["report_generation_datetime"].max(), "%Y%m%d") |
There was a problem hiding this comment.
Is report_generation_datetime different for each row in the qa_report?
There was a problem hiding this comment.
No its the same value on each row for a report.
evantahler
approved these changes
Feb 9, 2023
Comment on lines
+5
to
+8
| schedule: | ||
| # 1pm UTC is 6am PDT. | ||
| # same time as Generate Build Report | ||
| - cron: "0 13 * * *" |
bnchrch
approved these changes
Feb 9, 2023
| @@ -32,3 +32,4 @@ jobs: | |||
| QA_ENGINE_AIRBYTE_DATA_PROD_SA: "${{ secrets.QA_ENGINE_AIRBYTE_DATA_PROD_SA }}" | |||
| GITHUB_API_TOKEN: ${{ secrets.GH_PAT_MAINTENANCE_OCTAVIA }} | |||
| run: run-qa-engine | |||
| # run: run-qa-engine --create-prs | |||
There was a problem hiding this comment.
nit: could use a TODO or a NOTE on when to uncomment and who owns it
|
|
||
| logging.basicConfig(level=logging.INFO) | ||
|
|
||
| logger = logging.getLogger(__name__) | ||
|
|
||
|
|
||
| def main(): | ||
| @click.command() | ||
| @click.option("--create-prs", is_flag=True) |
alafanechere
temporarily deployed
to
more-secrets
GitHub Actions
Inactive
alafanechere
temporarily deployed
to
more-secrets
GitHub Actions
Inactive
alafanechere
temporarily deployed
to
more-secrets
GitHub Actions
Inactive
alafanechere
temporarily deployed
to
more-secrets
GitHub Actions
Inactive
alafanechere
temporarily deployed
to
more-secrets
GitHub Actions
Inactive
alafanechere
temporarily deployed
to
more-secrets
GitHub Actions
Inactive
marcosmarxm
pushed a commit
that referenced
this pull request
Feb 9, 2023
This was referenced Feb 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
@airbytehq/airbyte-analytics created a dedicated private bucket to store QA reports.
I want to make the QA engine write these reports to GCS in JSONL with generation in the file names.
It will be available on metabase here
How
persist_qa_reportfunction