Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm: update README.md #22666

Merged
merged 1 commit into from
Feb 9, 2023
Merged

Helm: update README.md #22666

merged 1 commit into from
Feb 9, 2023

Conversation

Utwo
Copy link
Contributor

@Utwo Utwo commented Feb 9, 2023

The default value for the webapp.ingress.enabled is false in values.yaml but true in readme.md. I changed the readme to reflect what's it the values.yaml

The default value for the webapp.ingress.enabled is false in value.yaml
Copy link
Contributor

@juweins juweins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Utwo ! Thank you for correcting this typo!

I quickly verified your hint:

line 270 in airbyte/charts/airbyte/values.yaml:

  ingress:
    enabled: false

LGTM! 👍🏼

@marcosmarxm marcosmarxm changed the title Update README.md Helm: update README.md Feb 9, 2023
Copy link
Member

@marcosmarxm marcosmarxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the catch @Utwo

@marcosmarxm marcosmarxm enabled auto-merge (squash) February 9, 2023 22:46
@marcosmarxm marcosmarxm merged commit 2f3c048 into airbytehq:master Feb 9, 2023
@Utwo Utwo deleted the patch-1 branch February 9, 2023 22:56
sh4sh pushed a commit that referenced this pull request Feb 10, 2023
The default value for the webapp.ingress.enabled is false in value.yaml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/platform issues related to the platform community kubernetes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants