-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Source Microsoft Dataverse: Fixed deduped not working correctly #22805
🐛 Source Microsoft Dataverse: Fixed deduped not working correctly #22805
Conversation
Due to delete only containing id, the deduped dbt could not work properly, so we also fill the cursor field with the current date so it does have a properly end
/publish connector=connectors/source-microsoft-dataverse run-tests=false
if you have connectors that successfully published but failed definition generation, follow step 4 here |
This is an alpha connector and we don't have credentials yet because of this publishing without testing. Waiting for https://github.com/airbytehq/airbyte-internal-issues/issues/2645 |
…rbytehq#22805) * Fixed dedupeot working correctly Due to delete only containing id, the deduped dbt could not work properly, so we also fill the cursor field with the current date so it does have a properly end * bump connector version * auto-bump connector version --------- Co-authored-by: marcosmarxm <marcosmarxm@gmail.com> Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com> Co-authored-by: Marcos Marx <marcosmarxm@users.noreply.github.com>
…2805) * Fixed dedupeot working correctly Due to delete only containing id, the deduped dbt could not work properly, so we also fill the cursor field with the current date so it does have a properly end * bump connector version * auto-bump connector version --------- Co-authored-by: marcosmarxm <marcosmarxm@gmail.com> Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com> Co-authored-by: Marcos Marx <marcosmarxm@users.noreply.github.com>
…2805) * Fixed dedupeot working correctly Due to delete only containing id, the deduped dbt could not work properly, so we also fill the cursor field with the current date so it does have a properly end * bump connector version * auto-bump connector version --------- Co-authored-by: marcosmarxm <marcosmarxm@gmail.com> Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com> Co-authored-by: Marcos Marx <marcosmarxm@users.noreply.github.com>
What
Due to delete only containing id, the deduped dbt could not work properly, because to check the start and end dates, deduped needs the cursor field to also be filled
How
Fill the cursor field with the current date so it does have a properly end
Recommended reading order
x.java
y.python
🚨 User Impact 🚨
Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.
Pre-merge Checklist
Expand the relevant checklist and delete the others.
New Connector
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampledocs/integrations/README.md
airbyte-integrations/builds.md
Airbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing/publish
command described hereUpdating a connector
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampleAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing/publish
command described hereConnector Generator
-scaffold
in their name) have been updated with the latest scaffold by running./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates
then checking in your changes