🎉 Source Snapchat Marketing - enable default availability strategy #22808

midavadim · 2023-02-10T13:09:40Z

What

Describe what the change is solving
It helps to add screenshots if it affects the frontend.

How

Describe the solution

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub by running the /publish command described here
After the connector is published, connector added to connector index as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

Connector Generator

Issue acceptance criteria met
PR name follows PR naming conventions
If adding a new generator, add it to the list of scaffold modules being tested
The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
Documentation which references the generator is updated as needed

CLAassistant · 2023-02-10T13:09:45Z

All committers have signed the CLA.

midavadim · 2023-02-10T13:12:17Z

/test connector=connectors/source-snapchat-marketing

🕑 connectors/source-snapchat-marketing https://github.com/airbytehq/airbyte/actions/runs/4144212483
❌ connectors/source-snapchat-marketing https://github.com/airbytehq/airbyte/actions/runs/4144212483
🐛 https://gradle.com/s/h2acyuq5vxcda

Build Failed

Test summary info:

Could not find result summary

midavadim · 2023-02-10T13:21:29Z

/test connector=connectors/source-snapchat-marketing

🕑 connectors/source-snapchat-marketing https://github.com/airbytehq/airbyte/actions/runs/4144283255
❌ connectors/source-snapchat-marketing https://github.com/airbytehq/airbyte/actions/runs/4144283255
🐛

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:98: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:507: The previous and actual discovered catalogs are identical.
================== 40 passed, 2 skipped in 353.91s (0:05:53) ===================

…ility-strategy

midavadim · 2023-02-11T10:50:18Z

/test connector=connectors/source-snapchat-marketing

🕑 connectors/source-snapchat-marketing https://github.com/airbytehq/airbyte/actions/runs/4151001824
✅ connectors/source-snapchat-marketing https://github.com/airbytehq/airbyte/actions/runs/4151001824
Python tests coverage:

Name                                    Stmts   Miss  Cover
-----------------------------------------------------------
source_snapchat_marketing/__init__.py       2      0   100%
source_snapchat_marketing/source.py       284     22    92%
-----------------------------------------------------------
TOTAL                                     286     22    92%
	 Name                                                    Stmts   Miss  Cover   Missing
	 -------------------------------------------------------------------------------------
	 connector_acceptance_test/base.py                          12      4    67%   16-19
	 connector_acceptance_test/config.py                       141      5    96%   87, 93, 239, 243-244
	 connector_acceptance_test/conftest.py                     217    101    53%   37, 43-45, 50, 55, 78, 84, 90-92, 111, 116-118, 124-126, 132-133, 138-139, 144, 150, 159-168, 174-179, 194, 218, 249, 255, 263-271, 279-292, 300-313, 318-324, 331-342, 349-365
	 connector_acceptance_test/plugin.py                        69     25    64%   22-23, 31, 36, 120-140, 144-148
	 connector_acceptance_test/tests/test_core.py              476    117    75%   53, 58, 97-108, 113-120, 124-125, 129-130, 380, 400, 438, 476-493, 506-517, 521-526, 532, 565-570, 608-615, 658-660, 663, 728-736, 748-751, 756, 812-813, 819, 822, 858-868, 881-906
	 connector_acceptance_test/tests/test_incremental.py       162     14    91%   58-65, 70-83, 252
	 connector_acceptance_test/utils/asserts.py                 39      2    95%   62-63
	 connector_acceptance_test/utils/common.py                  94     10    89%   16-17, 32-38, 72, 75
	 connector_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 connector_acceptance_test/utils/connector_runner.py       133     33    75%   24-27, 46-47, 50-54, 57-58, 73-75, 78-80, 83-85, 88-90, 93-95, 124-125, 159-161, 208
	 connector_acceptance_test/utils/json_schema_helper.py     114     13    89%   31-32, 39, 42, 66-69, 97, 121, 203-205
	 -------------------------------------------------------------------------------------
	 TOTAL                                                    1711    347    80%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:98: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:507: The previous and actual discovered catalogs are identical.
================== 40 passed, 2 skipped in 360.45s (0:06:00) ===================

erohmensing

Looks good - I added a commit removing custom error handling that shouldn't be necessary anymore.

In future PRs, if you could check against this doc for anything to remove when implementing availabilitystrategy, that'd be great! I also added a note to the issue for each one that has an entry in that list.

…ility-strategy

github-actions · 2023-02-15T19:45:35Z

Airbyte Code Coverage

There is no coverage information present for the Files changed

Total Project Coverage	24.66%	❌

…ility-strategy

…ng-availability-strategy' into midavadim/21787-snapchat-marketing-availability-strategy

midavadim · 2023-02-20T16:22:28Z

airbyte-integrations/connectors/source-snapchat-marketing/source_snapchat_marketing/source.py

@@ -219,13 +214,6 @@ def parse_response(self, response: requests.Response, **kwargs) -> Iterable[Mapp
                raise SnapchatMarketingException(error_text)
            yield resp.get(self.response_item_name)

-    def should_retry(self, response: requests.Response) -> bool:


I investigated the reasons for this custom error handling. There was a stream which was failing for one specifc slice, becuase of permissions error. that's why it handles 403 error. So in order to not fail the whole sync, we just skip one particular slice.

Do you know why it was failing for one specific slice? That would indeed not be covered by the availability strategy, but I'm curious as to why it happened

@erohmensing

related PR: #20865
related issue: https://github.com/airbytehq/oncall/issues/1067

The problem happened with 'segments' stream for one of 'adaccount' in its slice.

As far as I understand snapchat credentials could have access to a couple of snapchat organization/adaccounts and for one of such accounts there was no permission access to 'segments' data.

Will leave this up to you as per my comment in the PR itself!

midavadim · 2023-02-20T16:26:25Z

@erohmensing
I have added a comment about removed 'should_retry'

…ility-strategy

erohmensing · 2023-02-22T14:57:34Z

@midavadim thanks, responded! Do you know why that was the case? If its legit, I am fine leaving the error handling for now, but I wouldn't expect to run into that for one stream slice so am wondering how the case occurred

…ility-strategy

midavadim · 2023-02-23T13:04:57Z

@midavadim thanks, responded! Do you know why that was the case? If its legit, I am fine leaving the error handling for now, but I wouldn't expect to run into that for one stream slice so am wondering how the case occurred

@erohmensing

related PR: #20865
related issue: https://github.com/airbytehq/oncall/issues/1067

The problem happened with 'segments' stream for one of 'adaccount' in its slice.

As far as I understand snapchat credentials could have access to a couple of snapchat organization/adaccounts and for one of such accounts there was no permission access to 'segments' data.

erohmensing · 2023-02-23T14:49:40Z

Looking at that issue and the logs for the broken connection, I don't see any indication why it would only be breaking for that one slice, just that that slice was the first one in the list. (I don't see any indication for example that they had access to the segments stream for another adaccount for example)

Since this is extra error handling, it doesn't hurt us to have it in, but I don't believe it's doing anything. If you feel strongly about it, we can leave it in for now and try removing it later on its own after comparing log messages to see if both cases still happen independently of each other.

erohmensing · 2023-02-23T14:50:25Z

airbyte-integrations/connectors/source-snapchat-marketing/source_snapchat_marketing/source.py

@@ -219,13 +214,6 @@ def parse_response(self, response: requests.Response, **kwargs) -> Iterable[Mapp
                raise SnapchatMarketingException(error_text)
            yield resp.get(self.response_item_name)

-    def should_retry(self, response: requests.Response) -> bool:


Will leave this up to you as per my comment in the PR itself!

…ng-availability-strategy' into midavadim/21787-snapchat-marketing-availability-strategy

…ility-strategy

midavadim · 2023-02-23T21:31:15Z

/publish connector=connectors/source-snapchat-marketing

🕑 Publishing the following connectors:
connectors/source-snapchat-marketing
https://github.com/airbytehq/airbyte/actions/runs/4257023387

Connector	Did it publish?	Were definitions generated?
connectors/source-snapchat-marketing	✅	✅

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

Enable default availability trategy

9437a85

midavadim requested a review from lazebnyi February 10, 2023 13:09

octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/snapchat-marketing labels Feb 10, 2023

lazebnyi requested a review from erohmensing February 10, 2023 13:10

lazebnyi approved these changes Feb 10, 2023

View reviewed changes

added PR number

a560200

midavadim requested review from pedroslopez and removed request for erohmensing February 10, 2023 13:21

Merge branch 'master' into midavadim/21787-snapchat-marketing-availab…

0f9f8b8

…ility-strategy

lazebnyi requested a review from erohmensing February 13, 2023 17:50

remove custom error handling

13c2a9a

erohmensing approved these changes Feb 13, 2023

View reviewed changes

lazebnyi linked an issue Feb 14, 2023 that may be closed by this pull request

Source Snapchat Marketing: Enable AvailabilityStrategy #21787

Closed

Merge branch 'master' into midavadim/21787-snapchat-marketing-availab…

b7c3045

…ility-strategy

lazebnyi removed the request for review from pedroslopez February 15, 2023 19:22

lazebnyi added 2 commits February 15, 2023 20:34

Add allowedHosts

ff992ac

Merge master to branch

73a62f7

lazebnyi temporarily deployed to more-secrets February 15, 2023 19:38 — with GitHub Actions Inactive

Merge branch 'master' into midavadim/21787-snapchat-marketing-availab…

02d585e

…ility-strategy

lazebnyi temporarily deployed to more-secrets February 15, 2023 20:22 — with GitHub Actions Inactive

lazebnyi temporarily deployed to more-secrets February 15, 2023 21:13 — with GitHub Actions Inactive

Merge branch 'master' into midavadim/21787-snapchat-marketing-availab…

9db1eae

…ility-strategy

lazebnyi temporarily deployed to more-secrets February 16, 2023 11:34 — with GitHub Actions Inactive

midavadim added 2 commits February 20, 2023 15:03

Merge branch 'master' into midavadim/21787-snapchat-marketing-availab…

9d3dfe0

…ility-strategy

Merge remote-tracking branch 'origin/midavadim/21787-snapchat-marketi…

64e1fa0

…ng-availability-strategy' into midavadim/21787-snapchat-marketing-availability-strategy

midavadim commented Feb 20, 2023

View reviewed changes

midavadim requested a review from erohmensing February 20, 2023 16:22

Merge branch 'master' into midavadim/21787-snapchat-marketing-availab…

31ab477

…ility-strategy

Merge branch 'master' into midavadim/21787-snapchat-marketing-availab…

82c2f11

…ility-strategy

erohmensing approved these changes Feb 23, 2023

View reviewed changes

midavadim added 5 commits February 23, 2023 22:34

reverted customized should_retry

92963f8

Merge remote-tracking branch 'origin/midavadim/21787-snapchat-marketi…

e3ce8b4

…ng-availability-strategy' into midavadim/21787-snapchat-marketing-availability-strategy

Merge branch 'master' into midavadim/21787-snapchat-marketing-availab…

9eeda6a

…ility-strategy

updated version in source_definitions.yaml

22e35ff

Merge branch 'master' into midavadim/21787-snapchat-marketing-availab…

5f08d2c

…ility-strategy

auto-bump connector version

f6f1431

midavadim merged commit 2a90591 into master Feb 24, 2023

midavadim deleted the midavadim/21787-snapchat-marketing-availability-strategy branch February 24, 2023 07:37

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🎉 Source Snapchat Marketing - enable default availability strategy #22808

🎉 Source Snapchat Marketing - enable default availability strategy #22808

midavadim commented Feb 10, 2023

CLAassistant commented Feb 10, 2023 •

edited

Loading

midavadim commented Feb 10, 2023 •

edited by github-actions bot

Loading

midavadim commented Feb 10, 2023 •

edited by github-actions bot

Loading

midavadim commented Feb 11, 2023 •

edited by github-actions bot

Loading

erohmensing left a comment

github-actions bot commented Feb 15, 2023

midavadim Feb 20, 2023

erohmensing Feb 21, 2023

midavadim Feb 23, 2023

erohmensing Feb 23, 2023

midavadim commented Feb 20, 2023

erohmensing commented Feb 22, 2023

midavadim commented Feb 23, 2023

erohmensing commented Feb 23, 2023

erohmensing Feb 23, 2023

midavadim commented Feb 23, 2023 •

edited by github-actions bot

Loading

🎉 Source Snapchat Marketing - enable default availability strategy #22808

🎉 Source Snapchat Marketing - enable default availability strategy #22808

Conversation

midavadim commented Feb 10, 2023

What

How

Recommended reading order

🚨 User Impact 🚨

Pre-merge Checklist

Community member or Airbyter

Airbyter

Community member or Airbyter

Airbyter

CLAassistant commented Feb 10, 2023 • edited Loading

midavadim commented Feb 10, 2023 • edited by github-actions bot Loading

Build Failed

midavadim commented Feb 10, 2023 • edited by github-actions bot Loading

Build Passed

midavadim commented Feb 11, 2023 • edited by github-actions bot Loading

Build Passed

erohmensing left a comment

Choose a reason for hiding this comment

github-actions bot commented Feb 15, 2023

Airbyte Code Coverage

midavadim Feb 20, 2023

Choose a reason for hiding this comment

erohmensing Feb 21, 2023

Choose a reason for hiding this comment

midavadim Feb 23, 2023

Choose a reason for hiding this comment

erohmensing Feb 23, 2023

Choose a reason for hiding this comment

midavadim commented Feb 20, 2023

erohmensing commented Feb 22, 2023

midavadim commented Feb 23, 2023

erohmensing commented Feb 23, 2023

erohmensing Feb 23, 2023

Choose a reason for hiding this comment

midavadim commented Feb 23, 2023 • edited by github-actions bot Loading

CLAassistant commented Feb 10, 2023 •

edited

Loading

midavadim commented Feb 10, 2023 •

edited by github-actions bot

Loading

midavadim commented Feb 10, 2023 •

edited by github-actions bot

Loading

midavadim commented Feb 11, 2023 •

edited by github-actions bot

Loading

midavadim commented Feb 23, 2023 •

edited by github-actions bot

Loading