Source Snapchat Marketing: Mark datefields in spec as dates #22869

arsenlosenko · 2023-02-11T19:32:14Z

What

Resolving:
#22778

How

Describe the solution

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub by running the /publish command described here
After the connector is published, connector added to connector index as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

Connector Generator

Issue acceptance criteria met
PR name follows PR naming conventions
If adding a new generator, add it to the list of scaffold modules being tested
The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
Documentation which references the generator is updated as needed

arsenlosenko · 2023-02-11T19:32:27Z

/test connector=connectors/source-snapchat-marketing

🕑 connectors/source-snapchat-marketing https://github.com/airbytehq/airbyte/actions/runs/4152846334
✅ connectors/source-snapchat-marketing https://github.com/airbytehq/airbyte/actions/runs/4152846334
Python tests coverage:

Name                                    Stmts   Miss  Cover
-----------------------------------------------------------
source_snapchat_marketing/__init__.py       2      0   100%
source_snapchat_marketing/source.py       288     23    92%
-----------------------------------------------------------
TOTAL                                     290     23    92%
	 Name                                                    Stmts   Miss  Cover   Missing
	 -------------------------------------------------------------------------------------
	 connector_acceptance_test/base.py                          12      4    67%   16-19
	 connector_acceptance_test/config.py                       141      5    96%   87, 93, 239, 243-244
	 connector_acceptance_test/conftest.py                     217    101    53%   37, 43-45, 50, 55, 78, 84, 90-92, 111, 116-118, 124-126, 132-133, 138-139, 144, 150, 159-168, 174-179, 194, 218, 249, 255, 263-271, 279-292, 300-313, 318-324, 331-342, 349-365
	 connector_acceptance_test/plugin.py                        69     25    64%   22-23, 31, 36, 120-140, 144-148
	 connector_acceptance_test/tests/test_core.py              476    117    75%   53, 58, 97-108, 113-120, 124-125, 129-130, 380, 400, 438, 476-493, 506-517, 521-526, 532, 565-570, 608-615, 658-660, 663, 728-736, 748-751, 756, 812-813, 819, 822, 858-868, 881-906
	 connector_acceptance_test/tests/test_incremental.py       162     14    91%   58-65, 70-83, 252
	 connector_acceptance_test/utils/asserts.py                 39      2    95%   62-63
	 connector_acceptance_test/utils/common.py                  94     10    89%   16-17, 32-38, 72, 75
	 connector_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 connector_acceptance_test/utils/connector_runner.py       133     33    75%   24-27, 46-47, 50-54, 57-58, 73-75, 78-80, 83-85, 88-90, 93-95, 124-125, 159-161, 208
	 connector_acceptance_test/utils/json_schema_helper.py     114     13    89%   31-32, 39, 42, 66-69, 97, 121, 203-205
	 -------------------------------------------------------------------------------------
	 TOTAL                                                    1711    347    80%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:507: The previous and actual discovered catalogs are identical.
================== 41 passed, 1 skipped in 351.63s (0:05:51) ===================

…mat-date

arsenlosenko · 2023-02-23T08:58:41Z

/test connector=connectors/source-snapchat-marketing

🕑 connectors/source-snapchat-marketing https://github.com/airbytehq/airbyte/actions/runs/4250928961
✅ connectors/source-snapchat-marketing https://github.com/airbytehq/airbyte/actions/runs/4250928961
Python tests coverage:

Name                                    Stmts   Miss  Cover
-----------------------------------------------------------
source_snapchat_marketing/__init__.py       2      0   100%
source_snapchat_marketing/source.py       288     23    92%
-----------------------------------------------------------
TOTAL                                     290     23    92%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:507: The previous and actual discovered catalogs are identical.
================== 41 passed, 1 skipped in 333.71s (0:05:33) ===================

…mat-date

arsenlosenko · 2023-03-02T06:50:55Z

/test connector=connectors/source-snapchat-marketing

🕑 connectors/source-snapchat-marketing https://github.com/airbytehq/airbyte/actions/runs/4311361212
✅ connectors/source-snapchat-marketing https://github.com/airbytehq/airbyte/actions/runs/4311361212
Python tests coverage:

Name                                    Stmts   Miss  Cover
-----------------------------------------------------------
source_snapchat_marketing/__init__.py       2      0   100%
source_snapchat_marketing/source.py       284     22    92%
-----------------------------------------------------------
TOTAL                                     286     22    92%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:509: The previous and actual discovered catalogs are identical.
================== 41 passed, 1 skipped in 387.66s (0:06:27) ===================

arsenlosenko · 2023-03-02T08:19:41Z

/publish connector=connectors/source-snapchat-marketing

🕑 Publishing the following connectors:
connectors/source-snapchat-marketing
https://github.com/airbytehq/airbyte/actions/runs/4311940185

Connector	Did it publish?	Were definitions generated?
connectors/source-snapchat-marketing	✅	✅

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

* Source Snapchat Marketing: Mark datefields in spec as dates * Update changelog * Add allowedHosts * Update Dockerfile * auto-bump connector version --------- Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>

…q#22869) * Source Snapchat Marketing: Mark datefields in spec as dates * Update changelog * Add allowedHosts * Update Dockerfile * auto-bump connector version --------- Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>

Source Snapchat Marketing: Mark datefields in spec as dates

65e3fa9

arsenlosenko self-assigned this Feb 11, 2023

octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/snapchat-marketing labels Feb 11, 2023

Update changelog

8e3ecb1

arsenlosenko linked an issue Feb 13, 2023 that may be closed by this pull request

Source Snapchat Marketing: Mark datefields in properly as dates #22778

Closed

arsenlosenko requested a review from lazebnyi February 13, 2023 10:19

arsenlosenko marked this pull request as ready for review February 13, 2023 10:19

lazebnyi approved these changes Feb 13, 2023

View reviewed changes

arsenlosenko and others added 4 commits February 14, 2023 12:05

Merge branch 'master' into arsenlosenko/source-snapchat-marketing-for…

72fe7c8

…mat-date

Add allowedHosts

ee3d246

Merge branch 'master' into arsenlosenko/source-snapchat-marketing-for…

5244446

…mat-date

Merge branch 'master' into arsenlosenko/source-snapchat-marketing-for…

221c181

…mat-date

arsenlosenko and others added 3 commits February 23, 2023 19:45

Merge branch 'master' into arsenlosenko/source-snapchat-marketing-for…

60892a7

…mat-date

Merge branch 'master' into arsenlosenko/source-snapchat-marketing-for…

fa134f1

…mat-date

Update Dockerfile

0c9769b

auto-bump connector version

7abacbf

arsenlosenko merged commit b0bde01 into master Mar 2, 2023

arsenlosenko deleted the arsenlosenko/source-snapchat-marketing-format-date branch March 2, 2023 09:00

jbfbell mentioned this pull request Mar 15, 2023

Check With Catalog JDBC POC (feature flag default off) #24109

Closed

37 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Source Snapchat Marketing: Mark datefields in spec as dates #22869

Source Snapchat Marketing: Mark datefields in spec as dates #22869

arsenlosenko commented Feb 11, 2023

arsenlosenko commented Feb 11, 2023 •

edited by github-actions bot

Loading

arsenlosenko commented Feb 23, 2023 •

edited by github-actions bot

Loading

arsenlosenko commented Mar 2, 2023 •

edited by github-actions bot

Loading

arsenlosenko commented Mar 2, 2023 •

edited by github-actions bot

Loading

Source Snapchat Marketing: Mark datefields in spec as dates #22869

Source Snapchat Marketing: Mark datefields in spec as dates #22869

Conversation

arsenlosenko commented Feb 11, 2023

What

How

Recommended reading order

🚨 User Impact 🚨

Pre-merge Checklist

Community member or Airbyter

Airbyter

Community member or Airbyter

Airbyter

arsenlosenko commented Feb 11, 2023 • edited by github-actions bot Loading

Build Passed

arsenlosenko commented Feb 23, 2023 • edited by github-actions bot Loading

Build Passed

arsenlosenko commented Mar 2, 2023 • edited by github-actions bot Loading

Build Passed

arsenlosenko commented Mar 2, 2023 • edited by github-actions bot Loading

arsenlosenko commented Feb 11, 2023 •

edited by github-actions bot

Loading

arsenlosenko commented Feb 23, 2023 •

edited by github-actions bot

Loading

arsenlosenko commented Mar 2, 2023 •

edited by github-actions bot

Loading

arsenlosenko commented Mar 2, 2023 •

edited by github-actions bot

Loading