-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Source Salesforce: fix properties chunk length count #22896
Source Salesforce: fix properties chunk length count #22896
Conversation
/test connector=connectors/source-salesforce
Build PassedTest summary info:
|
/publish connector=connectors/source-salesforce
if you have connectors that successfully published but failed definition generation, follow step 4 here |
Airbyte Code Coverage
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI tests looks good. We can move next to fix issue related to on-call issue. LGTM!
/publish connector=connectors/source-salesforce |
2 similar comments
/publish connector=connectors/source-salesforce |
/publish connector=connectors/source-salesforce |
/publish connector=connectors/source-salesforce
if you have connectors that successfully published but failed definition generation, follow step 4 here |
/approve-and-merge reason="A followup for oncall #1403" |
What
#20703
this is a followup for oncall https://github.com/airbytehq/oncall/issues/1403
How
When counting the length of the URL we should take into account that properties and the separator will be URL-encoded