Source Google Search Console: Mark datefields in spec as dates #22984

arsenlosenko · 2023-02-14T11:00:20Z

What

Resolving:
#22733

How

Describe the solution

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub by running the /publish command described here
After the connector is published, connector added to connector index as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

Connector Generator

Issue acceptance criteria met
PR name follows PR naming conventions
If adding a new generator, add it to the list of scaffold modules being tested
The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
Documentation which references the generator is updated as needed

arsenlosenko · 2023-02-14T11:00:56Z

/test connector=connectors/source-google-search-console

🕑 connectors/source-google-search-console https://github.com/airbytehq/airbyte/actions/runs/4173095616
❌ connectors/source-google-search-console https://github.com/airbytehq/airbyte/actions/runs/4173095616
🐛 https://gradle.com/s/gfl4jnbsqbstu

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestBasicRead::test_read[inputs0] - AssertionError: Stre...
FAILED test_incremental.py::TestIncremental::test_two_sequential_reads[inputs0]
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:507: The previous and actual discovered catalogs are identical.
============= 2 failed, 35 passed, 1 skipped in 286.69s (0:04:46) ==============

…format-date

arsenlosenko · 2023-02-21T11:24:21Z

/test connector=connectors/source-google-search-console

🕑 connectors/source-google-search-console https://github.com/airbytehq/airbyte/actions/runs/4232142163
❌ connectors/source-google-search-console https://github.com/airbytehq/airbyte/actions/runs/4232142163
🐛 https://gradle.com/s/wvt54o5gkntsk

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestBasicRead::test_read[inputs0] - AssertionError: Stre...
FAILED test_incremental.py::TestIncremental::test_two_sequential_reads[inputs0]
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:507: The previous and actual discovered catalogs are identical.
============= 2 failed, 35 passed, 1 skipped in 345.06s (0:05:45) ==============

…format-date

arsenlosenko · 2023-03-03T14:05:59Z

/test connector=connectors/source-google-search-console

🕑 connectors/source-google-search-console https://github.com/airbytehq/airbyte/actions/runs/4324175972
❌ connectors/source-google-search-console https://github.com/airbytehq/airbyte/actions/runs/4324175972
🐛 https://gradle.com/s/cfqwbnheyiprm

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestBasicRead::test_read[inputs0] - AssertionError: Stre...
FAILED test_incremental.py::TestIncremental::test_two_sequential_reads[inputs0]
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:509: The previous and actual discovered catalogs are identical.
============= 2 failed, 35 passed, 1 skipped in 379.20s (0:06:19) ==============

…format-date

arsenlosenko · 2023-03-20T08:30:06Z

/test connector=connectors/source-google-search-console

🕑 connectors/source-google-search-console https://github.com/airbytehq/airbyte/actions/runs/4466164075
✅ connectors/source-google-search-console https://github.com/airbytehq/airbyte/actions/runs/4466164075
Python tests coverage:

Name                                                            Stmts   Miss  Cover
-----------------------------------------------------------------------------------
source_google_search_console/exceptions.py                          2      0   100%
source_google_search_console/__init__.py                            2      0   100%
source_google_search_console/streams.py                           138      8    94%
source_google_search_console/source.py                             90     10    89%
source_google_search_console/service_account_authenticator.py      14      6    57%
-----------------------------------------------------------------------------------
TOTAL                                                             246     24    90%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:509: The previous and actual discovered catalogs are identical.
================== 37 passed, 1 skipped in 502.45s (0:08:22) ===================

arsenlosenko · 2023-03-20T13:06:50Z

/publish connector=connectors/source-google-search-console

🕑 Publishing the following connectors:
connectors/source-google-search-console
https://github.com/airbytehq/airbyte/actions/runs/4468531568

Connector	Did it publish?	Were definitions generated?
connectors/source-google-search-console	✅	✅

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

* Source Google Search Console: Mark datefields in spec as dates * Update changelog * auto-bump connector version --------- Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>

Source Google Search Console: Mark datefields in spec as dates

5dc6df1

arsenlosenko self-assigned this Feb 14, 2023

octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/google-search-console labels Feb 14, 2023

arsenlosenko and others added 2 commits February 14, 2023 13:06

Update changelog

677781a

Merge branch 'master' into arsenlosenko/source-google-search-console-…

97e1e86

…format-date

Merge branch 'master' into arsenlosenko/source-google-search-console-…

a0c8777

…format-date

Merge branch 'master' into arsenlosenko/source-google-search-console-…

e4ebde6

…format-date

arsenlosenko marked this pull request as ready for review March 20, 2023 08:49

arsenlosenko requested a review from lazebnyi March 20, 2023 08:49

lazebnyi approved these changes Mar 20, 2023

View reviewed changes

auto-bump connector version

4f85932

arsenlosenko merged commit 550fe10 into master Mar 20, 2023

arsenlosenko deleted the arsenlosenko/source-google-search-console-format-date branch March 20, 2023 14:20

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Source Google Search Console: Mark datefields in spec as dates #22984

Source Google Search Console: Mark datefields in spec as dates #22984

arsenlosenko commented Feb 14, 2023

arsenlosenko commented Feb 14, 2023 •

edited by github-actions bot

Loading

arsenlosenko commented Feb 21, 2023 •

edited by github-actions bot

Loading

arsenlosenko commented Mar 3, 2023 •

edited by github-actions bot

Loading

arsenlosenko commented Mar 20, 2023 •

edited by github-actions bot

Loading

arsenlosenko commented Mar 20, 2023 •

edited by github-actions bot

Loading

Source Google Search Console: Mark datefields in spec as dates #22984

Source Google Search Console: Mark datefields in spec as dates #22984

Conversation

arsenlosenko commented Feb 14, 2023

What

How

Recommended reading order

🚨 User Impact 🚨

Pre-merge Checklist

Community member or Airbyter

Airbyter

Community member or Airbyter

Airbyter

arsenlosenko commented Feb 14, 2023 • edited by github-actions bot Loading

Build Failed

arsenlosenko commented Feb 21, 2023 • edited by github-actions bot Loading

Build Failed

arsenlosenko commented Mar 3, 2023 • edited by github-actions bot Loading

Build Failed

arsenlosenko commented Mar 20, 2023 • edited by github-actions bot Loading

Build Passed

arsenlosenko commented Mar 20, 2023 • edited by github-actions bot Loading

arsenlosenko commented Feb 14, 2023 •

edited by github-actions bot

Loading

arsenlosenko commented Feb 21, 2023 •

edited by github-actions bot

Loading

arsenlosenko commented Mar 3, 2023 •

edited by github-actions bot

Loading

arsenlosenko commented Mar 20, 2023 •

edited by github-actions bot

Loading

arsenlosenko commented Mar 20, 2023 •

edited by github-actions bot

Loading