Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SAT ignored fields key for basic read #22996

Merged
merged 13 commits into from
Feb 28, 2023

Conversation

roman-yermilov-gl
Copy link
Contributor

@roman-yermilov-gl roman-yermilov-gl commented Feb 14, 2023

What

Add ignored_fields section for basic read

How

  • added new section to config
  • added bypass reason for empty fields
  • handled ignored fields in basic read and full refresh tests
  • updated unittests and added new ones
  • made configs backward compatible

@github-actions
Copy link
Contributor

github-actions bot commented Feb 14, 2023

Affected Connector Report

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to do the following as needed:

  • Run integration tests
  • Bump connector or module version
  • Add changelog
  • Publish the new version

✅ Sources (1)

Connector Version Changelog Publish
source-railz 0.1.1
  • See "Actionable Items" below for how to resolve warnings and errors.

✅ Destinations (0)

Connector Version Changelog Publish
  • See "Actionable Items" below for how to resolve warnings and errors.

✅ Other Modules (0)

Actionable Items

(click to expand)

Category Status Actionable Item
Version
mismatch
The version of the connector is different from its normal variant. Please bump the version of the connector.

doc not found
The connector does not seem to have a documentation file. This can be normal (e.g. basic connector like source-jdbc is not published or documented). Please double-check to make sure that it is not a bug.
Changelog
doc not found
The connector does not seem to have a documentation file. This can be normal (e.g. basic connector like source-jdbc is not published or documented). Please double-check to make sure that it is not a bug.

changelog missing
There is no chnagelog for the current version of the connector. If you are the author of the current version, please add a changelog.
Publish
not in seed
The connector is not in the seed file (e.g. source_definitions.yaml), so its publication status cannot be checked. This can be normal (e.g. some connectors are cloud-specific, and only listed in the cloud seed file). Please double-check to make sure that it is not a bug.

diff seed version
The connector exists in the seed file, but the latest version is not listed there. This usually means that the latest version is not published. Please use the /publish command to publish the latest version.

@roman-yermilov-gl
Copy link
Contributor Author

roman-yermilov-gl commented Feb 14, 2023

/test connector=bases/connector-acceptance-test

🕑 bases/connector-acceptance-test https://github.com/airbytehq/airbyte/actions/runs/4176824358
✅ bases/connector-acceptance-test https://github.com/airbytehq/airbyte/actions/runs/4176824358
No Python unittests run

Build Passed

Test summary info:

All Passed

Copy link
Contributor

@erohmensing erohmensing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to see this in action in Stripe! Updated the changelog, should be ready for publishing

Co-authored-by: Ella Rohm-Ensing <erohmensing@gmail.com>
@roman-yermilov-gl
Copy link
Contributor Author

roman-yermilov-gl commented Feb 28, 2023

/publish connector=bases/connector-acceptance-test auto-bump-version=false

🕑 Publishing the following connectors:
bases/connector-acceptance-test
https://github.com/airbytehq/airbyte/actions/runs/4292761601


Connector Did it publish? Were definitions generated?

@roman-yermilov-gl
Copy link
Contributor Author

Publish was successful except updating publish comment in PR: Error: API rate limit exceeded for installation ID 6913263.

@roman-yermilov-gl roman-yermilov-gl merged commit ea776ef into master Feb 28, 2023
@roman-yermilov-gl roman-yermilov-gl deleted the ryermilov/sat_ignored_fields_for_basic_read branch February 28, 2023 14:12
danielduckworth pushed a commit to danielduckworth/airbyte that referenced this pull request Mar 13, 2023
* [SAT] add ignored fields for basic read

* [SAT] ignored_fields validation fixture

* [SAT] set ignored_fields default value

* Update airbyte-integrations/bases/connector-acceptance-test/CHANGELOG.md

Co-authored-by: Ella Rohm-Ensing <erohmensing@gmail.com>

* Automated Change

* [SAT] fixture tests and some small fixes

* Update airbyte-integrations/bases/connector-acceptance-test/CHANGELOG.md

Co-authored-by: Ella Rohm-Ensing <erohmensing@gmail.com>

* Automated Change

---------

Co-authored-by: Ella Rohm-Ensing <erohmensing@gmail.com>
Co-authored-by: roman-yermilov-gl <roman-yermilov-gl@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SAT] ignored_fields key for basic read test
6 participants