Source Amplitude: Mark datefields in spec as dates #23087

arsenlosenko · 2023-02-15T16:09:54Z

What

Resolving:
#22706

How

Describe the solution

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub by running the /publish command described here
After the connector is published, connector added to connector index as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

Connector Generator

Issue acceptance criteria met
PR name follows PR naming conventions
If adding a new generator, add it to the list of scaffold modules being tested
The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
Documentation which references the generator is updated as needed

arsenlosenko · 2023-02-15T16:10:08Z

/test connector=connectors/source-amplitude

🕑 connectors/source-amplitude https://github.com/airbytehq/airbyte/actions/runs/4185834793
✅ connectors/source-amplitude https://github.com/airbytehq/airbyte/actions/runs/4185834793
Python tests coverage:

Name                           Stmts   Miss  Cover
--------------------------------------------------
source_amplitude/__init__.py       2      0   100%
source_amplitude/source.py        39      2    95%
source_amplitude/errors.py        12      1    92%
source_amplitude/api.py          186     23    88%
--------------------------------------------------
TOTAL                            239     26    89%
	 Name                                                    Stmts   Miss  Cover   Missing
	 -------------------------------------------------------------------------------------
	 connector_acceptance_test/base.py                          12      4    67%   16-19
	 connector_acceptance_test/config.py                       142      5    96%   87, 93, 242, 246-247
	 connector_acceptance_test/conftest.py                     220    102    54%   37, 43-45, 50, 55, 60, 83, 89, 95-97, 116, 121-123, 129-131, 137-138, 143-144, 149, 160, 169-178, 184-189, 204, 228, 259, 265, 273-281, 289-302, 310-323, 328-334, 341-352, 359-375
	 connector_acceptance_test/plugin.py                        69     25    64%   22-23, 31, 36, 120-140, 144-148
	 connector_acceptance_test/tests/test_core.py              476    117    75%   53, 58, 97-108, 113-120, 124-125, 129-130, 380, 400, 438, 476-493, 506-517, 521-526, 532, 565-570, 608-615, 658-660, 663, 728-736, 748-751, 756, 812-813, 819, 822, 858-868, 881-906
	 connector_acceptance_test/tests/test_incremental.py       162     14    91%   58-65, 70-83, 252
	 connector_acceptance_test/utils/asserts.py                 39      2    95%   62-63
	 connector_acceptance_test/utils/common.py                  94     10    89%   16-17, 32-38, 72, 75
	 connector_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 connector_acceptance_test/utils/connector_runner.py       134     33    75%   30-33, 53-54, 57-61, 64-65, 80-82, 85-87, 90-92, 95-97, 100-102, 132-133, 167-169, 216
	 connector_acceptance_test/utils/json_schema_helper.py     114     13    89%   31-32, 39, 42, 66-69, 97, 121, 203-205
	 -------------------------------------------------------------------------------------
	 TOTAL                                                    1716    348    80%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:507: The previous and actual discovered catalogs are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_incremental.py:30: `future_state` not specified, skipping.
================= 35 passed, 2 skipped, 37 warnings in 47.74s ==================

lazebnyi

LGTM. But let's wait when high strictness will be enabled in other PR.

arsenlosenko · 2023-03-02T06:28:14Z

/test connector=connectors/source-amplitude

🕑 connectors/source-amplitude https://github.com/airbytehq/airbyte/actions/runs/4311230231
✅ connectors/source-amplitude https://github.com/airbytehq/airbyte/actions/runs/4311230231
Python tests coverage:

Name                           Stmts   Miss  Cover
--------------------------------------------------
source_amplitude/__init__.py       2      0   100%
source_amplitude/source.py        39      2    95%
source_amplitude/errors.py        12      1    92%
source_amplitude/api.py          197     26    87%
--------------------------------------------------
TOTAL                            250     29    88%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:509: The previous and actual discovered catalogs are identical.
================== 36 passed, 1 skipped in 292.41s (0:04:52) ===================

arsenlosenko · 2023-03-02T09:52:11Z

/publish connector=connectors/source-amplitude

🕑 Publishing the following connectors:
connectors/source-amplitude
https://github.com/airbytehq/airbyte/actions/runs/4312691710

Connector	Did it publish?	Were definitions generated?
connectors/source-amplitude	✅	✅

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

* Source Amplitude: Mark datefields in spec as dates * Update changelog * Add allowedHosts * Update Dockerfile * auto-bump connector version --------- Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>

Source Amplitude: Mark datefields in spec as dates

808e85f

arsenlosenko self-assigned this Feb 15, 2023

octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/amplitude labels Feb 15, 2023

Update changelog

f1058d7

arsenlosenko marked this pull request as ready for review February 15, 2023 16:24

arsenlosenko requested a review from lazebnyi February 15, 2023 16:24

lazebnyi reviewed Feb 17, 2023

View reviewed changes

arsenlosenko and others added 4 commits February 20, 2023 16:51

Merge branch 'master' into arsenlosenko/source-amplitude-format-date

48f4455

Add allowedHosts

6e694ff

Merge branch 'master' into arsenlosenko/source-amplitude-format-date

491c9b0

Update Dockerfile

9f81f04

lazebnyi approved these changes Mar 2, 2023

View reviewed changes

auto-bump connector version

258fa7e

arsenlosenko merged commit 93d2d86 into master Mar 2, 2023

arsenlosenko deleted the arsenlosenko/source-amplitude-format-date branch March 2, 2023 10:34

jbfbell mentioned this pull request Mar 15, 2023

Check With Catalog JDBC POC (feature flag default off) #24109

Closed

37 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Source Amplitude: Mark datefields in spec as dates #23087

Source Amplitude: Mark datefields in spec as dates #23087

arsenlosenko commented Feb 15, 2023

arsenlosenko commented Feb 15, 2023 •

edited by github-actions bot

Loading

lazebnyi left a comment

arsenlosenko commented Mar 2, 2023 •

edited by github-actions bot

Loading

arsenlosenko commented Mar 2, 2023 •

edited by github-actions bot

Loading

Source Amplitude: Mark datefields in spec as dates #23087

Source Amplitude: Mark datefields in spec as dates #23087

Conversation

arsenlosenko commented Feb 15, 2023

What

How

Recommended reading order

🚨 User Impact 🚨

Pre-merge Checklist

Community member or Airbyter

Airbyter

Community member or Airbyter

Airbyter

arsenlosenko commented Feb 15, 2023 • edited by github-actions bot Loading

Build Passed

lazebnyi left a comment

Choose a reason for hiding this comment

arsenlosenko commented Mar 2, 2023 • edited by github-actions bot Loading

Build Passed

arsenlosenko commented Mar 2, 2023 • edited by github-actions bot Loading

arsenlosenko commented Feb 15, 2023 •

edited by github-actions bot

Loading

arsenlosenko commented Mar 2, 2023 •

edited by github-actions bot

Loading

arsenlosenko commented Mar 2, 2023 •

edited by github-actions bot

Loading