-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Source Salesforce: include primary key in every chunk #23190
Source Salesforce: include primary key in every chunk #23190
Conversation
/test connector=connectors/source-salesforce
Build PassedTest summary info:
|
airbyte-integrations/connectors/source-salesforce/source_salesforce/streams.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
…pk-in-properties-chunks
…pk-in-properties-chunks
/publish connector=connectors/source-salesforce if you have connectors that successfully published but failed definition generation, follow step 4 here |
/publish connector=connectors/source-salesforce
if you have connectors that successfully published but failed definition generation, follow step 4 here |
…pk-in-properties-chunks
…pk-in-properties-chunks
…pk-in-properties-chunks
…pk-in-properties-chunks
…pk-in-properties-chunks
…pk-in-properties-chunks
…pk-in-properties-chunks
…ies-chunks' of github.com:airbytehq/airbyte into ddavydov/#20703-source-salesforce-include-pk-in-properties-chunks
What
#20703
this is a followup for the on-call issue https://github.com/airbytehq/oncall/issues/1403
How
If the properties are chunked - we need to include the primary key in every chunk, otherwise we won't be able to stick response chunks