Source SmartSheets: fix oauth2 implementation

[artem1205]

What

Resolving https://github.com/airbytehq/oncall/issues/1127

How

Fix refresh token by using SingleUseRefreshTokenOauth2Authenticator

Recommended reading order

1. x.java
2. y.python

🚨 User Impact 🚨

reauthenticate will be needed for all users

Pre-merge Checklist

Expand the relevant checklist and delete the others.

Updating a connector

Community member or Airbyter

• Grant edit access to maintainers (instructions)
• Secrets in the connector's spec are annotated with airbyte_secret
• Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
• Code reviews completed
• Documentation updated
  • Connector's README.md
  • Connector's bootstrap.md. See description and examples
  • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
• PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

• Create a non-forked branch based on this PR and test the below items on it
• Build is successful
• If new credentials are required for use in CI, add them to GSM. Instructions.
• /test connector=connectors/<name> command is passing
• New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

[artem1205]

/test connector=connectors/source-smartsheets

🕑 connectors/source-smartsheets https://github.com/airbytehq/airbyte/actions/runs/4212412015
❌ connectors/source-smartsheets https://github.com/airbytehq/airbyte/actions/runs/4212412015
🐛 https://gradle.com/s/znziqduq5wals

Build Failed

Test summary info:

=========================== short test summary info ============================
ERROR test_core.py::TestDiscovery::test_backward_compatibility[inputs0] - doc...
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:107: Backward compatibility tests are disabled for version 0.1.14.
============= 36 passed, 1 skipped, 37 warnings, 1 error in 19.55s =============

[artem1205]

/test connector=connectors/source-smartsheets

🕑 connectors/source-smartsheets https://github.com/airbytehq/airbyte/actions/runs/4212691224
✅ connectors/source-smartsheets https://github.com/airbytehq/airbyte/actions/runs/4212691224
Python tests coverage:

Name                             Stmts   Miss  Cover
----------------------------------------------------
source_smartsheets/source.py        13      0   100%
source_smartsheets/__init__.py       2      0   100%
source_smartsheets/sheet.py         79      4    95%
source_smartsheets/streams.py       37      4    89%
----------------------------------------------------
TOTAL                              131      8    94%
	 Name                                                    Stmts   Miss  Cover   Missing
	 -------------------------------------------------------------------------------------
	 connector_acceptance_test/base.py                          12      4    67%   16-19
	 connector_acceptance_test/config.py                       142      5    96%   87, 93, 242, 246-247
	 connector_acceptance_test/conftest.py                     220    102    54%   37, 43-45, 50, 55, 60, 83, 89, 95-97, 116, 121-123, 129-131, 137-138, 143-144, 149, 160, 169-178, 184-189, 204, 228, 259, 265, 273-281, 289-302, 310-323, 328-334, 341-352, 359-375
	 connector_acceptance_test/plugin.py                        69     25    64%   22-23, 31, 36, 120-140, 144-148
	 connector_acceptance_test/tests/test_core.py              476    117    75%   53, 58, 97-108, 113-120, 124-125, 129-130, 380, 400, 438, 476-493, 506-517, 521-526, 532, 565-570, 608-615, 658-660, 663, 728-736, 748-751, 756, 812-813, 819, 822, 858-868, 881-906
	 connector_acceptance_test/tests/test_incremental.py       162     14    91%   58-65, 70-83, 252
	 connector_acceptance_test/utils/asserts.py                 39      2    95%   62-63
	 connector_acceptance_test/utils/common.py                  94     10    89%   16-17, 32-38, 72, 75
	 connector_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 connector_acceptance_test/utils/connector_runner.py       134     33    75%   30-33, 53-54, 57-61, 64-65, 80-82, 85-87, 90-92, 95-97, 100-102, 132-133, 167-169, 216
	 connector_acceptance_test/utils/json_schema_helper.py     114     13    89%   31-32, 39, 42, 66-69, 97, 121, 203-205
	 -------------------------------------------------------------------------------------
	 TOTAL                                                    1716    348    80%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:107: Backward compatibility tests are disabled for version 0.1.14.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:507: The previous and actual discovered catalogs are identical.
================= 36 passed, 2 skipped, 37 warnings in 25.41s ==================

[artem1205]

@pedroslopez , unfortunately not, as we need extra data for reauthentication, that we don't have now in our DB.

[github-actions]

Connectors Base Test Results

288 tests  ±0   286 ✔️ ±0   1m 25s ⏱️ ±0s
  69 suites ±0       2 💤 ±0 
  69 files   ±0       0 ❌ ±0 

Results for commit 87bbd00. ± Comparison against base commit bdf493f.

♻️ This comment has been updated with latest results.

[evantahler]

👍 and noting the breaking change

[pedroslopez]

Code looks good, though did not functionally test this. Requested changes are for naming and an incorrect link.

[artem1205]

/publish connector=connectors/source-smartsheets

🕑 Publishing the following connectors:
connectors/source-smartsheets
https://github.com/airbytehq/airbyte/actions/runs/4323872411

Connector	Did it publish?	Were definitions generated?
connectors/source-smartsheets	✅	✅

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️