Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated links in docs from .io to .com #23408

Closed
wants to merge 1 commit into from
Closed

Conversation

sophia-wiley
Copy link
Contributor

@sophia-wiley sophia-wiley commented Feb 23, 2023

Replaced cloud.airbyte.io with cloud.airbyte.com, docs.airbyte.io with docs.airbyte.com, and https://airbyte.io with https://airbyte.com. I left https://internal-docs.airbyte.io as is because there is not a redirect for it yet.

I didn't change the https://airbyte.io links in the expected_records.jsonl files because I wasn't sure what that would do.

@sophia-wiley sophia-wiley requested review from a team as code owners February 23, 2023 20:42
@octavia-squidington-iii octavia-squidington-iii added area/api Related to the api area/connectors Connector related issues area/documentation Improvements or additions to documentation area/platform issues related to the platform CDK Connector Development Kit labels Feb 23, 2023
@github-actions
Copy link
Contributor

Affected Connector Report

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to do the following as needed:

  • Run integration tests
  • Bump connector or module version
  • Add changelog
  • Publish the new version

✅ Sources (31)

Connector Version Changelog Publish
source-alloydb 1.0.47
source-alloydb-strict-encrypt 1.0.47 🔵
(ignored)
🔵
(ignored)
source-bigquery 0.2.3
source-clickhouse 0.1.15
source-clickhouse-strict-encrypt 0.1.15 🔵
(ignored)
🔵
(ignored)
source-cockroachdb 0.1.19
source-cockroachdb-strict-encrypt 0.1.19 🔵
(ignored)
🔵
(ignored)
source-db2 0.1.17
source-db2-strict-encrypt 0.1.17 🔵
(ignored)
🔵
(ignored)
source-dynamodb 0.1.1
source-e2e-test 2.1.3
source-e2e-test-cloud 2.1.1 🔵
(ignored)
🔵
(ignored)
source-elasticsearch 0.1.1
source-jdbc 0.3.5 🔵
(ignored)
🔵
(ignored)
source-kafka 0.2.3
source-mongodb-strict-encrypt 0.1.19 🔵
(ignored)
🔵
(ignored)
source-mongodb-v2 0.1.19
source-mssql 0.4.28
source-mssql-strict-encrypt 0.4.28 🔵
(ignored)
🔵
(ignored)
source-mysql 1.0.21
source-mysql-strict-encrypt 1.0.21 🔵
(ignored)
🔵
(ignored)
source-oracle 0.3.22
source-oracle-strict-encrypt 0.3.22 🔵
(ignored)
🔵
(ignored)
source-postgres 1.0.47
source-postgres-strict-encrypt 1.0.47 🔵
(ignored)
🔵
(ignored)
source-railz 0.1.1
source-redshift 0.3.16
source-scaffold-java-jdbc 0.1.0 🔵
(ignored)
🔵
(ignored)
source-sftp 0.1.2
source-snowflake 0.1.30
source-tidb 0.2.2
  • See "Actionable Items" below for how to resolve warnings and errors.

✅ Destinations (13)

Connector Version Changelog Publish
destination-bigquery 1.2.14
destination-bigquery-denormalized 1.2.14
destination-databricks 0.3.1
destination-doris 0.1.0
destination-gcs 0.2.14
destination-jdbc 0.3.14 🔵
(ignored)
🔵
(ignored)
destination-r2 0.1.0
destination-redshift 0.3.56
destination-s3 0.3.20
destination-s3-glue 0.1.2
destination-snowflake 0.4.47
destination-teradata 0.1.0
destination-yugabytedb 0.1.0
  • See "Actionable Items" below for how to resolve warnings and errors.

👀 Other Modules (1)

  • base-normalization

Actionable Items

(click to expand)

Category Status Actionable Item
Version
mismatch
The version of the connector is different from its normal variant. Please bump the version of the connector.

doc not found
The connector does not seem to have a documentation file. This can be normal (e.g. basic connector like source-jdbc is not published or documented). Please double-check to make sure that it is not a bug.
Changelog
doc not found
The connector does not seem to have a documentation file. This can be normal (e.g. basic connector like source-jdbc is not published or documented). Please double-check to make sure that it is not a bug.

changelog missing
There is no chnagelog for the current version of the connector. If you are the author of the current version, please add a changelog.
Publish
not in seed
The connector is not in the seed file (e.g. source_definitions.yaml), so its publication status cannot be checked. This can be normal (e.g. some connectors are cloud-specific, and only listed in the cloud seed file). Please double-check to make sure that it is not a bug.

diff seed version
The connector exists in the seed file, but the latest version is not listed there. This usually means that the latest version is not published. Please use the /publish command to publish the latest version.

@@ -24,7 +24,7 @@ info:
url: "https://opensource.org/licenses/MIT"
externalDocs:
description: Find out more about Airbyte
url: "https://airbyte.io"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, this updates the swagger url. The only place this is used in connectors repo is to feed Octavia CLI. So now Octavia CLI will use updated url. just wanted to point out the app implication here, though it is a change we want.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay I'll remove this

@octavia-squidington-iii octavia-squidington-iii removed area/api Related to the api area/platform issues related to the platform labels Feb 24, 2023
@sophia-wiley
Copy link
Contributor Author

Closing this PR in favor of 23652

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation CDK Connector Development Kit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants