Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format and Process Resources in PR autoamtically #23415

Merged
merged 10 commits into from
Feb 24, 2023
Merged

Conversation

evantahler
Copy link
Contributor

@evantahler evantahler commented Feb 23, 2023

This PR re-thinks some of our connector pipelines:

  1. Formatting files should not fail a build. Instead, the formatter should update those files for you and commit them back to your branch
  2. Making a change to the actor definitions (source, destination) should automatically ./gradlew :airbyte-config:init:processResources for you, and commit back any of those changes. This handles things like updating the new connectors.md

Example:

  1. I added something in 63a448d that changed one of the generated files
  2. Wait for it...
  3. The bot added 3c90bec back to my branch

Closes #23405

@evantahler evantahler changed the title Format and Process Resources on master branch Format and Process Resources in PR Feb 23, 2023
@evantahler evantahler changed the title Format and Process Resources in PR Format and Process Resources in PR autoamtically Feb 23, 2023
@evantahler
Copy link
Contributor Author

@pedroslopez - rather than always processResources on master, what if we did it automatically within the PR and wrote those changes back?

Copy link
Contributor

@bnchrch bnchrch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very keen on this change

@evantahler evantahler requested a review from maxi297 February 23, 2023 22:40
@evantahler
Copy link
Contributor Author

^ it worked!

@evantahler evantahler marked this pull request as ready for review February 24, 2023 00:59
@evantahler
Copy link
Contributor Author

@sherifnada yay! f62c360

Copy link
Contributor

@pedroslopez pedroslopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@evantahler evantahler merged commit b79f64b into master Feb 24, 2023
@evantahler evantahler deleted the evan/build-on-master branch February 24, 2023 18:05
maxi297 added a commit that referenced this pull request Mar 1, 2023
* Isolate our build so that the feedback loop is faster

* Improve gradle build condition

* Update documentation

* Adding auto-commit of formatting changes (as #23415)
danielduckworth pushed a commit to danielduckworth/airbyte that referenced this pull request Mar 13, 2023
* Format and Process Resources on master branch

* gradle.yaml writes

* TEST

* checkout right branch

* check out ref

* Automated Change

* check for changes before format

* Automated Change

---------

Co-authored-by: evantahler <evantahler@users.noreply.github.com>
danielduckworth pushed a commit to danielduckworth/airbyte that referenced this pull request Mar 13, 2023
* Isolate our build so that the feedback loop is faster

* Improve gradle build condition

* Update documentation

* Adding auto-commit of formatting changes (as airbytehq#23415)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

move connector.md generation to running on master
4 participants