-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding allowHosts to all non-GA source database connectors #23455
Merged
prateekmukhedkar
merged 40 commits into
master
from
prateekmukhedkar/add-allowedhosts-dbsources-non-ga
Mar 8, 2023
Merged
Changes from all commits
Commits
Show all changes
40 commits
Select commit
Hold shift + click to select a range
27d5229
https://github.com/airbytehq/airbyte/issues/22372 Adding allowedHosts…
prateekmukhedkar 91c1deb
Automated Change
prateekmukhedkar b7e09a3
Merge branch 'master' into prateekmukhedkar/add-allowedhosts-dbsource…
prateekmukhedkar 0a7de2f
Updated name of "File" source
prateekmukhedkar 49a8a82
Automated Change
prateekmukhedkar 0af62b4
Merge branch 'master' into prateekmukhedkar/add-allowedhosts-dbsource…
prateekmukhedkar 7ff4afa
1. Validting with source_specs.yaml on how host name is configured.
prateekmukhedkar 2b80402
Merge branch 'master' into prateekmukhedkar/add-allowedhosts-dbsource…
prateekmukhedkar e03db0f
Merge branch 'master' into prateekmukhedkar/add-allowedhosts-dbsource…
prateekmukhedkar 422a502
Bumped up version numbers and release notes.
prateekmukhedkar 5d4cf4b
Revert "Bumped up version numbers and release notes."
prateekmukhedkar 4ee5eb2
Revert "Revert "Bumped up version numbers and release notes.""
prateekmukhedkar 5719049
https://github.com/airbytehq/airbyte/issues/22372 Adding allowedHosts…
prateekmukhedkar 543c0cc
Automated Change
prateekmukhedkar 2b97723
Updated name of "File" source
prateekmukhedkar a9a6e6b
Automated Change
prateekmukhedkar 078c29e
1. Validting with source_specs.yaml on how host name is configured.
prateekmukhedkar e394205
Bumped up version numbers and release notes.
prateekmukhedkar 0bc23d2
Revert "Bumped up version numbers and release notes."
prateekmukhedkar d9f9faa
Revert "Revert "Bumped up version numbers and release notes.""
prateekmukhedkar 1f9a44d
Merge branch 'master' into prateekmukhedkar/add-allowedhosts-dbsource…
prateekmukhedkar 1beaa98
Merge branch 'prateekmukhedkar/add-allowedhosts-dbsources-non-ga' of …
prateekmukhedkar affdb15
Merge branch 'master' into prateekmukhedkar/add-allowedhosts-dbsource…
prateekmukhedkar da2d157
Automated Change
prateekmukhedkar b8ba970
Not releasing MySQL and MSSQL allowed host changes until Debezium cha…
prateekmukhedkar 6287322
Merge branch 'prateekmukhedkar/add-allowedhosts-dbsources-non-ga' of …
prateekmukhedkar 830e844
Fixed formatting, year (2023)
prateekmukhedkar 5c2fef0
auto-bump connector version
octavia-squidington-iii 2e27d8e
auto-bump connector version
octavia-squidington-iii a247f8c
auto-bump connector version
octavia-squidington-iii 9a05296
auto-bump connector version
octavia-squidington-iii 55ebece
auto-bump connector version
octavia-squidington-iii e67118e
auto-bump connector version
octavia-squidington-iii f692e42
Not releasing allowedHost change for MySQL and MSSQL
prateekmukhedkar d726a96
Merge branch 'prateekmukhedkar/add-allowedhosts-dbsources-non-ga' of …
prateekmukhedkar bb6345f
Merge branch 'master' into prateekmukhedkar/add-allowedhosts-dbsource…
prateekmukhedkar 3d213a3
Bumped up version number for DB2 and Clickhouse strict-encrypt versions.
prateekmukhedkar 33533ec
Merge branch 'prateekmukhedkar/add-allowedhosts-dbsources-non-ga' of …
prateekmukhedkar 1926279
Removing Azure-table, Fauna and Redshift because of failing acceptanc…
prateekmukhedkar 46092af
Removing allowedHosts for Source Firebolt because of failing acceptan…
prateekmukhedkar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it might be called "account_name" for snowflake:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope! I was wrong - it's still "host":
airbyte/airbyte-config/init/src/main/resources/seed/source_specs.yaml
Lines 14068 to 14075 in 7da6a3b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for pointing me to
source_specs.yaml
. Turns out it is nothost
name in all places.