-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Source Faker: export json files #23468
Conversation
/test connector=source-faker
Build PassedTest summary info:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sweet.
package_data={"": ["*.json"]}, | ||
package_data={"": ["*.json", "schemas/*.json", "record_data/*.json"]}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For all connectors which might one day need to do this... is there a globpattern we should add to bundle all data files like ["**/*.json", "**/*.yaml"]
?
What
This bundles all the JSONs in the
schemas/
directory with the wheel/pip package which gets built when someone runspip install
against this package.The motivation is that I'm working on a project which directly imports connectors such as this one from another python package e.g
from source_faker import SourceFaker
. Butread
anddiscover
don't run properly since this these JSON files are needed for the connector to work but are not being packaged with the pip package produced by this connector.Notes
This is not meaningful enough to require publishing a new connector version so I won't do it. But I'll run
/test
anyways