Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Source Shopify: fix OOM/memory leak #23473

Merged
merged 6 commits into from
Feb 27, 2023
Merged

Conversation

bazarnov
Copy link
Collaborator

@bazarnov bazarnov commented Feb 27, 2023

What

Resolving:

How

  • changed @Property to functools.cached_property

🚨 User Impact 🚨

No impact is expected. Trivial update.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

Updating a connector

Community member or Airbyter

  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Feb 27, 2023
@bazarnov bazarnov requested a review from lazebnyi February 27, 2023 14:09
@bazarnov bazarnov linked an issue Feb 27, 2023 that may be closed by this pull request
@bazarnov
Copy link
Collaborator Author

bazarnov commented Feb 27, 2023

/test connector=connectors/source-shopify

🕑 connectors/source-shopify https://github.com/airbytehq/airbyte/actions/runs/4283391813
✅ connectors/source-shopify https://github.com/airbytehq/airbyte/actions/runs/4283391813
Python tests coverage:

Name                               Stmts   Miss  Cover
------------------------------------------------------
source_shopify/shopify_schema.py   10152      0   100%
source_shopify/auth.py                20      0   100%
source_shopify/__init__.py             2      0   100%
source_shopify/transform.py           58      3    95%
source_shopify/utils.py               92     10    89%
source_shopify/source.py             439     67    85%
source_shopify/graphql.py             47     40    15%
------------------------------------------------------
TOTAL                              10810    120    99%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:98: The previous and actual specifications are identical.
SKIPPED [3] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:507: The previous and actual discovered catalogs are identical.
=========== 55 passed, 4 skipped, 37 warnings in 2188.44s (0:36:28) ============

@bazarnov
Copy link
Collaborator Author

bazarnov commented Feb 27, 2023

/publish connector=connectors/source-shopify

🕑 Publishing the following connectors:
connectors/source-shopify
https://github.com/airbytehq/airbyte/actions/runs/4284999645


Connector Did it publish? Were definitions generated?
connectors/source-shopify

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@bazarnov bazarnov merged commit b7808a3 into master Feb 27, 2023
@bazarnov bazarnov deleted the baz/source-shoppify-fix-oom branch February 27, 2023 19:19
a-rampalli pushed a commit to rudderlabs/airbyte that referenced this pull request Mar 3, 2023
a-rampalli added a commit to rudderlabs/airbyte that referenced this pull request Mar 3, 2023
danielduckworth pushed a commit to danielduckworth/airbyte that referenced this pull request Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/shopify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shopify Connector Memory Consumption
3 participants