Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Source Salesloft: fix build #23564

Merged
merged 3 commits into from
Feb 28, 2023
Merged

Source Salesloft: fix build #23564

merged 3 commits into from
Feb 28, 2023

Conversation

davydov-d
Copy link
Collaborator

What

Fix build to unblock release to cloud #23478

How

Allow additional properties in the spec and stream schemas

@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/salesloft labels Feb 28, 2023
@davydov-d
Copy link
Collaborator Author

davydov-d commented Feb 28, 2023 •
edited by github-actions bot
Loading

/test connector=connectors/source-salesloft

🕑 connectors/source-salesloft https://github.com/airbytehq/airbyte/actions/runs/4292792256

@grubberr grubberr self-requested a review February 28, 2023 12:21
@davydov-d
Copy link
Collaborator Author

/test connector=connectors/source-salesloft

clock2 connectors/source-salesloft https://github.com/airbytehq/airbyte/actions/runs/4292792256

tests passed although the comment was not updated

@davydov-d
Copy link
Collaborator Author

davydov-d commented Feb 28, 2023 •
edited by github-actions bot
Loading

/publish connector=connectors/source-salesloft

🕑 Publishing the following connectors:
connectors/source-salesloft
https://github.com/airbytehq/airbyte/actions/runs/4294026231


Connector Did it publish? Were definitions generated?
connectors/source-salesloft ✅ ✅

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@davydov-d davydov-d merged commit 4f9a7db into master Feb 28, 2023
@davydov-d davydov-d deleted the ddavydov/#23478-sourcel-salesloft-fix-buildc branch February 28, 2023 15:09
danielduckworth pushed a commit to danielduckworth/airbyte that referenced this pull request Mar 13, 2023
@davydov-d @octavia-squidington-iii @danielduckworth
Source Salesloft: fix build (airbytehq#23564)
d2299c5 
* airbytehq#23478 source salesloft: fix build

* airbytehq#23478 source salesloft: upd changelog

* auto-bump connector version

---------

Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grubberr grubberr grubberr approved these changes

@bazarnov bazarnov Awaiting requested review from bazarnov

@lazebnyi lazebnyi Awaiting requested review from lazebnyi

Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/salesloft
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davydov-d @grubberr @octavia-squidington-iii