Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎉 New Source: Everhour [low-code cdk] #23593

Merged
merged 16 commits into from
Mar 23, 2023

Conversation

tuanchris
Copy link
Contributor

@tuanchris tuanchris commented Feb 28, 2023

What

How

Recommended reading order

  1. x.java
  2. y.python

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the connector is published, connector added to connector index as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here
Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub and connector version bumped by running the /publish command described here
Connector Generator
  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed

@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/everhour labels Feb 28, 2023
@tuanchris tuanchris changed the title Source everhour 🎉 New Source: Everhour Feb 28, 2023
@tuanchris tuanchris changed the title 🎉 New Source: Everhour 🎉 New Source: Everhour [low-code cdk] Feb 28, 2023
@tuanchris
Copy link
Contributor Author

Integration test passing:

@tuanchris tuanchris marked this pull request as ready for review February 28, 2023 20:48
@YowanR
Copy link
Contributor

YowanR commented Feb 28, 2023

@sh4sh @nataliekwong can you please take a look at this PR? 🙏

@nataliekwong
Copy link
Contributor

Tagging @natalyjazzviolin

@sh4sh sh4sh added the waiting-for-cred Waiting for CI credentials label Mar 8, 2023
@tuanchris tuanchris requested a review from sh4sh March 9, 2023 16:57
@tuanchris
Copy link
Contributor Author

Can you have another look when you have the chance? @sh4sh

@YowanR YowanR requested a review from a team March 17, 2023 18:36
@tuanchris tuanchris requested a review from marcosmarxm March 17, 2023 19:06
@YowanR YowanR requested a review from a team March 20, 2023 17:37
@marcosmarxm marcosmarxm added the contributor-program PRs submitted through the contributor program. label Mar 22, 2023
@marcosmarxm
Copy link
Member

marcosmarxm commented Mar 23, 2023

/test connector=connectors/source-everhour

🕑 connectors/source-everhour https://github.com/airbytehq/airbyte/actions/runs/4504102171
✅ connectors/source-everhour https://github.com/airbytehq/airbyte/actions/runs/4504102171
No Python unittests run

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/plugin.py:63: Skipping TestIncremental.test_two_sequential_reads: This connector does not implement incremental sync
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:103: The previous connector image could not be retrieved.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:581: The previous connector image could not be retrieved.
======================== 35 passed, 3 skipped in 34.81s ========================

@marcosmarxm
Copy link
Member

marcosmarxm commented Mar 23, 2023

/publish connector=connectors/source-everhour

🕑 Publishing the following connectors:
connectors/source-everhour
https://github.com/airbytehq/airbyte/actions/runs/4504233151


Connector Did it publish? Were definitions generated?
connectors/source-everhour

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@marcosmarxm marcosmarxm merged commit 066aeda into airbytehq:master Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation contributor-program PRs submitted through the contributor program. waiting-for-cred Waiting for CI credentials
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants