Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Revert "🐛 Source Dynamodb: Fix reserved words in expression"" #23598

Merged

Conversation

sh4sh
Copy link
Contributor

@sh4sh sh4sh commented Feb 28, 2023

Reverts #23515 and finally merges #20172.

Closes #19739

@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/dynamodb labels Feb 28, 2023
@github-actions
Copy link
Contributor

Affected Connector Report

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to do the following as needed:

  • Run integration tests
  • Bump connector or module version
  • Add changelog
  • Publish the new version

✅ Sources (1)

Connector Version Changelog Publish
source-dynamodb 0.1.2
  • See "Actionable Items" below for how to resolve warnings and errors.

✅ Destinations (0)

Connector Version Changelog Publish
  • See "Actionable Items" below for how to resolve warnings and errors.

✅ Other Modules (0)

Actionable Items

(click to expand)

Category Status Actionable Item
Version
mismatch
The version of the connector is different from its normal variant. Please bump the version of the connector.

doc not found
The connector does not seem to have a documentation file. This can be normal (e.g. basic connector like source-jdbc is not published or documented). Please double-check to make sure that it is not a bug.
Changelog
doc not found
The connector does not seem to have a documentation file. This can be normal (e.g. basic connector like source-jdbc is not published or documented). Please double-check to make sure that it is not a bug.

changelog missing
There is no chnagelog for the current version of the connector. If you are the author of the current version, please add a changelog.
Publish
not in seed
The connector is not in the seed file (e.g. source_definitions.yaml), so its publication status cannot be checked. This can be normal (e.g. some connectors are cloud-specific, and only listed in the cloud seed file). Please double-check to make sure that it is not a bug.

diff seed version
The connector exists in the seed file, but the latest version is not listed there. This usually means that the latest version is not published. Please use the /publish command to publish the latest version.

@sh4sh
Copy link
Contributor Author

sh4sh commented Feb 28, 2023

All checks have passed! After this is approved, we can /publish and merge.

@sh4sh sh4sh merged commit 821fce1 into master Mar 2, 2023
@sh4sh sh4sh deleted the revert-23515-revert-20172-dynamodb-fix-reserved-keyword branch March 2, 2023 16:32
@sh4sh
Copy link
Contributor Author

sh4sh commented Mar 2, 2023

Publishing in #20172

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/dynamodb
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Source DynamoDB - Reserved Keyword Issue
3 participants