Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connector Health: Fixed SAT for Amazon Ads, Faker, Hubspot, Instagram, Pinterest, Sentry, Zendesk Talk #23600

Merged
merged 5 commits into from
Mar 1, 2023

Conversation

lazebnyi
Copy link
Collaborator

@lazebnyi lazebnyi commented Mar 1, 2023

What

Fixed SAT for Amazon Ads, Faker, Hubspot, Instagram, Pinterest, Sentry, Zendesk Talk

How

Updated expected records and acceptance-test-config to new format for ignored_fields. Fixed issue with loopback date for pinterest.

@lazebnyi
Copy link
Collaborator Author

lazebnyi commented Mar 1, 2023

/test connector=connectors/source-zendesk-talk

🕑 connectors/source-zendesk-talk https://github.com/airbytehq/airbyte/actions/runs/4298794830
✅ connectors/source-zendesk-talk https://github.com/airbytehq/airbyte/actions/runs/4298794830
Python tests coverage:

Name                              Stmts   Miss  Cover
-----------------------------------------------------
source_zendesk_talk/__init__.py       2      0   100%
source_zendesk_talk/streams.py      143     12    92%
source_zendesk_talk/source.py        34      3    91%
-----------------------------------------------------
TOTAL                               179     15    92%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical.
SKIPPED [2] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:509: The previous and actual discovered catalogs are identical.
=================== 44 passed, 3 skipped in 72.28s (0:01:12) ===================

@lazebnyi
Copy link
Collaborator Author

lazebnyi commented Mar 1, 2023

/test connector=connectors/source-instagram

🕑 connectors/source-instagram https://github.com/airbytehq/airbyte/actions/runs/4298800516
❌ connectors/source-instagram https://github.com/airbytehq/airbyte/actions/runs/4298800516
🐛 https://gradle.com/s/j7daitl6q77u2

Build Failed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:509: The previous and actual discovered catalogs are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_incremental.py:212: Skipping new incremental test based on acceptance-test-config.yml
================== 34 passed, 3 skipped in 483.66s (0:08:03) ===================
	 =========================== short test summary info ============================
	 FAILED integration_tests/test_streams.py::TestInstagramSource::test_incremental_streams
	 �[31m======================== �[31m�[1m1 failed�[0m, �[33m2 warnings�[0m�[31m in 50.19s�[0m�[31m ========================�[0m

@lazebnyi
Copy link
Collaborator Author

lazebnyi commented Mar 1, 2023

/test connector=connectors/source-hubspot

🕑 connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/4298803732
✅ connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/4298803732
Python tests coverage:

Name                          Stmts   Miss  Cover
-------------------------------------------------
source_hubspot/errors.py          6      0   100%
source_hubspot/constants.py       2      0   100%
source_hubspot/__init__.py        2      0   100%
source_hubspot/helpers.py        70      3    96%
source_hubspot/streams.py       831     78    91%
source_hubspot/source.py         60     19    68%
-------------------------------------------------
TOTAL                           971    100    90%
Name                          Stmts   Miss  Cover
-------------------------------------------------
source_hubspot/errors.py          6      0   100%
source_hubspot/constants.py       2      0   100%
source_hubspot/__init__.py        2      0   100%
source_hubspot/helpers.py        70     10    86%
source_hubspot/source.py         60     14    77%
source_hubspot/streams.py       831    213    74%
-------------------------------------------------
TOTAL                           971    237    76%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:509: The previous and actual discovered catalogs are identical.
================== 37 passed, 2 skipped in 409.03s (0:06:49) ===================

@lazebnyi
Copy link
Collaborator Author

lazebnyi commented Mar 1, 2023

/test connector=connectors/source-faker

🕑 connectors/source-faker https://github.com/airbytehq/airbyte/actions/runs/4298821300
✅ connectors/source-faker https://github.com/airbytehq/airbyte/actions/runs/4298821300
Python tests coverage:

Name                                               Stmts   Miss  Cover
----------------------------------------------------------------------
source_faker/__init__.py                               2      0   100%
source_faker/streams.py                              126      1    99%
source_faker/source.py                                17      3    82%
source_faker/utils.py                                 18      6    67%
source_faker/airbyte_message_with_cached_json.py       8      4    50%
source_faker/user_generator.py                        28     16    43%
source_faker/purchase_generator.py                    55     41    25%
----------------------------------------------------------------------
TOTAL                                                254     71    72%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:509: The previous and actual discovered catalogs are identical.
======================== 35 passed, 2 skipped in 37.98s ========================

@lazebnyi
Copy link
Collaborator Author

lazebnyi commented Mar 1, 2023

/test connector=connectors/source-amazon-ads

🕑 connectors/source-amazon-ads https://github.com/airbytehq/airbyte/actions/runs/4298822718
✅ connectors/source-amazon-ads https://github.com/airbytehq/airbyte/actions/runs/4298822718
Python tests coverage:

Name                                                              Stmts   Miss  Cover
-------------------------------------------------------------------------------------
source_amazon_ads/utils.py                                           22      0   100%
source_amazon_ads/streams/sponsored_products.py                      41      0   100%
source_amazon_ads/streams/sponsored_display.py                       31      0   100%
source_amazon_ads/streams/sponsored_brands.py                        26      0   100%
source_amazon_ads/streams/report_streams/products_report.py          20      0   100%
source_amazon_ads/streams/report_streams/display_report.py           18      0   100%
source_amazon_ads/streams/report_streams/brands_video_report.py      12      0   100%
source_amazon_ads/streams/report_streams/brands_report.py            12      0   100%
source_amazon_ads/streams/report_streams/__init__.py                  5      0   100%
source_amazon_ads/streams/profiles.py                                21      0   100%
source_amazon_ads/streams/attribution_report.py                      81      0   100%
source_amazon_ads/streams/__init__.py                                 7      0   100%
source_amazon_ads/schemas/sponsored_products.py                      37      0   100%
source_amazon_ads/schemas/sponsored_display.py                       31      0   100%
source_amazon_ads/schemas/sponsored_brands.py                        22      0   100%
source_amazon_ads/schemas/profile.py                                 16      0   100%
source_amazon_ads/schemas/attribution_report.py                      21      0   100%
source_amazon_ads/schemas/__init__.py                                 7      0   100%
source_amazon_ads/constants.py                                        1      0   100%
source_amazon_ads/__init__.py                                         2      0   100%
source_amazon_ads/schemas/common.py                                  50      1    98%
source_amazon_ads/source.py                                          47      1    98%
source_amazon_ads/streams/common.py                                  83      2    98%
source_amazon_ads/streams/report_streams/report_streams.py          243     19    92%
-------------------------------------------------------------------------------------
TOTAL                                                               856     23    97%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:509: The previous and actual discovered catalogs are identical.
================== 36 passed, 2 skipped in 480.14s (0:08:00) ===================

@lazebnyi lazebnyi requested a review from evantahler March 1, 2023 01:15
@lazebnyi
Copy link
Collaborator Author

lazebnyi commented Mar 1, 2023

/test connector=connectors/source-pinterest

🕑 connectors/source-pinterest https://github.com/airbytehq/airbyte/actions/runs/4299009318
✅ connectors/source-pinterest https://github.com/airbytehq/airbyte/actions/runs/4299009318
Python tests coverage:

Name                           Stmts   Miss  Cover
--------------------------------------------------
source_pinterest/utils.py          4      0   100%
source_pinterest/__init__.py       2      0   100%
source_pinterest/source.py       224     18    92%
--------------------------------------------------
TOTAL                            230     18    92%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical.
SKIPPED [2] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:509: The previous and actual discovered catalogs are identical.
================== 44 passed, 3 skipped in 159.71s (0:02:39) ===================

@lazebnyi
Copy link
Collaborator Author

lazebnyi commented Mar 1, 2023

/test connector=connectors/source-sentry

🕑 connectors/source-sentry https://github.com/airbytehq/airbyte/actions/runs/4299009916
✅ connectors/source-sentry https://github.com/airbytehq/airbyte/actions/runs/4299009916
Python tests coverage:

Name                        Stmts   Miss  Cover
-----------------------------------------------
source_sentry/source.py        18      0   100%
source_sentry/__init__.py       2      0   100%
source_sentry/streams.py       93     14    85%
-----------------------------------------------
TOTAL                         113     14    88%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:509: The previous and actual discovered catalogs are identical.
=================== 36 passed, 2 skipped in 65.49s (0:01:05) ===================

Copy link
Contributor

@evantahler evantahler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome!

👍 assuming all the connector tests pass

@lazebnyi lazebnyi requested a review from davydov-d March 1, 2023 02:00
@lazebnyi
Copy link
Collaborator Author

lazebnyi commented Mar 1, 2023

/test connector=connectors/source-instagram

🕑 connectors/source-instagram https://github.com/airbytehq/airbyte/actions/runs/4301694916
✅ connectors/source-instagram https://github.com/airbytehq/airbyte/actions/runs/4301694916
Python tests coverage:

Name                           Stmts   Miss  Cover
--------------------------------------------------
source_instagram/source.py        31      0   100%
source_instagram/__init__.py       2      0   100%
source_instagram/common.py        36      3    92%
source_instagram/streams.py      205     20    90%
source_instagram/api.py           59      7    88%
--------------------------------------------------
TOTAL                            333     30    91%
Name                           Stmts   Miss  Cover
--------------------------------------------------
source_instagram/__init__.py       2      0   100%
source_instagram/api.py           59      5    92%
source_instagram/source.py        31     11    65%
source_instagram/streams.py      205     94    54%
source_instagram/common.py        36     22    39%
--------------------------------------------------
TOTAL                            333    132    60%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:509: The previous and actual discovered catalogs are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_incremental.py:212: Skipping new incremental test based on acceptance-test-config.yml
================== 34 passed, 3 skipped in 255.35s (0:04:15) ===================

@grubberr grubberr self-requested a review March 1, 2023 09:04
@lazebnyi lazebnyi removed the request for review from davydov-d March 1, 2023 09:05
@lazebnyi lazebnyi merged commit 3d8f81a into master Mar 1, 2023
@lazebnyi lazebnyi deleted the lazebnyi/01-fix-connector-health-build branch March 1, 2023 09:09
danielduckworth pushed a commit to danielduckworth/airbyte that referenced this pull request Mar 13, 2023
…, Pinterest, Sentry, Zendesk Talk (airbytehq#23600)

* Fixed SAT for some connecotrs

* Fix unittest pinterest

* add allowedHosts

* Updated unittest for instagram

* Fix expected records instagram
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants