-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Source Sentry: fix None
state_value + other bad state_values
#23619
Conversation
/test connector=connectors/source-sentry Updated: |
airbyte-integrations/connectors/source-sentry/source_sentry/streams.py
Outdated
Show resolved
Hide resolved
/test connector=connectors/source-sentry
Build PassedTest summary info:
|
…ix-None-state-value
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Only need add unit tests 😊
/publish connector=connectors/source-sentry
if you have connectors that successfully published but failed definition generation, follow step 4 here |
What
Resolving: https://github.com/airbytehq/oncall/issues/1575
How
get_state_value
method to parse the state correctly🚨 User Impact 🚨
No impact is expected.
Pre-merge Checklist
Expand the relevant checklist and delete the others.
Updating a connector
Community member or Airbyter
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampleAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing/publish
command described here