Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Source Sentry: fix None state_value + other bad state_values #23619

Merged
merged 8 commits into from
Mar 2, 2023

Conversation

bazarnov
Copy link
Collaborator

@bazarnov bazarnov commented Mar 1, 2023

What

Resolving: https://github.com/airbytehq/oncall/issues/1575

How

  • added dedicated get_state_value method to parse the state correctly

🚨 User Impact 🚨

No impact is expected.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

Updating a connector

Community member or Airbyter

  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/sentry labels Mar 1, 2023
@bazarnov bazarnov requested review from davydov-d and lazebnyi March 1, 2023 12:28
@bazarnov
Copy link
Collaborator Author

bazarnov commented Mar 1, 2023

/test connector=connectors/source-sentry

Updated:
Rate limit is exceeded: https://github.com/airbytehq/airbyte/actions/runs/4303525345/jobs/7503399194

@bazarnov bazarnov requested a review from lazebnyi March 1, 2023 20:12
@bazarnov
Copy link
Collaborator Author

bazarnov commented Mar 1, 2023

/test connector=connectors/source-sentry

🕑 connectors/source-sentry https://github.com/airbytehq/airbyte/actions/runs/4307552970
✅ connectors/source-sentry https://github.com/airbytehq/airbyte/actions/runs/4307552970
Python tests coverage:

Name                        Stmts   Miss  Cover
-----------------------------------------------
source_sentry/source.py        18      0   100%
source_sentry/__init__.py       2      0   100%
source_sentry/streams.py      101     19    81%
-----------------------------------------------
TOTAL                         121     19    84%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:509: The previous and actual discovered catalogs are identical.
=================== 36 passed, 2 skipped in 68.51s (0:01:08) ===================

Copy link
Collaborator

@lazebnyi lazebnyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Only need add unit tests 😊

@bazarnov
Copy link
Collaborator Author

bazarnov commented Mar 2, 2023

/publish connector=connectors/source-sentry

🕑 Publishing the following connectors:
connectors/source-sentry
https://github.com/airbytehq/airbyte/actions/runs/4314480204


Connector Did it publish? Were definitions generated?
connectors/source-sentry

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@bazarnov bazarnov merged commit 93fc5c9 into master Mar 2, 2023
@bazarnov bazarnov deleted the baz/source-sentry-fix-None-state-value branch March 2, 2023 14:07
danielduckworth pushed a commit to danielduckworth/airbyte that referenced this pull request Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/sentry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants