Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #22442] fixing race condition in the pipeline #23670

Merged
merged 1 commit into from
Mar 2, 2023

Conversation

maxi297
Copy link
Contributor

@maxi297 maxi297 commented Mar 2, 2023

What

With the new pipeline where we publish the docker image, we can’t:

  • Bump version
  • Build (which pip install airbyte-cdk==<version from the repo>)
  • Publish CDK
    … anymore because since the version has been bumped but not published, it is not accessible during the pip-install in the Dockerfile

How

If we build before the pipeline, we still get some validation even though this validation is without the newer version number. The flow would look like:

  • Build
  • Bump version
  • Publish CDK
  • Publish Docker

@maxi297 maxi297 requested a review from girarda March 2, 2023 15:54
@maxi297 maxi297 merged commit f1ee2c3 into master Mar 2, 2023
@maxi297 maxi297 deleted the issue-22442_fix-race-condition-in-publishing-steps branch March 2, 2023 16:00
danielduckworth pushed a commit to danielduckworth/airbyte that referenced this pull request Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants