Add connector ops' required review when changing bypass_reasons on GA connectors #23740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… asserted against
…cker to be able to compare them. Fix tests
alafanechere
approved these changes
Mar 6, 2023
tools/ci_connector_ops/ci_connector_ops/acceptance_test_config_checks.py
Outdated
Show resolved
Hide resolved
danielduckworth
pushed a commit
to danielduckworth/airbyte
that referenced
this pull request
Mar 13, 2023
… connectors (airbytehq#23740) * Add instructions to install reqs and run tests locally * add passing tests with old behavior * Make it like test strictness level * Remove expected teams from non-tracked change test since they are not asserted against * Make changed GA connector list object same object format as regex checker to be able to compare them. Fix tests * Refactor and align naming * Update all find methods to return Connector objects * Bump setup.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
How
find_changed_ga_connectorsmethod to return set(str) like the other checks. I believe this should be fine since it's not used anywhere else and we don't expose it as a console script in setup.py.check_review_requirements_filecheck, which will verify whether the requirements file was created as well as if it contains the right reviewers.Recommended reading order