CDK: retry token refresh requests #23815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…reshing-access-tokens
sherifnada
approved these changes
Mar 7, 2023
| @@ -64,22 +70,34 @@ def build_refresh_request_body(self) -> Mapping[str, Any]: | |||
|
|
|||
| return payload | |||
|
|
|||
| @backoff.on_exception( | |||
There was a problem hiding this comment.
Just out of curiosity. Is it possible to disable or configure this behavior if needed? Not urgent/blocking.
There was a problem hiding this comment.
Well disabling may be a bit more more challenging than configuring it but still I think both are possible. Anyway, I think it's worth doing in a dedicated PR if we do need these options
davydov-d
deleted the
ddavydov/#23767-cdk-retry-requests-for-refreshing-access-tokens
branch
This was referenced Mar 7, 2023
danielduckworth
pushed a commit
to danielduckworth/airbyte
that referenced
this pull request
Mar 13, 2023
* airbytehq#23767 CDK: retry token refresh requests * Automated Commit - Formatting Changes --------- Co-authored-by: davydov-d <davydov-d@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
#23767
How
Using backoff exponential strategy