Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

temporary fix for Connectors Base CI #23829

Merged
merged 1 commit into from
Mar 7, 2023

Conversation

maxi297
Copy link
Contributor

@maxi297 maxi297 commented Mar 7, 2023

What

Fixes error like https://github.com/airbytehq/airbyte/actions/runs/4327429815/jobs/7556319706

Caching seems to screw the venv. I'll investigate further but this should enable the PRs to be merged at least

@clnoll
Copy link
Contributor

clnoll commented Mar 7, 2023

@maxi297 I'm wondering if we could be a bit more surgical and just remove this line?

@maxi297
Copy link
Contributor Author

maxi297 commented Mar 7, 2023

@maxi297 I'm wondering if we could be a bit more surgical and just remove this line?

octavia-cli-build and cdk-build also uses this so this could have impacts elsewhere. This might actually be part of the problem actually so let me investigate that!

Copy link
Contributor

@clnoll clnoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, approved in the meantime in order to unblock people.

@maxi297 maxi297 merged commit ed0a423 into master Mar 7, 2023
@maxi297 maxi297 deleted the maxi297/fix-ci-airbyte-connectors-base branch March 7, 2023 16:15
maxi297 added a commit that referenced this pull request Mar 7, 2023
maxi297 added a commit that referenced this pull request Mar 7, 2023
grishick added a commit that referenced this pull request Mar 9, 2023
grishick added a commit that referenced this pull request Mar 9, 2023
danielduckworth pushed a commit to danielduckworth/airbyte that referenced this pull request Mar 13, 2023
danielduckworth pushed a commit to danielduckworth/airbyte that referenced this pull request Mar 13, 2023
danielduckworth pushed a commit to danielduckworth/airbyte that referenced this pull request Mar 13, 2023
adriennevermorel pushed a commit to adriennevermorel/airbyte that referenced this pull request Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants