Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Property to limit test parallelisation #23870

Merged

Conversation

sergio-ropero
Copy link
Contributor

@sergio-ropero sergio-ropero commented Mar 8, 2023

What

After adding parallelisation in the test pipelines, some of the connectors started to fail (specially the ones that uses shared resource)
PR

How

Both test and integrationTest has been modified to include a property in gradle.properties file in the connector folder so we keep parallelisation by default with maximum threads possible but at the same time we let connector owners to configure the number of threads.
That is really useful for connectors that shares resources and are limited (like Redshift or Snowflake that are limited by number of connections).

To limit the parallelism, is it enough to create gradle.properties file and include this line on it:

numberThreads=X

Where X is the desired parallelisation.

Also, this PR removes the concatenation of test for performance tests, so are not run multiple times.

Example with a println when I had set up 3 threads, now should show 2 threads (removed as we don't want to have prints ):
Screenshot 2023-03-08 at 12 09 42

Recommended reading order

No recommendation

🚨 User Impact 🚨

The users that have issues with the test should create a gradle.properties file with the limitation desired.

Sergio Ropero added 2 commits March 8, 2023 12:37
… in order to reduce parallelization.

It's done by creating a `gradle.properties` file in the connector root folder.

Extra: removes test concatenation for performance tests.
@github-actions
Copy link
Contributor

github-actions bot commented Mar 8, 2023

Affected Connector Report

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to do the following as needed:

  • Run integration tests
  • Bump connector or module version
  • Add changelog
  • Publish the new version

✅ Sources (0)

Connector Version Changelog Publish
  • See "Actionable Items" below for how to resolve warnings and errors.

✅ Destinations (1)

Connector Version Changelog Publish
destination-snowflake 0.4.49
  • See "Actionable Items" below for how to resolve warnings and errors.

👀 Other Modules (1)

  • base-normalization

Actionable Items

(click to expand)

Category Status Actionable Item
Version
mismatch
The version of the connector is different from its normal variant. Please bump the version of the connector.

doc not found
The connector does not seem to have a documentation file. This can be normal (e.g. basic connector like source-jdbc is not published or documented). Please double-check to make sure that it is not a bug.
Changelog
doc not found
The connector does not seem to have a documentation file. This can be normal (e.g. basic connector like source-jdbc is not published or documented). Please double-check to make sure that it is not a bug.

changelog missing
There is no chnagelog for the current version of the connector. If you are the author of the current version, please add a changelog.
Publish
not in seed
The connector is not in the seed file (e.g. source_definitions.yaml), so its publication status cannot be checked. This can be normal (e.g. some connectors are cloud-specific, and only listed in the cloud seed file). Please double-check to make sure that it is not a bug.

diff seed version
The connector exists in the seed file, but the latest version is not listed there. This usually means that the latest version is not published. Please use the /publish command to publish the latest version.

@sergio-ropero
Copy link
Contributor Author

sergio-ropero commented Mar 8, 2023

/test connector=connectors/destination-snowflake

🕑 connectors/destination-snowflake https://github.com/airbytehq/airbyte/actions/runs/4365295476
❌ connectors/destination-snowflake https://github.com/airbytehq/airbyte/actions/runs/4365295476
🐛 https://gradle.com/s/gt46ld7cffvo6

Build Failed

Test summary info:

Could not find result summary

@sergio-ropero
Copy link
Contributor Author

Merging as the errors in the destination-snowflake tests are related to the test itself when it runs in parallel and not because issues in the logging.

@sergio-ropero sergio-ropero merged commit 3db452d into master Mar 8, 2023
@sergio-ropero sergio-ropero deleted the sergio/property-to-limit-integration-test-parallelism branch March 8, 2023 17:48
danielduckworth pushed a commit to danielduckworth/airbyte that referenced this pull request Mar 13, 2023
* Adds new functionality on integration test pipeline and test pipeline in order to reduce parallelization.
It's done by creating a `gradle.properties` file in the connector root folder.

Extra: removes test concatenation for performance tests.

* rename parameter

* fix names

* Reduce threads
adriennevermorel pushed a commit to adriennevermorel/airbyte that referenced this pull request Mar 17, 2023
* Adds new functionality on integration test pipeline and test pipeline in order to reduce parallelization.
It's done by creating a `gradle.properties` file in the connector root folder.

Extra: removes test concatenation for performance tests.

* rename parameter

* fix names

* Reduce threads
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants