🎉 Source ZohoCRM - enable in cloud #23906

midavadim · 2023-03-09T13:12:01Z

Enable in cloud

What

fixed authentication to support latest CDK,
fixed SAT,
updated expected records

How

Describe the solution

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub by running the /publish command described here
After the connector is published, connector added to connector index as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

Connector Generator

Issue acceptance criteria met
PR name follows PR naming conventions
If adding a new generator, add it to the list of scaffold modules being tested
The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
Documentation which references the generator is updated as needed

…ed record, enabled high strictness

CLAassistant · 2023-03-09T13:13:22Z

All committers have signed the CLA.

midavadim · 2023-03-09T13:14:54Z

/test connector=connectors/source-zoho-crm

🕑 connectors/source-zoho-crm https://github.com/airbytehq/airbyte/actions/runs/4374822516
❌ connectors/source-zoho-crm https://github.com/airbytehq/airbyte/actions/runs/4374822516
🐛 https://gradle.com/s/rof3viiwjwj5a

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestConnection::test_check[inputs0] - AssertionError: as...
FAILED test_core.py::TestBasicRead::test_read[inputs0] - docker.errors.Contai...
FAILED test_full_refresh.py::TestFullRefresh::test_sequential_reads[inputs0]
FAILED test_incremental.py::TestIncremental::test_two_sequential_reads[inputs0]
FAILED test_incremental.py::TestIncremental::test_read_sequential_slices[inputs0]
ERROR test_core.py::TestDiscovery::test_defined_cursors_exist_in_schema[inputs0]
ERROR test_core.py::TestDiscovery::test_defined_refs_exist_in_schema[inputs0]
ERROR test_core.py::TestDiscovery::test_backward_compatibility[inputs0] - doc...
ERROR test_incremental.py::TestIncremental::test_state_with_abnormally_large_values[inputs0]
=================== 5 failed, 28 passed, 4 errors in 23.90s ====================

midavadim · 2023-03-09T16:59:27Z

/test connector=connectors/source-zoho-crm

🕑 connectors/source-zoho-crm https://github.com/airbytehq/airbyte/actions/runs/4376876322
❌ connectors/source-zoho-crm https://github.com/airbytehq/airbyte/actions/runs/4376876322
🐛 https://gradle.com/s/e3pqtevoymtqe

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestBasicRead::test_read[inputs0] - docker.errors.Contai...
FAILED test_full_refresh.py::TestFullRefresh::test_sequential_reads[inputs0]
FAILED test_incremental.py::TestIncremental::test_two_sequential_reads[inputs0]
FAILED test_incremental.py::TestIncremental::test_read_sequential_slices[inputs0]
ERROR test_core.py::TestDiscovery::test_backward_compatibility[inputs0] - doc...
ERROR test_incremental.py::TestIncremental::test_state_with_abnormally_large_values[inputs0]
=================== 4 failed, 31 passed, 2 errors in 49.89s ====================

…cloud

midavadim · 2023-03-10T10:38:10Z

/test connector=connectors/source-zoho-crm

🕑 connectors/source-zoho-crm https://github.com/airbytehq/airbyte/actions/runs/4383679153
❌ connectors/source-zoho-crm https://github.com/airbytehq/airbyte/actions/runs/4383679153
🐛 https://gradle.com/s/g2vqxhccgista

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestConnection::test_check[inputs0] - AssertionError: as...
FAILED test_core.py::TestDiscovery::test_discover[inputs0] - docker.errors.Co...
FAILED test_core.py::TestBasicRead::test_read[inputs0] - docker.errors.Contai...
FAILED test_full_refresh.py::TestFullRefresh::test_sequential_reads[inputs0]
FAILED test_incremental.py::TestIncremental::test_two_sequential_reads[inputs0]
FAILED test_incremental.py::TestIncremental::test_read_sequential_slices[inputs0]
ERROR test_core.py::TestDiscovery::test_defined_cursors_exist_in_schema[inputs0]
ERROR test_core.py::TestDiscovery::test_backward_compatibility[inputs0] - doc...
ERROR test_incremental.py::TestIncremental::test_state_with_abnormally_large_values[inputs0]
=================== 6 failed, 28 passed, 3 errors in 20.07s ====================

…enable-on-cloud' into midavadim/23484-source-zoho-crm-enable-on-cloud

midavadim · 2023-03-10T15:41:05Z

/test connector=connectors/source-zoho-crm

🕑 connectors/source-zoho-crm https://github.com/airbytehq/airbyte/actions/runs/4386091840
❌ connectors/source-zoho-crm https://github.com/airbytehq/airbyte/actions/runs/4386091840
🐛 https://gradle.com/s/zcgitlfjon5gk

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestBasicRead::test_read[inputs0] - docker.errors.Contai...
FAILED test_incremental.py::TestIncremental::test_two_sequential_reads[inputs0]
FAILED test_incremental.py::TestIncremental::test_read_sequential_slices[inputs0]
FAILED test_incremental.py::TestIncremental::test_state_with_abnormally_large_values[inputs0]
ERROR test_core.py::TestDiscovery::test_defined_cursors_exist_in_schema[inputs0]
ERROR test_core.py::TestDiscovery::test_backward_compatibility[inputs0] - doc...
============== 4 failed, 31 passed, 2 errors in 62.61s (0:01:02) ===============

…cloud

…enable-on-cloud' into midavadim/23484-source-zoho-crm-enable-on-cloud

midavadim · 2023-03-10T16:02:08Z

/test connector=connectors/source-zoho-crm

🕑 connectors/source-zoho-crm https://github.com/airbytehq/airbyte/actions/runs/4386253311
✅ connectors/source-zoho-crm https://github.com/airbytehq/airbyte/actions/runs/4386253311
Python tests coverage:

Name                            Stmts   Miss  Cover
---------------------------------------------------
source_zoho_crm/exceptions.py       4      0   100%
source_zoho_crm/__init__.py         2      0   100%
source_zoho_crm/types.py          166      7    96%
source_zoho_crm/api.py             54      4    93%
source_zoho_crm/auth.py            17      2    88%
source_zoho_crm/source.py          14      5    64%
source_zoho_crm/streams.py        109     43    61%
---------------------------------------------------
TOTAL                             366     61    83%
Name                            Stmts   Miss  Cover
---------------------------------------------------
source_zoho_crm/exceptions.py       4      0   100%
source_zoho_crm/__init__.py         2      0   100%
source_zoho_crm/types.py          166      4    98%
source_zoho_crm/auth.py            17      2    88%
source_zoho_crm/api.py             54      8    85%
source_zoho_crm/streams.py        109     27    75%
source_zoho_crm/source.py          14      5    64%
---------------------------------------------------
TOTAL                             366     46    87%

Build Passed

Test summary info:

All Passed

midavadim · 2023-03-10T19:51:53Z

@YowanR
This connector is not eligible for low code becuase

it has dynamic schemas
current implementation support multithreading
@lazebnyi

YowanR · 2023-03-15T00:46:02Z

@midavadim Let's just enable it in Cloud without certifying to Beta, please 🙏

bnchrch · 2023-03-16T18:06:33Z

Hey @midavadim would you be able to resolve the conflicts? Then im happy to review :)

…cloud # Conflicts: # airbyte-integrations/connectors/source-zoho-crm/Dockerfile # airbyte-integrations/connectors/source-zoho-crm/acceptance-test-config.yml # airbyte-integrations/connectors/source-zoho-crm/setup.py # airbyte-integrations/connectors/source-zoho-crm/source_zoho_crm/auth.py # airbyte-integrations/connectors/source-zoho-crm/source_zoho_crm/spec.json # docs/integrations/sources/zoho-crm.md

midavadim · 2023-03-16T21:30:08Z

/test connector=connectors/source-zoho-crm

🕑 connectors/source-zoho-crm https://github.com/airbytehq/airbyte/actions/runs/4441816580
❌ connectors/source-zoho-crm https://github.com/airbytehq/airbyte/actions/runs/4441816580
🐛 https://gradle.com/s/7hje5swpwzxcc

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestConnection::test_check[inputs0] - AssertionError: as...
FAILED test_core.py::TestDiscovery::test_discover[inputs0] - docker.errors.Co...
FAILED test_core.py::TestDiscovery::test_backward_compatibility[inputs0] - As...
FAILED test_core.py::TestBasicRead::test_read[inputs0] - docker.errors.Contai...
FAILED test_incremental.py::TestIncremental::test_two_sequential_reads[inputs0]
FAILED test_incremental.py::TestIncremental::test_read_sequential_slices[inputs0]
FAILED test_incremental.py::TestIncremental::test_state_with_abnormally_large_values[inputs0]
ERROR test_core.py::TestDiscovery::test_defined_cursors_exist_in_schema[inputs0]
ERROR test_core.py::TestDiscovery::test_defined_refs_exist_in_schema[inputs0]
=================== 7 failed, 28 passed, 2 errors in 50.68s ====================

…cloud

midavadim · 2023-03-16T21:52:10Z

/test connector=connectors/source-zoho-crm

🕑 connectors/source-zoho-crm https://github.com/airbytehq/airbyte/actions/runs/4441962090
✅ connectors/source-zoho-crm https://github.com/airbytehq/airbyte/actions/runs/4441962090
Python tests coverage:

Name                            Stmts   Miss  Cover
---------------------------------------------------
source_zoho_crm/exceptions.py       4      0   100%
source_zoho_crm/__init__.py         2      0   100%
source_zoho_crm/types.py          179     10    94%
source_zoho_crm/api.py             54      4    93%
source_zoho_crm/auth.py            17      2    88%
source_zoho_crm/source.py          14      5    64%
source_zoho_crm/streams.py        109     43    61%
---------------------------------------------------
TOTAL                             379     64    83%
Name                            Stmts   Miss  Cover
---------------------------------------------------
source_zoho_crm/exceptions.py       4      0   100%
source_zoho_crm/__init__.py         2      0   100%
source_zoho_crm/types.py          179      7    96%
source_zoho_crm/auth.py            17      2    88%
source_zoho_crm/api.py             54      8    85%
source_zoho_crm/streams.py        109     27    75%
source_zoho_crm/source.py          14      5    64%
---------------------------------------------------
TOTAL                             379     49    87%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:509: The previous and actual discovered catalogs are identical.
================== 36 passed, 1 skipped in 237.34s (0:03:57) ===================

midavadim · 2023-03-16T22:03:20Z

Hey @midavadim would you be able to resolve the conflicts? Then im happy to review :)

I have updated this PR again

bnchrch

CAT passing, unit tests passing, incremental streams have source defined cursors.

Looks good to me! 👍

…cloud

midavadim · 2023-03-17T16:40:05Z

/publish connector=connectors/source-zoho-crm

🕑 Publishing the following connectors:
connectors/source-zoho-crm
https://github.com/airbytehq/airbyte/actions/runs/4449676917

Connector	Did it publish?	Were definitions generated?
connectors/source-zoho-crm	❌	❌

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

midavadim · 2023-03-17T16:57:39Z

/test connector=connectors/source-zoho-crm

🕑 connectors/source-zoho-crm https://github.com/airbytehq/airbyte/actions/runs/4449815172
❌ connectors/source-zoho-crm https://github.com/airbytehq/airbyte/actions/runs/4449815172
🐛 https://gradle.com/s/ih23atredbtle

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestConnection::test_check[inputs0] - AssertionError: as...
FAILED test_core.py::TestDiscovery::test_discover[inputs0] - docker.errors.Co...
ERROR test_core.py::TestDiscovery::test_defined_cursors_exist_in_schema[inputs0]
ERROR test_core.py::TestDiscovery::test_defined_refs_exist_in_schema[inputs0]
ERROR test_core.py::TestDiscovery::test_defined_keyword_exist_in_schema[inputs0-allOf]
ERROR test_core.py::TestDiscovery::test_defined_keyword_exist_in_schema[inputs0-not]
ERROR test_core.py::TestDiscovery::test_primary_keys_exist_in_schema[inputs0]
ERROR test_core.py::TestDiscovery::test_streams_has_sync_modes[inputs0] - doc...
ERROR test_core.py::TestDiscovery::test_additional_properties_is_true[inputs0]
ERROR test_core.py::TestDiscovery::test_backward_compatibility[inputs0] - doc...
ERROR test_core.py::TestBasicRead::test_read[inputs0] - docker.errors.Contain...
ERROR test_full_refresh.py::TestFullRefresh::test_sequential_reads[inputs0]
ERROR test_incremental.py::TestIncremental::test_two_sequential_reads[inputs0]
ERROR test_incremental.py::TestIncremental::test_read_sequential_slices[inputs0]
ERROR test_incremental.py::TestIncremental::test_state_with_abnormally_large_values[inputs0]
=================== 2 failed, 22 passed, 13 errors in 23.57s ===================

…cloud

…enable-on-cloud' into midavadim/23484-source-zoho-crm-enable-on-cloud

midavadim · 2023-03-17T17:20:23Z

/test connector=connectors/source-zoho-crm

🕑 connectors/source-zoho-crm https://github.com/airbytehq/airbyte/actions/runs/4450009346
❌ connectors/source-zoho-crm https://github.com/airbytehq/airbyte/actions/runs/4450009346
🐛 https://gradle.com/s/ewbpyd7zrwloi

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestConnection::test_check[inputs0] - AssertionError: as...
FAILED test_core.py::TestDiscovery::test_discover[inputs0] - docker.errors.Co...
ERROR test_core.py::TestDiscovery::test_defined_cursors_exist_in_schema[inputs0]
ERROR test_core.py::TestDiscovery::test_defined_refs_exist_in_schema[inputs0]
ERROR test_core.py::TestDiscovery::test_defined_keyword_exist_in_schema[inputs0-allOf]
ERROR test_core.py::TestDiscovery::test_defined_keyword_exist_in_schema[inputs0-not]
ERROR test_core.py::TestDiscovery::test_primary_keys_exist_in_schema[inputs0]
ERROR test_core.py::TestDiscovery::test_streams_has_sync_modes[inputs0] - doc...
ERROR test_core.py::TestDiscovery::test_additional_properties_is_true[inputs0]
ERROR test_core.py::TestDiscovery::test_backward_compatibility[inputs0] - doc...
ERROR test_core.py::TestBasicRead::test_read[inputs0] - docker.errors.Contain...
ERROR test_full_refresh.py::TestFullRefresh::test_sequential_reads[inputs0]
ERROR test_incremental.py::TestIncremental::test_two_sequential_reads[inputs0]
ERROR test_incremental.py::TestIncremental::test_read_sequential_slices[inputs0]
ERROR test_incremental.py::TestIncremental::test_state_with_abnormally_large_values[inputs0]
=================== 2 failed, 22 passed, 13 errors in 23.21s ===================

YowanR · 2023-03-17T19:40:08Z

This PR looks good, right? Can we add the ready to ship label?

…cloud

midavadim · 2023-03-19T14:15:02Z

/test connector=connectors/source-zoho-crm

🕑 connectors/source-zoho-crm https://github.com/airbytehq/airbyte/actions/runs/4461120614
❌ connectors/source-zoho-crm https://github.com/airbytehq/airbyte/actions/runs/4461120614
🐛 https://gradle.com/s/n54b7a7muqpzi

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestConnection::test_check[inputs0] - AssertionError: as...
FAILED test_core.py::TestDiscovery::test_discover[inputs0] - docker.errors.Co...
ERROR test_core.py::TestDiscovery::test_defined_cursors_exist_in_schema[inputs0]
ERROR test_core.py::TestDiscovery::test_defined_refs_exist_in_schema[inputs0]
ERROR test_core.py::TestDiscovery::test_defined_keyword_exist_in_schema[inputs0-allOf]
ERROR test_core.py::TestDiscovery::test_defined_keyword_exist_in_schema[inputs0-not]
ERROR test_core.py::TestDiscovery::test_primary_keys_exist_in_schema[inputs0]
ERROR test_core.py::TestDiscovery::test_streams_has_sync_modes[inputs0] - doc...
ERROR test_core.py::TestDiscovery::test_additional_properties_is_true[inputs0]
ERROR test_core.py::TestDiscovery::test_backward_compatibility[inputs0] - doc...
ERROR test_core.py::TestBasicRead::test_read[inputs0] - docker.errors.Contain...
ERROR test_full_refresh.py::TestFullRefresh::test_sequential_reads[inputs0]
ERROR test_incremental.py::TestIncremental::test_two_sequential_reads[inputs0]
ERROR test_incremental.py::TestIncremental::test_read_sequential_slices[inputs0]
ERROR test_incremental.py::TestIncremental::test_state_with_abnormally_large_values[inputs0]
=================== 2 failed, 22 passed, 13 errors in 23.28s ===================

midavadim · 2023-03-19T14:41:19Z

/test connector=connectors/source-zoho-crm

🕑 connectors/source-zoho-crm https://github.com/airbytehq/airbyte/actions/runs/4461228467
❌ connectors/source-zoho-crm https://github.com/airbytehq/airbyte/actions/runs/4461228467
🐛 https://gradle.com/s/aoc7bwfs55fsk

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestDiscovery::test_discover[inputs0] - docker.errors.Co...
FAILED test_core.py::TestDiscovery::test_backward_compatibility[inputs0] - As...
FAILED test_full_refresh.py::TestFullRefresh::test_sequential_reads[inputs0]
FAILED test_incremental.py::TestIncremental::test_two_sequential_reads[inputs0]
FAILED test_incremental.py::TestIncremental::test_read_sequential_slices[inputs0]
FAILED test_incremental.py::TestIncremental::test_state_with_abnormally_large_values[inputs0]
ERROR test_core.py::TestBasicRead::test_read[inputs0] - Failed: High strictne...
==================== 6 failed, 30 passed, 1 error in 22.74s ====================

midavadim · 2023-03-19T15:05:26Z

/test connector=connectors/source-zoho-crm

🕑 connectors/source-zoho-crm https://github.com/airbytehq/airbyte/actions/runs/4461315705
❌ connectors/source-zoho-crm https://github.com/airbytehq/airbyte/actions/runs/4461315705
🐛 https://gradle.com/s/ql5ajfkwjrvmi

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestConnection::test_check[inputs0] - AssertionError: as...
FAILED test_core.py::TestDiscovery::test_discover[inputs0] - docker.errors.Co...
FAILED test_core.py::TestDiscovery::test_backward_compatibility[inputs0] - As...
FAILED test_full_refresh.py::TestFullRefresh::test_sequential_reads[inputs0]
FAILED test_incremental.py::TestIncremental::test_two_sequential_reads[inputs0]
FAILED test_incremental.py::TestIncremental::test_read_sequential_slices[inputs0]
FAILED test_incremental.py::TestIncremental::test_state_with_abnormally_large_values[inputs0]
ERROR test_core.py::TestDiscovery::test_defined_cursors_exist_in_schema[inputs0]
=============== 7 failed, 29 passed, 1 error in 70.13s (0:01:10) ===============

midavadim · 2023-03-19T19:37:13Z

/test connector=connectors/source-zoho-crm

🕑 connectors/source-zoho-crm https://github.com/airbytehq/airbyte/actions/runs/4462361939
✅ connectors/source-zoho-crm https://github.com/airbytehq/airbyte/actions/runs/4462361939
Python tests coverage:

Name                            Stmts   Miss  Cover
---------------------------------------------------
source_zoho_crm/exceptions.py       4      0   100%
source_zoho_crm/__init__.py         2      0   100%
source_zoho_crm/types.py          179     10    94%
source_zoho_crm/api.py             54      4    93%
source_zoho_crm/auth.py            17      2    88%
source_zoho_crm/source.py          14      5    64%
source_zoho_crm/streams.py        109     43    61%
---------------------------------------------------
TOTAL                             379     64    83%
Name                            Stmts   Miss  Cover
---------------------------------------------------
source_zoho_crm/exceptions.py       4      0   100%
source_zoho_crm/__init__.py         2      0   100%
source_zoho_crm/types.py          179      7    96%
source_zoho_crm/auth.py            17      2    88%
source_zoho_crm/api.py             54      8    85%
source_zoho_crm/streams.py        109     27    75%
source_zoho_crm/source.py          14      5    64%
---------------------------------------------------
TOTAL                             379     49    87%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:509: The previous and actual discovered catalogs are identical.
================== 36 passed, 1 skipped in 229.84s (0:03:49) ===================

midavadim · 2023-03-19T19:57:33Z

/pblish connector=connectors/source-zoho-crm

midavadim · 2023-03-19T20:43:04Z

/publish connector=connectors/source-zoho-crm

🕑 Publishing the following connectors:
connectors/source-zoho-crm
https://github.com/airbytehq/airbyte/actions/runs/4462607877

Connector	Did it publish?	Were definitions generated?
connectors/source-zoho-crm	✅	✅

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

YowanR · 2023-03-21T00:30:54Z

This PR was merged but the connector is not on Cloud at the moment. Can you look into this @midavadim @lazebnyi ?

* Fixed authentication to support latest CDK, fixed SAT, updated expected record, enabled high strictness * updated docs and connector version * updated format of abnormal state * updated version is seed * merged * updated connector version * fixed SAT * fixed SAT * added empty streams * auto-bump connector version --------- Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>

Fixed authentication to support latest CDK, fixed SAT, updated expect…

4e43120

…ed record, enabled high strictness

octavia-squidington-iii added area/connectors Connector related issues connectors/source/zoho-crm labels Mar 9, 2023

midavadim linked an issue Mar 9, 2023 that may be closed by this pull request

Source ZohoCRM: Enable in Cloud #23484

Closed

midavadim requested a review from lazebnyi March 9, 2023 13:16

updated docs and connector version

87462ad

octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Mar 9, 2023

midavadim added 2 commits March 9, 2023 19:33

Merge branch 'master' into midavadim/23484-source-zoho-crm-enable-on-…

7562861

…cloud

Merge branch 'master' into midavadim/23484-source-zoho-crm-enable-on-…

b28cc25

…cloud

midavadim added 2 commits March 10, 2023 17:38

updated format of abnormal state

1c6dce7

Merge remote-tracking branch 'origin/midavadim/23484-source-zoho-crm-…

2405ce5

…enable-on-cloud' into midavadim/23484-source-zoho-crm-enable-on-cloud

midavadim added 3 commits March 10, 2023 17:41

Merge branch 'master' into midavadim/23484-source-zoho-crm-enable-on-…

d7eadfb

…cloud

Merge branch 'master' into midavadim/23484-source-zoho-crm-enable-on-…

edef8a0

…cloud

Merge remote-tracking branch 'origin/midavadim/23484-source-zoho-crm-…

fd2f594

…enable-on-cloud' into midavadim/23484-source-zoho-crm-enable-on-cloud

updated version is seed

3a239f5

lazebnyi approved these changes Mar 10, 2023

View reviewed changes

midavadim requested a review from brianjlai March 10, 2023 19:49

midavadim requested a review from erohmensing March 15, 2023 14:09

bnchrch requested review from bnchrch and removed request for erohmensing March 15, 2023 16:31

Merge branch 'master' into midavadim/23484-source-zoho-crm-enable-on-…

ac7c3b3

…cloud

bnchrch approved these changes Mar 17, 2023

View reviewed changes

Merge branch 'master' into midavadim/23484-source-zoho-crm-enable-on-…

e790297

…cloud

midavadim added 3 commits March 17, 2023 19:02

Merge branch 'master' into midavadim/23484-source-zoho-crm-enable-on-…

4e3fc33

…cloud

Merge branch 'master' into midavadim/23484-source-zoho-crm-enable-on-…

a3aa641

…cloud

Merge remote-tracking branch 'origin/midavadim/23484-source-zoho-crm-…

582a54e

…enable-on-cloud' into midavadim/23484-source-zoho-crm-enable-on-cloud

midavadim added 2 commits March 19, 2023 15:32

Merge branch 'master' into midavadim/23484-source-zoho-crm-enable-on-…

4432d32

…cloud

fixed SAT

a379728

added empty streams

bf9caa8

auto-bump connector version

b5de35f

midavadim merged commit f2ba087 into master Mar 19, 2023

midavadim deleted the midavadim/23484-source-zoho-crm-enable-on-cloud branch March 19, 2023 21:24

midavadim added the ready-to-ship label Mar 20, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🎉 Source ZohoCRM - enable in cloud #23906

🎉 Source ZohoCRM - enable in cloud #23906

midavadim commented Mar 9, 2023

CLAassistant commented Mar 9, 2023 •

edited

Loading

midavadim commented Mar 9, 2023 •

edited by github-actions bot

Loading

midavadim commented Mar 9, 2023 •

edited by github-actions bot

Loading

midavadim commented Mar 10, 2023 •

edited by github-actions bot

Loading

midavadim commented Mar 10, 2023 •

edited by github-actions bot

Loading

midavadim commented Mar 10, 2023 •

edited by github-actions bot

Loading

midavadim commented Mar 10, 2023

YowanR commented Mar 15, 2023

bnchrch commented Mar 16, 2023

midavadim commented Mar 16, 2023 •

edited by github-actions bot

Loading

midavadim commented Mar 16, 2023 •

edited by github-actions bot

Loading

midavadim commented Mar 16, 2023

bnchrch left a comment

midavadim commented Mar 17, 2023 •

edited by github-actions bot

Loading

midavadim commented Mar 17, 2023 •

edited by github-actions bot

Loading

midavadim commented Mar 17, 2023 •

edited by github-actions bot

Loading

YowanR commented Mar 17, 2023 •

edited

Loading

midavadim commented Mar 19, 2023 •

edited by github-actions bot

Loading

midavadim commented Mar 19, 2023 •

edited by github-actions bot

Loading

midavadim commented Mar 19, 2023 •

edited by github-actions bot

Loading

midavadim commented Mar 19, 2023 •

edited by github-actions bot

Loading

midavadim commented Mar 19, 2023

midavadim commented Mar 19, 2023 •

edited by github-actions bot

Loading

YowanR commented Mar 21, 2023

🎉 Source ZohoCRM - enable in cloud #23906

🎉 Source ZohoCRM - enable in cloud #23906

Conversation

midavadim commented Mar 9, 2023

What

How

Recommended reading order

🚨 User Impact 🚨

Pre-merge Checklist

Community member or Airbyter

Airbyter

Community member or Airbyter

Airbyter

CLAassistant commented Mar 9, 2023 • edited Loading

midavadim commented Mar 9, 2023 • edited by github-actions bot Loading

Build Failed

midavadim commented Mar 9, 2023 • edited by github-actions bot Loading

Build Failed

midavadim commented Mar 10, 2023 • edited by github-actions bot Loading

Build Failed

midavadim commented Mar 10, 2023 • edited by github-actions bot Loading

Build Failed

midavadim commented Mar 10, 2023 • edited by github-actions bot Loading

Build Passed

midavadim commented Mar 10, 2023

YowanR commented Mar 15, 2023

bnchrch commented Mar 16, 2023

midavadim commented Mar 16, 2023 • edited by github-actions bot Loading

Build Failed

midavadim commented Mar 16, 2023 • edited by github-actions bot Loading

Build Passed

midavadim commented Mar 16, 2023

bnchrch left a comment

Choose a reason for hiding this comment

midavadim commented Mar 17, 2023 • edited by github-actions bot Loading

midavadim commented Mar 17, 2023 • edited by github-actions bot Loading

Build Failed

midavadim commented Mar 17, 2023 • edited by github-actions bot Loading

Build Failed

YowanR commented Mar 17, 2023 • edited Loading

midavadim commented Mar 19, 2023 • edited by github-actions bot Loading

Build Failed

midavadim commented Mar 19, 2023 • edited by github-actions bot Loading

Build Failed

midavadim commented Mar 19, 2023 • edited by github-actions bot Loading

Build Failed

midavadim commented Mar 19, 2023 • edited by github-actions bot Loading

Build Passed

midavadim commented Mar 19, 2023

midavadim commented Mar 19, 2023 • edited by github-actions bot Loading

YowanR commented Mar 21, 2023

CLAassistant commented Mar 9, 2023 •

edited

Loading

midavadim commented Mar 9, 2023 •

edited by github-actions bot

Loading

midavadim commented Mar 9, 2023 •

edited by github-actions bot

Loading

midavadim commented Mar 10, 2023 •

edited by github-actions bot

Loading

midavadim commented Mar 10, 2023 •

edited by github-actions bot

Loading

midavadim commented Mar 10, 2023 •

edited by github-actions bot

Loading

midavadim commented Mar 16, 2023 •

edited by github-actions bot

Loading

midavadim commented Mar 16, 2023 •

edited by github-actions bot

Loading

midavadim commented Mar 17, 2023 •

edited by github-actions bot

Loading

midavadim commented Mar 17, 2023 •

edited by github-actions bot

Loading

midavadim commented Mar 17, 2023 •

edited by github-actions bot

Loading

YowanR commented Mar 17, 2023 •

edited

Loading

midavadim commented Mar 19, 2023 •

edited by github-actions bot

Loading

midavadim commented Mar 19, 2023 •

edited by github-actions bot

Loading

midavadim commented Mar 19, 2023 •

edited by github-actions bot

Loading

midavadim commented Mar 19, 2023 •

edited by github-actions bot

Loading

midavadim commented Mar 19, 2023 •

edited by github-actions bot

Loading