Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🎉 Support FB Marketing API v10 #2391

Merged
merged 2 commits into from
Mar 12, 2021
Merged

🎉 Support FB Marketing API v10 #2391

merged 2 commits into from
Mar 12, 2021

Conversation

yevhenii-ldv
Copy link
Contributor

What

update facebook_business version to 10.0.0 with Graph API v10.

Pre-merge Checklist

  • Run integration tests
  • Publish Docker images

Recommended reading order

  1. test.java
  2. component.ts
  3. the rest

@yevhenii-ldv
Copy link
Contributor Author

yevhenii-ldv commented Mar 10, 2021 •
edited by github-actions bot
Loading

/test connector=source-facebook-marketing

🕑 source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/639251780
✅ source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/639251780

vitaliizazmic
vitaliizazmic approved these changes Mar 10, 2021
View reviewed changes
Copy link
Contributor

@vitaliizazmic vitaliizazmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sherifnada
sherifnada approved these changes Mar 10, 2021
View reviewed changes
Copy link
Contributor

@sherifnada sherifnada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- publish at will

@sherifnada sherifnada changed the title #2230 Issue: Support FB Marketing API v10 🎉 Support FB Marketing API v10 Mar 10, 2021
@keu keu linked an issue Mar 12, 2021 that may be closed by this pull request
Support FB Marketing API v10 #2230
Closed
@keu keu merged commit 2a4c1e3 into master Mar 12, 2021
@keu keu deleted the ykurochkin/support-fb-marketing-api-v10 branch March 12, 2021 11:00
@keu
Copy link
Contributor

keu commented Mar 12, 2021 •
edited by github-actions bot
Loading

/publish connectors/source-facebook-marketing

Error: No ref found for: ykurochkin/support-fb-marketing-api-v10

@sherifnada
Copy link
Contributor

@eugene-kulak restore branch and publish should work

@keu
Copy link
Contributor

keu commented Mar 12, 2021

oh, my bad

@keu
Copy link
Contributor

keu commented Mar 12, 2021 •
edited by github-actions bot
Loading

/publish connectors/source-facebook-marketing

Error: Required input 'connector' not provided

@keu
Copy link
Contributor

keu commented Mar 12, 2021 •
edited by github-actions bot
Loading

/publish connector=connectors/source-facebook-marketing

🕑 connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/647018010
✅ connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/647018010

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sherifnada sherifnada sherifnada approved these changes

@vitaliizazmic vitaliizazmic vitaliizazmic approved these changes

Assignees
No one assigned
Labels
connectors/source/facebook-marketing connectors/sources-api
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support FB Marketing API v10
5 participants
@yevhenii-ldv @keu @sherifnada @vitaliizazmic @karinakuz