Source Salesloft: certify to beta #23937

davydov-d · 2023-03-10T17:12:58Z

What

#19217

How

update docs
unit test coverage -> 99%
integration test strictness level -> high
add auth by api key
update stream schemas
add incremental sync support to more streams
add allowed hosts

…19217-source-salesloft-certify-to-beta

davydov-d · 2023-03-10T17:20:34Z

/test connector=connectors/source-salesloft

🕑 connectors/source-salesloft https://github.com/airbytehq/airbyte/actions/runs/4386886353
❌ connectors/source-salesloft https://github.com/airbytehq/airbyte/actions/runs/4386886353
🐛 https://gradle.com/s/cv4wulrejmmzs

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestBasicRead::test_read[inputs0] - Failed: Stream users...
FAILED test_core.py::TestBasicRead::test_read[inputs1] - Failed: Stream users...
ERROR test_core.py::TestDiscovery::test_backward_compatibility[inputs0] - doc...
ERROR test_core.py::TestDiscovery::test_backward_compatibility[inputs1] - doc...
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:109: Backward compatibility tests are disabled for version 0.1.6.
======== 2 failed, 44 passed, 1 skipped, 2 errors in 156.77s (0:02:36) =========

davydov-d · 2023-03-10T17:21:13Z

/test connector=connectors/source-salesloft

☝️ 2 tests will fail because of #23681

davydov-d · 2023-03-10T18:11:15Z

/test connector=connectors/source-salesloft

davydov-d · 2023-03-10T20:16:23Z

/test connector=connectors/source-salesloft

🕑 connectors/source-salesloft https://github.com/airbytehq/airbyte/actions/runs/4388124116
❌ connectors/source-salesloft https://github.com/airbytehq/airbyte/actions/runs/4388124116
🐛 https://gradle.com/s/lfmyrq3cjrmdm

Build Failed

Test summary info:

=========================== short test summary info ============================
ERROR test_core.py::TestDiscovery::test_backward_compatibility[inputs0] - doc...
ERROR test_core.py::TestDiscovery::test_backward_compatibility[inputs1] - doc...
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:109: Backward compatibility tests are disabled for version 0.1.6.
============= 46 passed, 1 skipped, 2 errors in 154.81s (0:02:34) ==============

bazarnov

LGTM for code changes, tests are failing on backward compatibility checks, make sure this is covered, otherwise - ok.

…o-beta

davydov-d · 2023-03-14T10:24:24Z

/test connector=connectors/source-salesloft

🕑 connectors/source-salesloft https://github.com/airbytehq/airbyte/actions/runs/4414663336
❌ connectors/source-salesloft https://github.com/airbytehq/airbyte/actions/runs/4414663336
🐛 https://gradle.com/s/sb7b5pldigwce

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestBasicRead::test_read[inputs0] - Failed: Stream peopl...
FAILED test_core.py::TestBasicRead::test_read[inputs1] - Failed: Stream peopl...
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:109: Backward compatibility tests are disabled for version 0.1.6.
SKIPPED [2] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:518: Backward compatibility tests are disabled for version 0.1.6.
============= 2 failed, 44 passed, 3 skipped in 155.60s (0:02:35) ==============

…thub.com:airbytehq/airbyte into ddavydov/#19217-source-salesloft-certify-to-beta

davydov-d · 2023-03-15T08:47:59Z

/test connector=connectors/source-salesloft

🕑 connectors/source-salesloft https://github.com/airbytehq/airbyte/actions/runs/4424401578
❌ connectors/source-salesloft https://github.com/airbytehq/airbyte/actions/runs/4424401578
🐛 https://gradle.com/s/dyjz2v3gdspbc

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestBasicRead::test_read[inputs0] - Failed: Stream users...
FAILED test_core.py::TestBasicRead::test_read[inputs1] - Failed: Stream users...
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:109: Backward compatibility tests are disabled for version 0.1.6.
SKIPPED [2] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:518: Backward compatibility tests are disabled for version 0.1.6.
============= 2 failed, 44 passed, 3 skipped in 158.32s (0:02:38) ==============

davydov-d · 2023-03-15T09:26:01Z

/test connector=connectors/source-salesloft

🕑 connectors/source-salesloft https://github.com/airbytehq/airbyte/actions/runs/4424731472
✅ connectors/source-salesloft https://github.com/airbytehq/airbyte/actions/runs/4424731472
Python tests coverage:

Name                           Stmts   Miss  Cover
--------------------------------------------------
source_salesloft/__init__.py       2      0   100%
source_salesloft/source.py       158      2    99%
--------------------------------------------------
TOTAL                            160      2    99%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:109: Backward compatibility tests are disabled for version 0.1.6.
SKIPPED [2] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:518: Backward compatibility tests are disabled for version 0.1.6.
================== 46 passed, 3 skipped in 160.36s (0:02:40) ===================

davydov-d · 2023-03-15T12:41:56Z

/test connector=connectors/source-salesloft

🕑 connectors/source-salesloft https://github.com/airbytehq/airbyte/actions/runs/4426402128
❌ connectors/source-salesloft https://github.com/airbytehq/airbyte/actions/runs/4426402128
🐛 https://gradle.com/s/7g6l7rcjrnj36

Build Failed

Test summary info:

Could not find result summary

…o-beta

davydov-d · 2023-03-15T13:05:36Z

/test connector=connectors/source-salesloft

🕑 connectors/source-salesloft https://github.com/airbytehq/airbyte/actions/runs/4426622685
✅ connectors/source-salesloft https://github.com/airbytehq/airbyte/actions/runs/4426622685
Python tests coverage:

Name                           Stmts   Miss  Cover
--------------------------------------------------
source_salesloft/__init__.py       2      0   100%
source_salesloft/source.py       158      2    99%
--------------------------------------------------
TOTAL                            160      2    99%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:109: Backward compatibility tests are disabled for version 0.1.6.
SKIPPED [2] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:518: Backward compatibility tests are disabled for version 0.1.6.
================== 46 passed, 3 skipped in 163.60s (0:02:43) ===================

bnchrch

Nothing stood out to me here.

good cursors
Good primary keys
Great testing and documentation
It likely is a breaking change but thats ok as its an alpha connector

bnchrch · 2023-03-15T21:19:18Z

airbyte-config/init/src/main/resources/seed/source_definitions.yaml

@@ -1727,6 +1727,9 @@
  icon: salesloft.svg
  sourceType: api
  releaseStage: alpha
+  allowedHosts:


…o-beta

davydov-d · 2023-03-16T08:52:08Z

/publish connector=connectors/source-salesloft

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

davydov-d · 2023-03-16T08:55:25Z

/publish connector=connectors/source-salesloft

🕑 Publishing the following connectors:
connectors/source-salesloft
https://github.com/airbytehq/airbyte/actions/runs/4435213991

Connector	Did it publish?	Were definitions generated?
connectors/source-salesloft	✅	✅

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

* airbytehq#19217 Source Salesloft: certify to beta * airbytehq#19217 source salesloft: update docs * airbytehq#19217 source salesloft: upd changelog * airbytehq#19217 source salesloft: upd expected records * airbytehq#19217 source salesloft: upd expected records * airbytehq#19217 source salesloft: upd expected records * airbytehq#19217 source salesloft: upd CAT config * airbytehq#19217 source salesloft: fix CAT config * airbytehq#19217 source salesloft: remove advanced_oauth * Automated Change * auto-bump connector version --------- Co-authored-by: davydov-d <davydov-d@users.noreply.github.com> Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>

* #19217 Source Salesloft: certify to beta * #19217 source salesloft: update docs * #19217 source salesloft: upd changelog * #19217 source salesloft: upd expected records * #19217 source salesloft: upd expected records * #19217 source salesloft: upd expected records * #19217 source salesloft: upd CAT config * #19217 source salesloft: fix CAT config * #19217 source salesloft: remove advanced_oauth * Automated Change * auto-bump connector version --------- Co-authored-by: davydov-d <davydov-d@users.noreply.github.com> Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>

davydov-d added 3 commits March 9, 2023 09:42

#19217 Source Salesloft: certify to beta

82f3ec4

Merge branch 'master' of github.com:airbytehq/airbyte into ddavydov/#…

3d623c6

…19217-source-salesloft-certify-to-beta

#19217 source salesloft: update docs

4773fa5

octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/salesloft labels Mar 10, 2023

#19217 source salesloft: upd changelog

e465d95

davydov-d requested review from bazarnov, brianjlai and lazebnyi March 10, 2023 17:21

#19217 source salesloft: upd expected records

8bba849

bazarnov approved these changes Mar 11, 2023

View reviewed changes

davydov-d requested review from a team March 13, 2023 06:57

lazebnyi approved these changes Mar 13, 2023

View reviewed changes

Merge branch 'master' into ddavydov/#19217-source-salesloft-certify-t…

c5ad614

…o-beta

davydov-d added 2 commits March 15, 2023 10:47

#19217 source salesloft: upd expected records

72b4154

Merge branch 'ddavydov/#19217-source-salesloft-certify-to-beta' of gi…

7bf6565

…thub.com:airbytehq/airbyte into ddavydov/#19217-source-salesloft-certify-to-beta

#19217 source salesloft: upd expected records

15019d4

#19217 source salesloft: upd CAT config

6a8448e

davydov-d added 2 commits March 15, 2023 15:01

Merge branch 'master' into ddavydov/#19217-source-salesloft-certify-t…

06e4268

…o-beta

#19217 source salesloft: fix CAT config

a07c50b

bnchrch self-requested a review March 15, 2023 16:33

bnchrch approved these changes Mar 15, 2023

View reviewed changes

davydov-d and others added 3 commits March 16, 2023 10:04

Merge branch 'master' into ddavydov/#19217-source-salesloft-certify-t…

2f47bd6

…o-beta

#19217 source salesloft: remove advanced_oauth

b7efa60

Automated Change

2e459e2

auto-bump connector version

5f0ff1b

davydov-d merged commit d534751 into master Mar 16, 2023

davydov-d deleted the ddavydov/#19217-source-salesloft-certify-to-beta branch March 16, 2023 10:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Source Salesloft: certify to beta #23937

Source Salesloft: certify to beta #23937

davydov-d commented Mar 10, 2023 •

edited

Loading

davydov-d commented Mar 10, 2023 •

edited by github-actions bot

Loading

davydov-d commented Mar 10, 2023

davydov-d commented Mar 10, 2023

davydov-d commented Mar 10, 2023 •

edited by github-actions bot

Loading

bazarnov left a comment

davydov-d commented Mar 14, 2023 •

edited by github-actions bot

Loading

davydov-d commented Mar 15, 2023 •

edited by github-actions bot

Loading

davydov-d commented Mar 15, 2023 •

edited by github-actions bot

Loading

davydov-d commented Mar 15, 2023 •

edited by github-actions bot

Loading

davydov-d commented Mar 15, 2023 •

edited by github-actions bot

Loading

bnchrch left a comment

bnchrch Mar 15, 2023

davydov-d commented Mar 16, 2023 •

edited by github-actions bot

Loading

davydov-d commented Mar 16, 2023 •

edited by github-actions bot

Loading

Source Salesloft: certify to beta #23937

Source Salesloft: certify to beta #23937

Conversation

davydov-d commented Mar 10, 2023 • edited Loading

What

How

davydov-d commented Mar 10, 2023 • edited by github-actions bot Loading

Build Failed

davydov-d commented Mar 10, 2023

davydov-d commented Mar 10, 2023

davydov-d commented Mar 10, 2023 • edited by github-actions bot Loading

Build Failed

bazarnov left a comment

Choose a reason for hiding this comment

davydov-d commented Mar 14, 2023 • edited by github-actions bot Loading

Build Failed

davydov-d commented Mar 15, 2023 • edited by github-actions bot Loading

Build Failed

davydov-d commented Mar 15, 2023 • edited by github-actions bot Loading

Build Passed

davydov-d commented Mar 15, 2023 • edited by github-actions bot Loading

Build Failed

davydov-d commented Mar 15, 2023 • edited by github-actions bot Loading

Build Passed

bnchrch left a comment

Choose a reason for hiding this comment

bnchrch Mar 15, 2023

Choose a reason for hiding this comment

davydov-d commented Mar 16, 2023 • edited by github-actions bot Loading

davydov-d commented Mar 16, 2023 • edited by github-actions bot Loading

davydov-d commented Mar 10, 2023 •

edited

Loading

davydov-d commented Mar 10, 2023 •

edited by github-actions bot

Loading

davydov-d commented Mar 10, 2023 •

edited by github-actions bot

Loading

davydov-d commented Mar 14, 2023 •

edited by github-actions bot

Loading

davydov-d commented Mar 15, 2023 •

edited by github-actions bot

Loading

davydov-d commented Mar 15, 2023 •

edited by github-actions bot

Loading

davydov-d commented Mar 15, 2023 •

edited by github-actions bot

Loading

davydov-d commented Mar 15, 2023 •

edited by github-actions bot

Loading

davydov-d commented Mar 16, 2023 •

edited by github-actions bot

Loading

davydov-d commented Mar 16, 2023 •

edited by github-actions bot

Loading