Source ClickUp: Optional Include Closed Tasks #23951

brunofaustino · 2023-03-10T22:00:12Z

What

Resolves: #24054
By default ClickUp Task API do not include closed tasks. See here.

How

Added a toggle option to make it possible to include or exclude closed tasks.

🚨 User Impact 🚨

It's make possible include or exclude closed tasks.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub by running the /publish command described here
After the connector is published, connector added to connector index as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

Connector Generator

Issue acceptance criteria met
PR name follows PR naming conventions
If adding a new generator, add it to the list of scaffold modules being tested
The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
Documentation which references the generator is updated as needed

marcosmarxm · 2023-03-20T21:24:44Z

/test connector=connectors/source-clickup-api

🕑 connectors/source-clickup-api https://github.com/airbytehq/airbyte/actions/runs/4473064468
❌ connectors/source-clickup-api https://github.com/airbytehq/airbyte/actions/runs/4473064468
🐛

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/plugin.py:63: Skipping TestIncremental.test_two_sequential_reads: Incremental syncs are not supported on this connector.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:509: The previous and actual discovered catalogs are identical.
======================== 33 passed, 2 skipped in 45.35s ========================

marcosmarxm · 2023-03-21T20:31:16Z

/test connector=connectors/source-clickup-api

🕑 connectors/source-clickup-api https://github.com/airbytehq/airbyte/actions/runs/4483552829
❌ connectors/source-clickup-api https://github.com/airbytehq/airbyte/actions/runs/4483552829
🐛 https://gradle.com/s/k3lqptsjbwmjm

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestConnection::test_check[inputs0] - docker.errors.Cont...
FAILED test_core.py::TestConnection::test_check[inputs1] - docker.errors.Cont...
FAILED test_core.py::TestDiscovery::test_discover[inputs0] - docker.errors.Co...
FAILED test_core.py::TestBasicRead::test_airbyte_trace_message_on_failure[inputs0]
ERROR test_core.py::TestSpec::test_config_match_spec[inputs0] - docker.errors...
ERROR test_core.py::TestSpec::test_match_expected[inputs0] - docker.errors.Co...
ERROR test_core.py::TestSpec::test_docker_env[inputs0] - docker.errors.Contai...
ERROR test_core.py::TestSpec::test_enum_usage[inputs0] - docker.errors.Contai...
ERROR test_core.py::TestSpec::test_oneof_usage[inputs0] - docker.errors.Conta...
ERROR test_core.py::TestSpec::test_secret_is_properly_marked[inputs0] - docke...
ERROR test_core.py::TestSpec::test_defined_refs_exist_in_json_spec_file[inputs0]
ERROR test_core.py::TestSpec::test_oauth_flow_parameters[inputs0] - docker.er...
ERROR test_core.py::TestSpec::test_backward_compatibility[inputs0] - docker.e...
ERROR test_core.py::TestSpec::test_additional_properties_is_true[inputs0] - d...
ERROR test_core.py::TestDiscovery::test_defined_cursors_exist_in_schema[inputs0]
ERROR test_core.py::TestDiscovery::test_defined_refs_exist_in_schema[inputs0]
ERROR test_core.py::TestDiscovery::test_defined_keyword_exist_in_schema[inputs0-allOf]
ERROR test_core.py::TestDiscovery::test_defined_keyword_exist_in_schema[inputs0-not]
ERROR test_core.py::TestDiscovery::test_primary_keys_exist_in_schema[inputs0]
ERROR test_core.py::TestDiscovery::test_streams_has_sync_modes[inputs0] - doc...
ERROR test_core.py::TestDiscovery::test_additional_properties_is_true[inputs0]
ERROR test_core.py::TestDiscovery::test_backward_compatibility[inputs0] - doc...
ERROR test_core.py::TestBasicRead::test_read[inputs0] - docker.errors.Contain...
ERROR test_full_refresh.py::TestFullRefresh::test_sequential_reads[inputs0]
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/plugin.py:63: Skipping TestIncremental.test_two_sequential_reads: Incremental syncs are not supported on this connector.
============= 4 failed, 10 passed, 1 skipped, 20 errors in 36.72s ==============

marcosmarxm · 2023-03-21T21:05:46Z

/test connector=connectors/source-clickup-api

🕑 connectors/source-clickup-api https://github.com/airbytehq/airbyte/actions/runs/4483824401
❌ connectors/source-clickup-api https://github.com/airbytehq/airbyte/actions/runs/4483824401
🐛

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/plugin.py:63: Skipping TestIncremental.test_two_sequential_reads: Incremental syncs are not supported on this connector.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:509: The previous and actual discovered catalogs are identical.
======================== 33 passed, 2 skipped in 45.86s ========================

marcosmarxm · 2023-03-21T21:17:44Z

/test connector=connectors/source-clickup-api

🕑 connectors/source-clickup-api https://github.com/airbytehq/airbyte/actions/runs/4483923602
✅ connectors/source-clickup-api https://github.com/airbytehq/airbyte/actions/runs/4483923602
No Python unittests run

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/plugin.py:63: Skipping TestIncremental.test_two_sequential_reads: Incremental syncs are not supported on this connector.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:509: The previous and actual discovered catalogs are identical.
======================== 33 passed, 2 skipped in 44.64s ========================

marcosmarxm · 2023-03-21T21:33:16Z

/publish connector=connectors/source-clickup-api

🕑 Publishing the following connectors:
connectors/source-clickup-api
https://github.com/airbytehq/airbyte/actions/runs/4484035697

Connector	Did it publish?	Were definitions generated?
connectors/source-clickup-api	✅	✅

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

* acceptance test fix ignored_fields team dict * added option to include or exclude closed tasks * added change log * delete doc file and use correct one * update manifest version * auto-bump connector version --------- Co-authored-by: marcosmarxm <marcosmarxm@gmail.com> Co-authored-by: Marcos Marx <marcosmarxm@users.noreply.github.com> Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>

brunofaustino added 2 commits March 10, 2023 18:28

acceptance test fix ignored_fields team dict

1c9aa8c

added option to include or exclude closed tasks

d89a7c6

octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation bounty community connectors/source/clickup-api labels Mar 10, 2023

added change log

14d9927

delete doc file and use correct one

0338a3e

update manifest version

bd68f74

Merge branch 'master' into feature/clickup-api-include-closed-tasks

5b2dbed

marcosmarxm approved these changes Mar 21, 2023

View reviewed changes

auto-bump connector version

4d53f5e

marcosmarxm merged commit 100cc60 into airbytehq:master Mar 21, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Source ClickUp: Optional Include Closed Tasks #23951

Source ClickUp: Optional Include Closed Tasks #23951

brunofaustino commented Mar 10, 2023 •

edited

Loading

marcosmarxm commented Mar 20, 2023 •

edited by github-actions bot

Loading

marcosmarxm commented Mar 21, 2023 •

edited by github-actions bot

Loading

marcosmarxm commented Mar 21, 2023 •

edited by github-actions bot

Loading

marcosmarxm commented Mar 21, 2023 •

edited by github-actions bot

Loading

marcosmarxm commented Mar 21, 2023 •

edited by github-actions bot

Loading

Source ClickUp: Optional Include Closed Tasks #23951

Source ClickUp: Optional Include Closed Tasks #23951

Conversation

brunofaustino commented Mar 10, 2023 • edited Loading

What

How

Recommended reading order

🚨 User Impact 🚨

Pre-merge Checklist

Community member or Airbyter

Airbyter

Community member or Airbyter

Airbyter

marcosmarxm commented Mar 20, 2023 • edited by github-actions bot Loading

Build Passed

marcosmarxm commented Mar 21, 2023 • edited by github-actions bot Loading

Build Failed

marcosmarxm commented Mar 21, 2023 • edited by github-actions bot Loading

Build Passed

marcosmarxm commented Mar 21, 2023 • edited by github-actions bot Loading

Build Passed

marcosmarxm commented Mar 21, 2023 • edited by github-actions bot Loading

brunofaustino commented Mar 10, 2023 •

edited

Loading

marcosmarxm commented Mar 20, 2023 •

edited by github-actions bot

Loading

marcosmarxm commented Mar 21, 2023 •

edited by github-actions bot

Loading

marcosmarxm commented Mar 21, 2023 •

edited by github-actions bot

Loading

marcosmarxm commented Mar 21, 2023 •

edited by github-actions bot

Loading

marcosmarxm commented Mar 21, 2023 •

edited by github-actions bot

Loading