MySQL Source : add CDC heartbeat support #23984

VitaliiMaltsev · 2023-03-13T13:56:44Z

What

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub by running the /publish command described here
After the connector is published, connector added to connector index as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

Connector Generator

Issue acceptance criteria met
PR name follows PR naming conventions
If adding a new generator, add it to the list of scaffold modules being tested
The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
Documentation which references the generator is updated as needed

…tbets

VitaliiMaltsev · 2023-03-13T13:59:37Z

/test connector=connectors/source-postgres

🕑 connectors/source-postgres https://github.com/airbytehq/airbyte/actions/runs/4405745283
✅ connectors/source-postgres https://github.com/airbytehq/airbyte/actions/runs/4405745283
No Python unittests run

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/plugin.py:63: Skipping TestIncremental.test_two_sequential_reads: not found in the config.
SKIPPED [2] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical.
SKIPPED [2] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:509: The previous and actual discovered catalogs are identical.
=================== 62 passed, 5 skipped in 83.78s (0:01:23) ===================

VitaliiMaltsev · 2023-03-13T13:59:43Z

/test connector=connectors/source-mysql

🕑 connectors/source-mysql https://github.com/airbytehq/airbyte/actions/runs/4405745836
✅ connectors/source-mysql https://github.com/airbytehq/airbyte/actions/runs/4405745836
No Python unittests run

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/plugin.py:63: Skipping TestConnection.test_check: not found in the config.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/plugin.py:63: Skipping TestDiscovery.test_discover: not found in the config.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/plugin.py:63: Skipping TestBasicRead.test_read: not found in the config.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/plugin.py:63: Skipping TestFullRefresh.test_sequential_reads: not found in the config.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/plugin.py:63: Skipping TestIncremental.test_two_sequential_reads: not found in the config.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical.
================= 19 passed, 6 skipped, 27 warnings in 17.30s ==================

github-actions · 2023-03-13T13:59:49Z

Affected Connector Report

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to do the following as needed:

Run integration tests
Bump connector or module version
Add changelog
Publish the new version

✅ Sources (8)

Connector	Version	Changelog	Publish
`source-alloydb`	`2.0.3`	✅	✅
`source-alloydb-strict-encrypt`	`2.0.3`	🔵 (ignored)	🔵 (ignored)
`source-mssql`	`1.0.4`	✅	✅
`source-mssql-strict-encrypt`	`1.0.4`	🔵 (ignored)	🔵 (ignored)
`source-mysql`	`2.0.6`	✅	✅
`source-mysql-strict-encrypt`	`2.0.6`	🔵 (ignored)	🔵 (ignored)
`source-postgres`	`2.0.4`	✅	✅
`source-postgres-strict-encrypt`	`2.0.4`	🔵 (ignored)	🔵 (ignored)

See "Actionable Items" below for how to resolve warnings and errors.

✅ Destinations (0)

Connector	Version	Changelog	Publish

See "Actionable Items" below for how to resolve warnings and errors.

✅ Other Modules (0)

Actionable Items

(click to expand)

Category	Status	Actionable Item
Version	❌ mismatch	The version of the connector is different from its normal variant. Please bump the version of the connector.
	⚠ doc not found	The connector does not seem to have a documentation file. This can be normal (e.g. basic connector like `source-jdbc` is not published or documented). Please double-check to make sure that it is not a bug.
Changelog	⚠ doc not found	The connector does not seem to have a documentation file. This can be normal (e.g. basic connector like `source-jdbc` is not published or documented). Please double-check to make sure that it is not a bug.
	❌ changelog missing	There is no chnagelog for the current version of the connector. If you are the author of the current version, please add a changelog.
Publish	⚠ not in seed	The connector is not in the seed file (e.g. `source_definitions.yaml`), so its publication status cannot be checked. This can be normal (e.g. some connectors are cloud-specific, and only listed in the cloud seed file). Please double-check to make sure that it is not a bug.
	❌ diff seed version	The connector exists in the seed file, but the latest version is not listed there. This usually means that the latest version is not published. Please use the `/publish` command to publish the latest version.

subodh1810

@VitaliiMaltsev I have pushed a couple of commits to simplify the implementation. Basically I introduced generics which makes it simpler. Can you carry out some manual testing to make sure this works as expected. Once done please share the results and I will approve

subodh1810 · 2023-03-15T17:26:25Z

/test connector=connectors/source-mysql

🕑 connectors/source-mysql https://github.com/airbytehq/airbyte/actions/runs/4429164031
❌ connectors/source-mysql https://github.com/airbytehq/airbyte/actions/runs/4429164031
🐛 https://gradle.com/s/j5g2sxc63srt4

Build Failed

Test summary info:

Could not find result summary

subodh1810 · 2023-03-15T17:26:32Z

/test connector=connectors/source-postgres

🕑 connectors/source-postgres https://github.com/airbytehq/airbyte/actions/runs/4429164840
✅ connectors/source-postgres https://github.com/airbytehq/airbyte/actions/runs/4429164840
No Python unittests run

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/plugin.py:63: Skipping TestIncremental.test_two_sequential_reads: not found in the config.
SKIPPED [2] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical.
SKIPPED [2] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:509: The previous and actual discovered catalogs are identical.
=================== 62 passed, 5 skipped in 83.00s (0:01:22) ===================

subodh1810 · 2023-03-15T17:26:38Z

/test connector=connectors/source-mssql

🕑 connectors/source-mssql https://github.com/airbytehq/airbyte/actions/runs/4429165946
✅ connectors/source-mssql https://github.com/airbytehq/airbyte/actions/runs/4429165946
No Python unittests run

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/plugin.py:63: Skipping TestConnection.test_check: not found in the config.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/plugin.py:63: Skipping TestDiscovery.test_discover: not found in the config.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/plugin.py:63: Skipping TestBasicRead.test_read: not found in the config.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/plugin.py:63: Skipping TestFullRefresh.test_sequential_reads: not found in the config.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/plugin.py:63: Skipping TestIncremental.test_two_sequential_reads: not found in the config.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical.
================= 19 passed, 6 skipped, 27 warnings in 17.56s ==================

sergio-ropero

Looks good to me, just a few minor comments

...rations/bases/debezium/src/main/java/io/airbyte/integrations/debezium/CdcTargetPosition.java

sergio-ropero · 2023-03-16T14:21:18Z

...rations/bases/debezium/src/main/java/io/airbyte/integrations/debezium/CdcTargetPosition.java

-   * @return true if lsn is equal or greater than target lsn
-   */
-  default boolean reachedTargetPosition(final Long lsn) {
+  default boolean reachedTargetPosition(final T positionFromHeartbeat) {


Should we just remove the default?
It just throw an exception as it's an interface and all the classes needs to implement it.
Otherwise we can make default the method extractPositionFromHeartbeatOffset.

sergio-ropero · 2023-03-16T14:23:22Z

...ium/src/test/java/io/airbyte/integrations/debezium/internals/DebeziumRecordIteratorTest.java


    assertEquals(lsn, 358824993496L);
-    assertEquals(-1, debeziumRecordIterator.getHeartbeatPosition(null));


we should keep this test, but instead of making it equal to -1 to null.

sergio-ropero · 2023-03-17T12:13:38Z

...ebezium/src/main/java/io/airbyte/integrations/debezium/internals/DebeziumRecordIterator.java

-    if (heartbeatEvent == null) {
-      return null;
-    }


This is not redundant is an early exit to reduce unneeded computation and object creation.

This is not redundant is an early exit to reduce unneeded computation and object creation.

@sergio-ropero please take a look here
this check for null is definitely not needed since it can never occur

Yes and no, so it will be never null if you include it inside an if statement that previously checks it's not null.
I think we can remove it, but we need to ensure that we always include that if statement.

Yes and no, so it will be never null if you include it inside an if statement that previously checks it's not null.
I think we can remove it, but we need to ensure that we always include that if statement.

i don't understand what do you mean to "ensure that we always include that if statement" if we will never get null here

What I mean is that they are 2 different functions, and it will never be null because in our current code we are including the function getHeartbeatPosition inside the if statement that uses isHeartbeatEvent.

That means that the function getHeartbeatPosition can be called (in other scenarios) with a null object, except if again we include it inside a block code with the same if statement.

VitaliiMaltsev · 2023-03-17T13:15:50Z

@VitaliiMaltsev I have pushed a couple of commits to simplify the implementation. Basically I introduced generics which makes it simpler. Can you carry out some manual testing to make sure this works as expected. Once done please share the results and I will approve

@subodh1810 СDC syncs started to fail permanently with the error Caused by: java.io.StreamCorruptedException: unexpected EOF in middle of data block
On the other hand this commit [b0109ff] work as expected

Probably the root cause of these failing is not your changes but @sergio-ropero PR

UPD these failures are not related to your or mine changes. MySQL CDC syncs are failing in master branch with the same error

dimoschi · 2023-03-19T11:29:26Z

@subodh1810 СDC syncs started to fail permanently with the error Caused by: java.io.StreamCorruptedException: unexpected EOF in middle of data block On the other hand this commit [b0109ff] work as expected

I experience the same issue for big tables from MySQL to Snowflake. Can you please let me know if there is any issue with the latest version of Airbyte (v.0.42.0) and the latest MySQL Source (v2.0.3)? From the conversation above and @VitaliiMaltsev comments here and in issue #24191 it is not clear.

VitaliiMaltsev · 2023-03-19T14:24:54Z

@subodh1810 СDC syncs started to fail permanently with the error Caused by: java.io.StreamCorruptedException: unexpected EOF in middle of data block On the other hand this commit [b0109ff] work as expected

I experience the same issue for big tables from MySQL to Snowflake. Can you please let me know if there is any issue with the latest version of Airbyte (v.0.42.0) and the latest MySQL Source (v2.0.3)? From the conversation above and @VitaliiMaltsev comments here and in issue #24191 it is not clear.

@dimoschi i would like to ask you to do 2 more experiments and provide your results. It will be very helpful to detect the root cause

Build mysql source from master branch and check if issue persists
Build mysql source from commit [b0109ff] and check if issue persists
Thanks in advance

dimoschi · 2023-03-20T09:58:23Z

@subodh1810 СDC syncs started to fail permanently with the error Caused by: java.io.StreamCorruptedException: unexpected EOF in middle of data block On the other hand this commit [b0109ff] work as expected

I experience the same issue for big tables from MySQL to Snowflake. Can you please let me know if there is any issue with the latest version of Airbyte (v.0.42.0) and the latest MySQL Source (v2.0.3)? From the conversation above and @VitaliiMaltsev comments here and in issue #24191 it is not clear.

@dimoschi i would like to ask you to do 2 more experiments and provide your results. It will be very helpful to detect the root cause

Build mysql source from master branch and check if issue persists

Build mysql source from commit [b0109ff] and check if issue persists
Thanks in advance

Thanks for the immediate response. I wasn't able to build source-mysql. First tests failed and then after executing ./gradlew :airbyte-integrations:connectors:source-mysql:build -x test I got the following:

❯ ./gradlew :airbyte-integrations:connectors:source-mysql:build -x test                                                                                                                                                        ─╯
Building all of Airbyte.
/Users/dimos/repos/3rd-party/airbyte/airbyte-integrations/connectors

> Task :airbyte-integrations:bases:base:airbyteDocker
#1 [internal] load build definition from Dockerfile
#1 sha256:193253fbf4680ed996116d49387909a4bf4b61c6d09a5d0e76699750ed019fc7
#1 transferring dockerfile: 35B 0.0s
#1 transferring dockerfile: 267B 0.1s done
#1 DONE 0.3s

#2 [internal] load .dockerignore
#2 sha256:24b81dbb7760f67b32993d5696618e1d72f1ad71e1783bacdf7989bf8958cc20
#2 transferring context:
#2 transferring context: 46B 0.0s done
#2 DONE 0.2s

> Task :airbyte-api:generateApiServer
################################################################################
# Thanks for using OpenAPI Generator.                                          #
# Please consider donation to help us maintain this project 🙏                 #
# https://opencollective.com/openapi_generator/donate                          #
################################################################################
Successfully generated code to /Users/dimos/repos/3rd-party/airbyte/airbyte-api/build/generated/api/server

> Task :airbyte-integrations:bases:base:airbyteDocker

#3 [internal] load metadata for docker.io/library/amazonlinux:2022.0.20220831.1
#3 sha256:58cd828510bffe8a1238c63efae7efd647789269a2cd1103cecebedc4402451f

> Task :airbyte-api:generateApiServerLegacy
################################################################################
# Thanks for using OpenAPI Generator.                                          #
# Please consider donation to help us maintain this project 🙏                 #
# https://opencollective.com/openapi_generator/donate                          #
################################################################################
Successfully generated code to /Users/dimos/repos/3rd-party/airbyte/airbyte-api/build/generated/api/server

> Task :airbyte-integrations:bases:base:airbyteDocker FAILED
#3 ERROR: failed to do request: Head "https://registry-1.docker.io/v2/library/amazonlinux/manifests/2022.0.20220831.1": dialing registry-1.docker.io:443 with direct connection: resolving host registry-1.docker.io: lookup registry-1.docker.io: no such host
------
 > [internal] load metadata for docker.io/library/amazonlinux:2022.0.20220831.1:
------
failed to solve with frontend dockerfile.v0: failed to create LLB definition: failed to do request: Head "https://registry-1.docker.io/v2/library/amazonlinux/manifests/2022.0.20220831.1": dialing registry-1.docker.io:443 with direct connection: resolving host registry-1.docker.io: lookup registry-1.docker.io: no such host

> Task :airbyte-api:compileJava
Could not load entry 492fa24ec9ab4aa8c50f11b13fe9e2e8 from remote build cache: Received an UnknownHostException when attempting to interact with a service. See cause for the exact endpoint that is failing to resolve. If this is happening on an endpoint that previously worked, there may be a network connectivity issue or your DNS cache could be storing endpoints for too long.

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':airbyte-integrations:bases:base:airbyteDocker'.
> Process 'command '/Users/dimos/repos/3rd-party/airbyte/tools/bin/build_image.sh'' finished with non-zero exit value 1

dimoschi · 2023-03-20T10:07:49Z

I don't know if that helps, but using MySQL v2.0.0 worked perfectly fine.

VitaliiMaltsev · 2023-03-20T11:54:39Z

I don't know if that helps, but using MySQL v2.0.0 worked perfectly fine.

@dimoschi thanks for your help.
I have found that sync started failing from 2.0.2 version after this PR was merged into master

dimoschi · 2023-03-20T12:17:38Z

I don't know if that helps, but using MySQL v2.0.0 worked perfectly fine.

@dimoschi thanks for your help. I have found that sync started failing from 2.0.2 version after this PR was merged into master

Thank you @VitaliiMaltsev for bringing that up in the first place. I haven't done much and unfortunately, I couldn't spend more time resolving build issues with the source-mysql connector so I can help more. For now, I'm gonna stay with the 2.0.0 version.

subodh1810 · 2023-03-20T15:04:15Z

Lets track and continue the communication for the EOF error on issue #24191

subodh1810 · 2023-03-20T15:21:40Z

@VitaliiMaltsev I think this PR is safe to merge and we dont expect to fix the EOF error as part of this PR. We will continue to work on it as part of the issue. So lets get this PR merged.

VitaliiMaltsev · 2023-03-21T14:45:01Z

/publish connector=connectors/source-mysql

🕑 Publishing the following connectors:
connectors/source-mysql
https://github.com/airbytehq/airbyte/actions/runs/4480400764

Connector	Did it publish?	Were definitions generated?
connectors/source-mysql	❌	❌

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

VitaliiMaltsev · 2023-03-21T14:45:21Z

/publish connector=connectors/source-mysql-strict-encrypt

🕑 Publishing the following connectors:
connectors/source-mysql-strict-encrypt
https://github.com/airbytehq/airbyte/actions/runs/4480404254

Connector	Did it publish?	Were definitions generated?
connectors/source-mysql-strict-encrypt	✅	❌

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

VitaliiMaltsev · 2023-03-21T15:40:22Z

/test connector=connectors/source-mysql

🕑 connectors/source-mysql https://github.com/airbytehq/airbyte/actions/runs/4480986273
✅ connectors/source-mysql https://github.com/airbytehq/airbyte/actions/runs/4480986273
No Python unittests run

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/plugin.py:63: Skipping TestConnection.test_check: not found in the config.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/plugin.py:63: Skipping TestDiscovery.test_discover: not found in the config.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/plugin.py:63: Skipping TestBasicRead.test_read: not found in the config.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/plugin.py:63: Skipping TestFullRefresh.test_sequential_reads: not found in the config.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/plugin.py:63: Skipping TestIncremental.test_two_sequential_reads: not found in the config.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical.
================= 19 passed, 6 skipped, 27 warnings in 16.93s ==================

VitaliiMaltsev · 2023-03-21T16:22:16Z

/publish connector=connectors/source-mysql run-tests=false

🕑 Publishing the following connectors:
connectors/source-mysql
https://github.com/airbytehq/airbyte/actions/runs/4481415385

Connector	Did it publish?	Were definitions generated?
connectors/source-mysql	✅	✅

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

* MySQL Source : add CDC heartbeat support * removed logs * fixed DebeziumRecordIteratorTest * Automated Change * use generics to simplify implementation * use Duration * more refactoring * removed redundant null check * Automated Change * bump version * auto-bump connector version --------- Co-authored-by: VitaliiMaltsev <VitaliiMaltsev@users.noreply.github.com> Co-authored-by: subodh <subodh1810@gmail.com> Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>

VitaliiMaltsev and others added 2 commits March 13, 2023 15:55

MySQL Source : add CDC heartbeat support

a1ba5a9

Merge branch 'master' into mysql-heartbets

6d7dad7

octavia-squidington-iii added area/connectors Connector related issues connectors/source/mysql connectors/source/postgres labels Mar 13, 2023

VitaliiMaltsev added 2 commits March 13, 2023 15:57

removed logs

b0109ff

Merge remote-tracking branch 'origin/mysql-heartbets' into mysql-hear…

2bd11a1

…tbets

VitaliiMaltsev marked this pull request as ready for review March 13, 2023 14:52

VitaliiMaltsev requested a review from a team as a code owner March 13, 2023 14:52

fixed DebeziumRecordIteratorTest

653667a

VitaliiMaltsev requested a review from subodh1810 March 13, 2023 15:30

VitaliiMaltsev mentioned this pull request Mar 13, 2023

MySQL Source Support CDC heartbeats #23376

Closed

37 tasks

Automated Change

0d9b820

VitaliiMaltsev linked an issue Mar 13, 2023 that may be closed by this pull request

Add CDC heartbeat to MySQL #23257

Closed

Merge branch 'master' into mysql-heartbets

a166682

prateekmukhedkar requested a review from rodireich March 14, 2023 16:20

use generics to simplify implementation

9a193ff

octavia-squidington-iii added the connectors/source/mssql label Mar 15, 2023

use Duration

03e5484

subodh1810 reviewed Mar 15, 2023

View reviewed changes

Merge branch 'master' into mysql-heartbets

18b70a4

subodh1810 requested a review from sergio-ropero March 16, 2023 11:00

sergio-ropero approved these changes Mar 16, 2023

View reviewed changes

Merge branch 'master' into mysql-heartbets

0668650

Automated Change

b0eecb5

sergio-ropero suggested changes Mar 17, 2023

View reviewed changes

VitaliiMaltsev requested a review from sergio-ropero March 17, 2023 12:41

sergio-ropero approved these changes Mar 17, 2023

View reviewed changes

VitaliiMaltsev requested a review from subodh1810 March 17, 2023 17:21

subodh1810 approved these changes Mar 20, 2023

View reviewed changes

VitaliiMaltsev added 2 commits March 21, 2023 16:40

Merge branch 'master' into mysql-heartbets

807cbda

bump version

a846712

octavia-squidington-iii added area/documentation Improvements or additions to documentation connectors/source/mysql-strict-encrypt labels Mar 21, 2023

octavia-squidington-iii and others added 2 commits March 21, 2023 16:31

auto-bump connector version

6daa0b0

Merge branch 'master' into mysql-heartbets

3379f55

VitaliiMaltsev enabled auto-merge (squash) March 21, 2023 16:32

VitaliiMaltsev merged commit f41d821 into master Mar 21, 2023

VitaliiMaltsev deleted the mysql-heartbets branch March 21, 2023 16:54

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

MySQL Source : add CDC heartbeat support #23984

MySQL Source : add CDC heartbeat support #23984

VitaliiMaltsev commented Mar 13, 2023 •

edited

Loading

VitaliiMaltsev commented Mar 13, 2023 •

edited by github-actions bot

Loading

VitaliiMaltsev commented Mar 13, 2023 •

edited by github-actions bot

Loading

github-actions bot commented Mar 13, 2023 •

edited

Loading

✅ Sources (8)

✅ Destinations (0)

✅ Other Modules (0)

Actionable Items

subodh1810 left a comment

subodh1810 commented Mar 15, 2023 •

edited by github-actions bot

Loading

subodh1810 commented Mar 15, 2023 •

edited by github-actions bot

Loading

subodh1810 commented Mar 15, 2023 •

edited by github-actions bot

Loading

sergio-ropero left a comment

sergio-ropero Mar 16, 2023

sergio-ropero Mar 16, 2023

sergio-ropero Mar 17, 2023

VitaliiMaltsev Mar 17, 2023

sergio-ropero Mar 17, 2023 •

edited

Loading

VitaliiMaltsev Mar 17, 2023

sergio-ropero Mar 20, 2023

VitaliiMaltsev commented Mar 17, 2023 •

edited

Loading

dimoschi commented Mar 19, 2023

VitaliiMaltsev commented Mar 19, 2023

dimoschi commented Mar 20, 2023

dimoschi commented Mar 20, 2023

VitaliiMaltsev commented Mar 20, 2023

dimoschi commented Mar 20, 2023

subodh1810 commented Mar 20, 2023

subodh1810 commented Mar 20, 2023

VitaliiMaltsev commented Mar 21, 2023 •

edited by github-actions bot

Loading

VitaliiMaltsev commented Mar 21, 2023 •

edited by github-actions bot

Loading

VitaliiMaltsev commented Mar 21, 2023 •

edited by github-actions bot

Loading

VitaliiMaltsev commented Mar 21, 2023 •

edited by github-actions bot

Loading


		assertEquals(lsn, 358824993496L);
		assertEquals(-1, debeziumRecordIterator.getHeartbeatPosition(null));

MySQL Source : add CDC heartbeat support #23984

MySQL Source : add CDC heartbeat support #23984

Conversation

VitaliiMaltsev commented Mar 13, 2023 • edited Loading

What

🚨 User Impact 🚨

Pre-merge Checklist

Community member or Airbyter

Airbyter

Community member or Airbyter

Airbyter

VitaliiMaltsev commented Mar 13, 2023 • edited by github-actions bot Loading

Build Passed

VitaliiMaltsev commented Mar 13, 2023 • edited by github-actions bot Loading

Build Passed

github-actions bot commented Mar 13, 2023 • edited Loading

Affected Connector Report

✅ Sources (8)

✅ Destinations (0)

✅ Other Modules (0)

Actionable Items

subodh1810 left a comment

Choose a reason for hiding this comment

subodh1810 commented Mar 15, 2023 • edited by github-actions bot Loading

Build Failed

subodh1810 commented Mar 15, 2023 • edited by github-actions bot Loading

Build Passed

subodh1810 commented Mar 15, 2023 • edited by github-actions bot Loading

Build Passed

sergio-ropero left a comment

Choose a reason for hiding this comment

sergio-ropero Mar 16, 2023

Choose a reason for hiding this comment

sergio-ropero Mar 16, 2023

Choose a reason for hiding this comment

sergio-ropero Mar 17, 2023

Choose a reason for hiding this comment

VitaliiMaltsev Mar 17, 2023

Choose a reason for hiding this comment

sergio-ropero Mar 17, 2023 • edited Loading

Choose a reason for hiding this comment

VitaliiMaltsev Mar 17, 2023

Choose a reason for hiding this comment

sergio-ropero Mar 20, 2023

Choose a reason for hiding this comment

VitaliiMaltsev commented Mar 17, 2023 • edited Loading

dimoschi commented Mar 19, 2023

VitaliiMaltsev commented Mar 19, 2023

dimoschi commented Mar 20, 2023

dimoschi commented Mar 20, 2023

VitaliiMaltsev commented Mar 20, 2023

dimoschi commented Mar 20, 2023

subodh1810 commented Mar 20, 2023

subodh1810 commented Mar 20, 2023

VitaliiMaltsev commented Mar 21, 2023 • edited by github-actions bot Loading

VitaliiMaltsev commented Mar 21, 2023 • edited by github-actions bot Loading

VitaliiMaltsev commented Mar 21, 2023 • edited by github-actions bot Loading

Build Passed

VitaliiMaltsev commented Mar 21, 2023 • edited by github-actions bot Loading

VitaliiMaltsev commented Mar 13, 2023 •

edited

Loading

VitaliiMaltsev commented Mar 13, 2023 •

edited by github-actions bot

Loading

VitaliiMaltsev commented Mar 13, 2023 •

edited by github-actions bot

Loading

github-actions bot commented Mar 13, 2023 •

edited

Loading

subodh1810 commented Mar 15, 2023 •

edited by github-actions bot

Loading

subodh1810 commented Mar 15, 2023 •

edited by github-actions bot

Loading

subodh1810 commented Mar 15, 2023 •

edited by github-actions bot

Loading

sergio-ropero Mar 17, 2023 •

edited

Loading

VitaliiMaltsev commented Mar 17, 2023 •

edited

Loading

VitaliiMaltsev commented Mar 21, 2023 •

edited by github-actions bot

Loading

VitaliiMaltsev commented Mar 21, 2023 •

edited by github-actions bot

Loading

VitaliiMaltsev commented Mar 21, 2023 •

edited by github-actions bot

Loading

VitaliiMaltsev commented Mar 21, 2023 •

edited by github-actions bot

Loading