CAT: handle discovery error on previous catalog retrieval #23992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Affected Connector ReportNOTE
|
| Connector | Version | Changelog | Publish |
|---|---|---|---|
source-railz |
0.1.1 |
✅ | ✅ |
- See "Actionable Items" below for how to resolve warnings and errors.
✅ Destinations (0)
| Connector | Version | Changelog | Publish |
|---|
- See "Actionable Items" below for how to resolve warnings and errors.
✅ Other Modules (0)
Actionable Items
(click to expand)
| Category | Status | Actionable Item |
|---|---|---|
| Version | ❌ mismatch |
The version of the connector is different from its normal variant. Please bump the version of the connector. |
| ⚠ doc not found |
The connector does not seem to have a documentation file. This can be normal (e.g. basic connector like source-jdbc is not published or documented). Please double-check to make sure that it is not a bug. |
|
| Changelog | ⚠ doc not found |
The connector does not seem to have a documentation file. This can be normal (e.g. basic connector like source-jdbc is not published or documented). Please double-check to make sure that it is not a bug. |
| ❌ changelog missing |
There is no chnagelog for the current version of the connector. If you are the author of the current version, please add a changelog. | |
| Publish | ⚠ not in seed |
The connector is not in the seed file (e.g. source_definitions.yaml), so its publication status cannot be checked. This can be normal (e.g. some connectors are cloud-specific, and only listed in the cloud seed file). Please double-check to make sure that it is not a bug. |
| ❌ diff seed version |
The connector exists in the seed file, but the latest version is not listed there. This usually means that the latest version is not published. Please use the /publish command to publish the latest version. |
davydov-d
approved these changes
Mar 13, 2023
|
Looks good to me, thanks! |
evantahler
approved these changes
Mar 13, 2023
Comment on lines
+314
to
+315
| logging.warning( | ||
| "\n DISCOVER on the previous connector version failed. This could be because the current connector config is not compatible with the previous connector version." |
There was a problem hiding this comment.
Could we log what we think the previous version is? That might help debugging.
|
/publish connector=bases/connector-acceptance-test auto-bump-version=false
if you have connectors that successfully published but failed definition generation, follow step 4 here |
…bility-when-config-changed
alafanechere
deleted the
augustin/cat/fix-discover-backward-compatibility-when-config-changed
branch
adriennevermorel
pushed a commit
to adriennevermorel/airbyte
that referenced
this pull request
Mar 17, 2023
erohmensing
pushed a commit
that referenced
this pull request
Mar 22, 2023
erohmensing
pushed a commit
that referenced
this pull request
Mar 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
We can't retrieve the previous connector version discovered catalog when the connector's current configuration is not compatible with the previous connector version. This is expected if backward incompatible changes where introduced on a branch and should make the backward compatible tests fail.
But even if the backward compatibility tests are bypassed the tests are still failing because we're using a fixture to check if the backward compatibility tests can be skipped. And in this fixture, we check the content of the previous catalog.
How
Handle discovery error in the
previous_discovered_catalog_fixture: a None catalog is returned if the discovery failed.This will make the
skip_backward_compatibility_tests_fixtureexecution not fail.