Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a note about publishing with dockerx #24057

Merged
merged 1 commit into from
Mar 14, 2023
Merged

Add a note about publishing with dockerx #24057

merged 1 commit into from
Mar 14, 2023

Conversation

evantahler
Copy link
Contributor

No description provided.

@evantahler evantahler requested a review from erohmensing March 14, 2023 15:41
@evantahler evantahler marked this pull request as ready for review March 14, 2023 15:41
erohmensing
erohmensing approved these changes Mar 14, 2023
View reviewed changes
Copy link
Contributor

@erohmensing erohmensing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding. Should we make a note about making sure to push the spec to the cache? I'm worried this wasn't done here

@evantahler evantahler merged commit a17da15 into master Mar 14, 2023
@evantahler evantahler deleted the evan/publish-note branch March 14, 2023 16:21
adriennevermorel pushed a commit to adriennevermorel/airbyte that referenced this pull request Mar 17, 2023
@evantahler @adriennevermorel
Add a note about publishing with dockerx (airbytehq#24057)
158dadc
erohmensing pushed a commit that referenced this pull request Mar 22, 2023
@evantahler @erohmensing
Add a note about publishing with dockerx (#24057)
a85eda7
erohmensing pushed a commit that referenced this pull request Mar 22, 2023
@evantahler @erohmensing
Add a note about publishing with dockerx (#24057)
3cd8fbe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erohmensing erohmensing erohmensing approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@evantahler @erohmensing