🐛 Source Onesignal: Update connectors spec; fix incremental sync

[artem1205]

What

Resolving #23535

How

Describe the solution

Recommended reading order

1. x.java
2. y.python

🚨 User Impact 🚨

Due to changes on Onesignal side, we cannot retrieve application keys no more (empty fields in response).
User has to fill in application data to retrieve records from app-related streams. (see screen)

Pre-merge Checklist

Expand the relevant checklist and delete the others.

Updating a connector

Community member or Airbyter

• Grant edit access to maintainers (instructions)
• Secrets in the connector's spec are annotated with airbyte_secret
• Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
• Code reviews completed
• Documentation updated
  • Connector's README.md
  • Connector's bootstrap.md. See description and examples
  • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
• PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

• Create a non-forked branch based on this PR and test the below items on it
• Build is successful
• If new credentials are required for use in CI, add them to GSM. Instructions.
• /test connector=connectors/<name> command is passing
• New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

[artem1205]

/test connector=connectors/source-onesignal

🕑 connectors/source-onesignal https://github.com/airbytehq/airbyte/actions/runs/4420921042
✅ connectors/source-onesignal https://github.com/airbytehq/airbyte/actions/runs/4420921042
Python tests coverage:

Name                           Stmts   Miss  Cover
--------------------------------------------------
source_onesignal/__init__.py       2      0   100%
source_onesignal/source.py        26      3    88%
source_onesignal/streams.py       99     18    82%
--------------------------------------------------
TOTAL                            127     21    83%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/plugin.py:63: Skipping TestIncremental.test_two_sequential_reads: not found in the config.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:109: Backward compatibility tests are disabled for version 0.1.2.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:518: Backward compatibility tests are disabled for version 0.1.2.
================= 32 passed, 3 skipped, 36 warnings in 29.86s ==================

[evantahler]

Due to changes on Onesignal side, we cannot retrieve application keys no more (empty fields in response).
User has to fill in application data to retrieve records from app-related streams. (see screen)

I think this makes this a breaking change?

[artem1205]

updated

[evantahler]

Deleting all the expected records doesn't seem right

[artem1205]

This is not our data. I'll add expected records once we'll seed our new account.

[evantahler]

👍, assuming seeding our account will happen soon

[artem1205]

/publish connector=connectors/source-onesignal

🕑 Publishing the following connectors:
connectors/source-onesignal
https://github.com/airbytehq/airbyte/actions/runs/4440445220

Connector	Did it publish?	Were definitions generated?
connectors/source-onesignal	✅	✅

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️