Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Destination Typesense: add icon, prepare for Cloud #24139

Merged

Conversation

arsenlosenko
Copy link
Contributor

What

Resolving:
#23552

How

Added SVG icon, updated credentials, tested the sync, checked docs and changelog

Recommended reading order

  1. x.java
  2. y.python

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the connector is published, connector added to connector index as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here
Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub and connector version bumped by running the /publish command described here
Connector Generator
  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed

@arsenlosenko arsenlosenko self-assigned this Mar 16, 2023
@arsenlosenko
Copy link
Contributor Author

arsenlosenko commented Mar 16, 2023

/test connector=connectors/destination-typesense

🕑 connectors/destination-typesense https://github.com/airbytehq/airbyte/actions/runs/4436176768
✅ connectors/destination-typesense https://github.com/airbytehq/airbyte/actions/runs/4436176768
Python tests coverage:

Name                                   Stmts   Miss  Cover
----------------------------------------------------------
destination_typesense/__init__.py          2      0   100%
destination_typesense/writer.py           24      1    96%
destination_typesense/destination.py      43      3    93%
----------------------------------------------------------
TOTAL                                     69      4    94%

Build Passed

Test summary info:

All Passed

@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Mar 16, 2023
@arsenlosenko arsenlosenko merged commit 417304f into master Mar 16, 2023
@arsenlosenko arsenlosenko deleted the arsenlosenko/23552-destination-typesense-enable-in-cloud branch March 16, 2023 15:02
adriennevermorel pushed a commit to adriennevermorel/airbyte that referenced this pull request Mar 17, 2023
* Destination Typesense: add icon

* Update docs

* Automated Change

---------

Co-authored-by: arsenlosenko <arsenlosenko@users.noreply.github.com>
erohmensing pushed a commit that referenced this pull request Mar 22, 2023
* Destination Typesense: add icon

* Update docs

* Automated Change

---------

Co-authored-by: arsenlosenko <arsenlosenko@users.noreply.github.com>
erohmensing pushed a commit that referenced this pull request Mar 22, 2023
* Destination Typesense: add icon

* Update docs

* Automated Change

---------

Co-authored-by: arsenlosenko <arsenlosenko@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants