Connector builder: handle empty catalog #24184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
girarda
reviewed
Mar 17, 2023
| def handle_connector_builder_request(source: ManifestDeclarativeSource, config: Mapping[str, Any], catalog: ConfiguredAirbyteCatalog): | ||
| command = config.get("__command") | ||
| def handle_connector_builder_request( | ||
| source: ManifestDeclarativeSource, command: str, config: Mapping[str, Any], catalog: Optional[ConfiguredAirbyteCatalog] |
There was a problem hiding this comment.
nit: read_stream expects catalog to be non-None, so we should validate its presence before passing it
There was a problem hiding this comment.
Ah good call. I didn't see this before I hit merge so will open a new one for that.
girarda
approved these changes
Mar 17, 2023
erohmensing
pushed a commit
that referenced
this pull request
Mar 22, 2023
erohmensing
pushed a commit
that referenced
this pull request
Mar 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fixes an issue where the CDK attempts to validate an empty catalog on requests where the catalog is not needed.
Why
The Connector Builder server has two request types that don't require a catalog:
resolve_manifestandlist_streams. For these, the filepath provided in the--catalogargument points to an empty catalog. We don't actually want or need to try to validate the catalog, so let's skip it, to avoid unnecessary file reads if nothing else.