Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎉 New destination connector for Xata.io #24192

Merged
merged 36 commits into from
Jun 14, 2023

Conversation

philkra
Copy link
Contributor

@philkra philkra commented Mar 17, 2023

What

This PR adds a destination connector for ingesting records into Xata.io.

How

  • Used airbyte's templating engine for python 😄
  • used the xata package for ingesting data & bulk processing.

Recommended reading order

  1. docs/integrations/destinations/xata.md
  2. destination.py

🚨 User Impact 🚨

no breaking change

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Connector version is set to 0.0.1
    • Dockerfile has version 0.0.1
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • docs/integrations/<source or destination>/<name>.md including changelog with an entry for the initial version. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the connector is published, connector added to connector index as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

@CLAassistant
Copy link

CLAassistant commented Mar 17, 2023

CLA assistant check
All committers have signed the CLA.

@philkra
Copy link
Contributor Author

philkra commented Mar 20, 2023

Connector's bootstrap.md. See description and examples

FYI, the link points to a 404

@marcosmarxm
Copy link
Member

Thanks for the contribution @philkra I'll take a look later this week!

@marcosmarxm
Copy link
Member

@philkra are you able to run the integration test?

@philkra
Copy link
Contributor Author

philkra commented Mar 24, 2023

@marcosmarxm , yes. Apologies, I forgot to upload the screenshot.

Screenshot 2023-03-24 at 13 28 16

@alexfrancoeur
Copy link

alexfrancoeur commented Mar 31, 2023

@timroes 👋 sup 😁

@timroes
Copy link
Collaborator

timroes commented Mar 31, 2023

@alexfrancoeur Uh la la, love to see this ❤️ Say also hi to @flash1293 and @chandlerprall :)

@alexfrancoeur
Copy link

@flash1293 @chandlerprall 👋

(and now back to the actual PR 😜)

@philkra
Copy link
Contributor Author

philkra commented Apr 8, 2023

@marcosmarxm how can I help to move this PR forward?

@marcosmarxm
Copy link
Member

marcosmarxm commented May 25, 2023

/test connector=connectors/destination-xata

🕑 connectors/destination-xata https://github.com/airbytehq/airbyte/actions/runs/5082313222
❌ connectors/destination-xata https://github.com/airbytehq/airbyte/actions/runs/5082313222
🐛

Build Passed

Test summary info:

All Passed

@philkra
Copy link
Contributor Author

philkra commented May 30, 2023

@marcosmarxm how I can add the icon mentioned in the test and what other tasks are missing to merge this PR?

@philkra
Copy link
Contributor Author

philkra commented Jun 5, 2023

ping @marcosmarxm

@alexfrancoeur
Copy link

heya @marcosmarxm, thanks again for all your help so far! We're so close to getting this over the line, is there anything else you need from us? @philkra had one question about an icon.

@marcosmarxm
Copy link
Member

Sorry the delay to return to the contribution @philkra and thank you for all the patience. I'm try do my best to review again tomorrow.

@marcosmarxm
Copy link
Member

marcosmarxm commented Jun 7, 2023

/test connector=connectors/destination-xata

🕑 connectors/destination-xata https://github.com/airbytehq/airbyte/actions/runs/5201396189
❌ connectors/destination-xata https://github.com/airbytehq/airbyte/actions/runs/5201396189
🐛

Build Passed

Test summary info:

All Passed

@timroes
Copy link
Collaborator

timroes commented Jun 7, 2023

@alexfrancoeur do you happen to have a link to your preferred logo as SVG or if not online, could you send it to me privately? We could then make sure to make it match our dimensions for logos and add it.

@alexfrancoeur
Copy link

alexfrancoeur commented Jun 8, 2023 via email

@jrolom jrolom removed the bounty label Jun 9, 2023
@alexfrancoeur
Copy link

I'm not sure if there's a better place for this, but is there any place to discuss potential co-marketing activities around this integration? It looks like we're just about over the finish line.

@timroes
Copy link
Collaborator

timroes commented Jun 13, 2023

@philkra I've added the Xata logo to the platform (where they at the moment live) in airbytehq/airbyte-platform@0a8b27b You should be fine using now xata.svg as you do in your specification.

@philkra
Copy link
Contributor Author

philkra commented Jun 13, 2023

Awesome thanks @timroes for adding the logo. I don't know where to reference the logo though, I asked a couple of times 🤷‍♂️ Can you, please point me to the files I need to change or guides?

@timroes
Copy link
Collaborator

timroes commented Jun 13, 2023

Awesome thanks @timroes for adding the logo. I don't know where to reference the logo though, I asked a couple of times man_shrugging Can you, please point me to the files I need to change or guides?

@philkra You already linked it correctly here: https://github.com/airbytehq/airbyte/pull/24192/files#diff-cd7f7327b2a8abb8dd28ab593f20d184b21acde010488a4eb991e9dac5e8b5a0R13 This will now work as expected.

@marcosmarxm marcosmarxm merged commit 18553a2 into airbytehq:master Jun 14, 2023
@philkra
Copy link
Contributor Author

philkra commented Jun 15, 2023

Thank you to everyone that contributed ❤️

@alexfrancoeur
Copy link

Thank you so much @timroes @philkra @marcosmarxm for all of your help here! ❤️

I'm curious, we'll plan to blog about this, add to our docs and do a bit of social promotion. Is there anyone on the airbyte side we could discuss co-marketing with? I'm not sure if there's a process for integrations outside the implementations. I can do some digging later today as well.

@marcosmarxm
Copy link
Member

Thank you so much @timroes @philkra @marcosmarxm for all of your help here! ❤️

I'm curious, we'll plan to blog about this, add to our docs and do a bit of social promotion. Is there anyone on the airbyte side we could discuss co-marketing with? I'm not sure if there's a process for integrations outside the implementations. I can do some digging later today as well.

@justinbchau can you help here?

@alexfrancoeur
Copy link

@justinbchau we'd love to collaborate on any co-marketing activities if you have the bandwidth. Streams, videos, blogs, social, etc. We're flexible. If not, you'll certainly be seeing some content on our end 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation community connectors/destination/xata new-destination
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants