🎉 Source Bind Ads: add campaignlabels col #24223

trowacat · 2023-03-19T17:46:40Z

What

Adds the field CampaignLabels to the campaign_performance_report stream.
Closes: 18476

How

Adds CampaignLabels in report streams. This is only available in campaign performance report.

Pre-merge Checklist

Updating a connector

Community member or Airbyter

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

Unit tests

collected 23 items

unit_tests/test_client.py::test_sudsobject_todict_primitive_types PASSED
unit_tests/test_client.py::test_sudsobject_todict_nested PASSED
unit_tests/test_client.py::test_is_expired_true PASSED
unit_tests/test_client.py::test_is_expired_true_with_delta_threshold PASSED
unit_tests/test_client.py::test_is_expired_false PASSED
unit_tests/test_client.py::test_get_auth_client {"type": "LOG", "log": {"level": "INFO", "message": "Fetching access token ..."}}
PASSED
unit_tests/test_reports.py::test_get_column_value PASSED
unit_tests/test_reports.py::test_get_updated_state_new_state PASSED
unit_tests/test_reports.py::test_get_updated_state_state_unchanged PASSED
unit_tests/test_reports.py::test_get_updated_state_state_new_account PASSED
unit_tests/test_reports.py::test_get_report_record_timestamp_daily PASSED
unit_tests/test_reports.py::test_get_report_record_timestamp_without_aggregation PASSED
unit_tests/test_reports.py::test_get_report_record_timestamp_hourly PASSED
unit_tests/test_source.py::test_streams_config_based PASSED
unit_tests/test_source.py::test_source_check_connection_ok PASSED
unit_tests/test_source.py::test_source_check_connection_failed PASSED
unit_tests/test_source.py::test_campaigns_request_params PASSED
unit_tests/test_source.py::test_campaigns_stream_slices PASSED
unit_tests/test_source.py::test_adgroups_stream_slices PASSED
unit_tests/test_source.py::test_ads_request_params PASSED
unit_tests/test_source.py::test_ads_stream_slices PASSED
unit_tests/test_source.py::test_AccountPerformanceReportMonthly_request_params PASSED
unit_tests/test_source.py::test_accounts PASSED

================================================================================================================= warnings summary =================================================================================================================
...
========================================================================================================== 23 passed, 5 warnings in 4.65s ==========================================================================================================

…ub.com/trowacat/airbyte into source-bing-ads-add-campaignlabels-col

CLAassistant · 2023-03-19T17:46:46Z

All committers have signed the CLA.

marcosmarxm · 2023-03-22T16:20:22Z

/test connector=connectors/source-bing-ads

🕑 connectors/source-bing-ads https://github.com/airbytehq/airbyte/actions/runs/4492115083
❌ connectors/source-bing-ads https://github.com/airbytehq/airbyte/actions/runs/4492115083
🐛

Build Failed

Test summary info:

Could not find result summary

sajarin · 2023-04-05T19:44:54Z

Hey thanks for the contribution and apologies for the delay!

I'll be the DRI responsible for reviewing this and getting it across the finish line. We currently have a backlog of about a dozen PRs, but just wanted to let you know that this PR has been added to the queue and I'll be trying my best to get to this as soon as possible.

Thanks for the contribution and for being patient :)

sajarin · 2023-04-07T17:39:19Z

/test connector=connectors/source-bing-ads

🕑 connectors/source-bing-ads https://github.com/airbytehq/airbyte/actions/runs/4640147517
❌ connectors/source-bing-ads https://github.com/airbytehq/airbyte/actions/runs/4640147517
🐛

Build Failed

Test summary info:

Could not find result summary

…ance streams

sajarin · 2023-04-10T19:51:04Z

/test connector=connectors/source-bing-ads

🕑 connectors/source-bing-ads https://github.com/airbytehq/airbyte/actions/runs/4660711928
✅ connectors/source-bing-ads https://github.com/airbytehq/airbyte/actions/runs/4660711928
Python tests coverage:

Name                          Stmts   Miss  Cover
-------------------------------------------------
source_bing_ads/__init__.py       2      0   100%
source_bing_ads/source.py       260     10    96%
source_bing_ads/cache.py         18      1    94%
source_bing_ads/reports.py      133     17    87%
source_bing_ads/client.py        93     21    77%
-------------------------------------------------
TOTAL                           506     49    90%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/plugin.py:63: Skipping TestIncremental.test_two_sequential_reads: SAT doesn't support complex nested states used in incremental report streams
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical.
================== 37 passed, 2 skipped in 486.67s (0:08:06) ===================

sajarin · 2023-04-10T19:52:21Z

Thanks for the contribution @trowacat, trying to get this merged in!

@midavadim can you help review this PR since it is a GA connector?

midavadim · 2023-04-25T11:32:47Z

...grations/connectors/source-bing-ads/source_bing_ads/schemas/campaign_performance_report.json

@@ -38,6 +38,9 @@
    "CampaignStatus": {
      "type": ["null", "string"]
    },
+    "CampaignLabels": {
+      "type": ["null", "string"]


Could you please confirm that CampaignLabels is just a string, because name assumes that there are a lot of labels (probably list of strings? )

@trowacat can you confirm the above, please? thanks

From: https://learn.microsoft.com/en-us/advertising/reporting-service/campaignperformancereportcolumn?view=bingads-13#campaignlabels

CampaignLabels
The labels applied to the campaign.Labels are delimited by a semicolon (;) in the report download.

@trowacat did you have time to take a look on this?

@midavadim I added some labels to our integration account data

The data field is correct.

marcosmarxm · 2023-05-08T22:06:11Z

...grations/connectors/source-bing-ads/source_bing_ads/schemas/campaign_performance_report.json

@@ -38,6 +38,9 @@
    "CampaignStatus": {
      "type": ["null", "string"]
    },
+    "CampaignLabels": {
+      "type": ["null", "string"]


@midavadim I added some labels to our integration account data

The data field is correct.

marcosmarxm · 2023-05-08T22:10:06Z

/test connector=connectors/source-bing-ads

🕑 connectors/source-bing-ads https://github.com/airbytehq/airbyte/actions/runs/4920101026
✅ connectors/source-bing-ads https://github.com/airbytehq/airbyte/actions/runs/4920101026
Python tests coverage:

Name                          Stmts   Miss  Cover
-------------------------------------------------
source_bing_ads/__init__.py       2      0   100%
source_bing_ads/source.py       260     10    96%
source_bing_ads/cache.py         18      1    94%
source_bing_ads/reports.py      142     16    89%
source_bing_ads/client.py        93     21    77%
-------------------------------------------------
TOTAL                           515     48    91%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/plugin.py:63: Skipping TestIncremental.test_two_sequential_reads: SAT doesn't support complex nested states used in incremental report streams
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical.
================== 37 passed, 2 skipped in 542.03s (0:09:02) ===================

marcosmarxm · 2023-05-09T17:19:08Z

/publish connector=connectors/source-bing-ads

🕑 Publishing the following connectors:
connectors/source-bing-ads
https://github.com/airbytehq/airbyte/actions/runs/4928637142

Connector	Version	Did it publish?	Were definitions generated?
connectors/source-bing-ads	0.1.22	✅	✅

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

* campaignLabels col * update pr number * updated expected_records.txt with campaign labels in campaign performance streams * fix expected records * bump metadata version * auto-bump connector version --------- Co-authored-by: Sajarin <sajarindider@gmail.com> Co-authored-by: marcosmarxm <marcosmarxm@gmail.com> Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>

trowacat added 2 commits March 19, 2023 14:41

campaignLabels col

e52452c

Merge branch 'source-bing-ads-add-campaignlabels-col' of https://gith…

2b05771

…ub.com/trowacat/airbyte into source-bing-ads-add-campaignlabels-col

octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation bounty community connectors/source/bing-ads labels Mar 19, 2023

update pr number

95d7938

marcosmarxm added the contributor-program PRs submitted through the contributor program. label Mar 22, 2023

sajarin self-assigned this Mar 30, 2023

marcosmarxm unassigned sajarin Apr 7, 2023

marcosmarxm added the ga-connector-change label Apr 7, 2023

Merge branch 'master' into source-bing-ads-add-campaignlabels-col

2f6340f

marcosmarxm assigned sajarin Apr 7, 2023

sajarin added 2 commits April 10, 2023 15:50

updated expected_records.txt with campaign labels in campaign perform…

06e2c35

…ance streams

Merge branch 'master' into source-bing-ads-add-campaignlabels-col

e7c918c

sajarin requested a review from midavadim April 10, 2023 19:51

sajarin approved these changes Apr 10, 2023

View reviewed changes

marcosmarxm self-assigned this Apr 17, 2023

marcosmarxm added the gl-review label Apr 17, 2023

midavadim reviewed Apr 25, 2023

View reviewed changes

marcosmarxm added 2 commits May 8, 2023 14:57

solve conflict

e45f344

fix expected records

1e85516

marcosmarxm approved these changes May 8, 2023

View reviewed changes

bump metadata version

5f1709e

marcosmarxm requested a review from midavadim May 8, 2023 22:50

midavadim approved these changes May 9, 2023

View reviewed changes

auto-bump connector version

953ab9e

marcosmarxm changed the title ~~Source bing ads add campaignlabels col~~ 🎉 Source Bind Ads: add campaignlabels col May 9, 2023

marcosmarxm merged commit 4806690 into airbytehq:master May 9, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🎉 Source Bind Ads: add campaignlabels col #24223

🎉 Source Bind Ads: add campaignlabels col #24223

trowacat commented Mar 19, 2023 •

edited

Loading

CLAassistant commented Mar 19, 2023 •

edited

Loading

marcosmarxm commented Mar 22, 2023 •

edited by github-actions bot

Loading

sajarin commented Apr 5, 2023 •

edited

Loading

sajarin commented Apr 7, 2023 •

edited by github-actions bot

Loading

sajarin commented Apr 10, 2023 •

edited by github-actions bot

Loading

sajarin commented Apr 10, 2023

midavadim Apr 25, 2023

jrolom Apr 27, 2023

marcosmarxm Apr 27, 2023

marcosmarxm May 4, 2023

marcosmarxm May 8, 2023

marcosmarxm May 8, 2023

marcosmarxm commented May 8, 2023 •

edited by github-actions bot

Loading

marcosmarxm commented May 9, 2023 •

edited by github-actions bot

Loading

🎉 Source Bind Ads: add campaignlabels col #24223

🎉 Source Bind Ads: add campaignlabels col #24223

Conversation

trowacat commented Mar 19, 2023 • edited Loading

What

How

Pre-merge Checklist

Community member or Airbyter

Airbyter

Unit tests

CLAassistant commented Mar 19, 2023 • edited Loading

marcosmarxm commented Mar 22, 2023 • edited by github-actions bot Loading

Build Failed

sajarin commented Apr 5, 2023 • edited Loading

sajarin commented Apr 7, 2023 • edited by github-actions bot Loading

Build Failed

sajarin commented Apr 10, 2023 • edited by github-actions bot Loading

Build Passed

sajarin commented Apr 10, 2023

midavadim Apr 25, 2023

Choose a reason for hiding this comment

jrolom Apr 27, 2023

Choose a reason for hiding this comment

marcosmarxm Apr 27, 2023

Choose a reason for hiding this comment

marcosmarxm May 4, 2023

Choose a reason for hiding this comment

marcosmarxm May 8, 2023

Choose a reason for hiding this comment

marcosmarxm May 8, 2023

Choose a reason for hiding this comment

marcosmarxm commented May 8, 2023 • edited by github-actions bot Loading

Build Passed

marcosmarxm commented May 9, 2023 • edited by github-actions bot Loading

trowacat commented Mar 19, 2023 •

edited

Loading

CLAassistant commented Mar 19, 2023 •

edited

Loading

marcosmarxm commented Mar 22, 2023 •

edited by github-actions bot

Loading

sajarin commented Apr 5, 2023 •

edited

Loading

sajarin commented Apr 7, 2023 •

edited by github-actions bot

Loading

sajarin commented Apr 10, 2023 •

edited by github-actions bot

Loading

marcosmarxm commented May 8, 2023 •

edited by github-actions bot

Loading

marcosmarxm commented May 9, 2023 •

edited by github-actions bot

Loading